From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=213.97.179.56 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792607601; b=vLz5TAgn+jWU8LWtzk0QBHJhgVpM0PZPyRa3b+kNqM8fVLn4ZR+CIr3X827oIcTt6/ds uSaSI3NNd78YbOxkiskRaCKlodgnmQsIB04rutQ1za+HCb+k3lEHvgYcHZg+LiLxCBgup /MpxgXjuHsAIQFI2loN69gOZA62Jw5KQ2YAhyV4FhEolQPF/DBp33yb8lY5T7CeDQdG3k FgJ9TWY/vYXJNlgi5keoIs+Z3sDdNNAuELP2+//yhj0w6fqqkhziJHIu55ciUSkCSlOlw NsID2pUivZ8H6uoJFzraVkEQoxDowuiGsKjd/wOmijlFOBAdWJVgwpfpfnYA/f4RzfQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792607601; h=DMARC-Filter:DKIM-Signature:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=7jgKOdLsgvQJKNOMTOZC41PaMPlEkcHgH9vTY2CQXdA=; b=Q4ZiOTZjKoa+upj3EYfpoJPllp8J/Dypfno3yFfwtEelaKoqzJf7hsSyYNFf57uF4a4T t0wn7D5iCFJw/M1iFmXI+pNP2M47cFsvWxyYCO+aUeSvR/xTPjLs5YKr45S+g8XgTJhbZ sUSoDs0ynIs/g9qSCPrHM9VUnUxeh4OSbctz38zegeKg3pJmkceMFMtCErFpPKKKi1BVg 9oTVfBoE5OFtP1v4QKY3iskyn2LSJ8IWtX6ADLTroNtqsWA+Xxr8eOf//HcRaDsjcuZcJ mMmCpGexn71XKlonNjrWPwANL/kRX241pvIyVlDfhjmlOagezCkEgJjW3o2ptZ2rM4Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=Igalia.com; spf=pass smtp.mailfrom=Igalia.com; dkim=pass header.d=igalia.com header.i=@igalia.com header.a=rsa-sha256 header.s=20170329 header.b=hecidf4Z; arc=none smtp.remote-ip=213.97.179.56 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9DBB606A319; Wed, 21 Oct 2026 18:33:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C9DBB606A319 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=Igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=Igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=igalia.com header.i=@igalia.com header.a=rsa-sha256 header.s=20170329 header.b=hecidf4Z DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:From:Cc:To:Subject: MIME-Version:Date:Message-ID:From:Reply-To; bh=7jgKOdLsgvQJKNOMTOZC41PaMPlEkcHgH9vTY2CQXdA=; b=hecidf4Zvb6KucUY3eq3X/XKXX sHiU+xXRkJcm0AGH6IlWOq91HFwHhsoEOBDkTQFSiTTnDI9i7wO3W3kuosxkigS7b+sCmtuB1xYYc QEboIVXsdwfdykMy8gmZUsfQ6mfPKMNla5dzFD1BWYjItwjq5qmQI1w/ZPRB9/sTWbyGTXGRn0EUo w6vOVGaGWgbA3gAs536+s5tdhNJb1tL9Z8R8/3esSMCNnAEnts1955hUcxOlMbmZ8ehRQ3Jv6sIzw XPkv2Nlpjxw0XMaA4eh69jlzryylEtuziFBxvFfU2SbSokBAM1U8hUf6NEBL9eIO6N6dcT9lXER70 xRE8vtSA==; Received: from c-73-157-168-91.hsd1.or.comcast.net ([73.157.168.91] helo=[192.168.1.133]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1xJb7V-005uGb-MW; Wed, 21 Oct 2026 20:33:01 +0200 Message-ID: <0328d182-0a13-45f9-9ae7-317453b7eec0@Igalia.com> Date: Wed, 21 Oct 2026 11:32:53 -0700 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 9/9] drm: writeback: drop the drmm writeback cleanup action To: Dmitry Baryshkov , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Louis Chauvet , Mihail Atanassov , Eric Anholt , Rob Clark , Brian Starkey Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org References: <20261019-wb-drop-encoder-v7-0-d4288a26eb54@oss.qualcomm.com> <20261019-wb-drop-encoder-v7-9-d4288a26eb54@oss.qualcomm.com> Content-Language: en-GB From: John Harrison In-Reply-To: <20261019-wb-drop-encoder-v7-9-d4288a26eb54@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/19/26 06:12, Dmitry Baryshkov wrote: > drmm_connector_init() already registers drm_connector_cleanup() as a > managed action, and that now cleans up the writeback state too. The > extra action registered by drmm_writeback_connector_init() just does the > same work a little earlier, leaving drm_connector_cleanup() nothing to > do. Drop it. > > Assisted-by: LLM > Signed-off-by: Dmitry Baryshkov Reviewed-by: John Harrison > --- > drivers/gpu/drm/drm_writeback.c | 25 ++++--------------------- > 1 file changed, 4 insertions(+), 21 deletions(-) > > diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c > index 272012a70efe..0c5d2fbe7a7c 100644 > --- a/drivers/gpu/drm/drm_writeback.c > +++ b/drivers/gpu/drm/drm_writeback.c > @@ -16,7 +16,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -303,14 +302,6 @@ void drm_writeback_connector_cleanup(struct drm_connector *connector) > spin_unlock_irqrestore(&wb_connector->job_lock, flags); > } > > -static void drm_writeback_connector_cleanup_action(struct drm_device *dev, > - void *data) > -{ > - struct drm_writeback_connector *wb_connector = data; > - > - drm_writeback_connector_cleanup(&wb_connector->base); > -} > - > /** > * drmm_writeback_connector_init - Initialize a writeback connector > * > @@ -321,7 +312,8 @@ static void drm_writeback_connector_cleanup_action(struct drm_device *dev, > * @formats: Array of supported pixel formats for the writeback engine > * @n_formats: Length of the formats array > * > - * This function initialize a writeback connector and register its cleanup. > + * This function initializes a writeback connector. Cleanup is automatically > + * handled with a call to drm_connector_cleanup() in a DRM-managed action. > * > * This function creates the writeback-connector-specific properties if they > * have not been already created, initializes the connector as > @@ -344,17 +336,8 @@ int drmm_writeback_connector_init(struct drm_device *dev, > if (ret) > return ret; > > - ret = __drm_writeback_connector_init(dev, wb_connector, enc, formats, > - n_formats); > - if (ret) > - return ret; > - > - ret = drmm_add_action_or_reset(dev, drm_writeback_connector_cleanup_action, > - wb_connector); > - if (ret) > - return ret; > - > - return 0; > + return __drm_writeback_connector_init(dev, wb_connector, enc, formats, > + n_formats); > } > EXPORT_SYMBOL(drmm_writeback_connector_init); > >