From: Kumar Gala <kumar.gala@freescale.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Paul Mackerras <paulus@samba.org>,
"Gala Kumar K.-galak" <galak@freescale.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel list <linux-kernel@vger.kernel.org>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Zachary Amsden <zach@vmware.com>
Subject: Re: [PATCH] ppc32: removed usage of <asm/segment.h>
Date: Wed, 17 Aug 2005 00:43:37 -0500 [thread overview]
Message-ID: <032E6AED-9456-4271-9B06-C5DCE5970193@freescale.com> (raw)
In-Reply-To: <20050816.203312.77701192.davem@davemloft.net>
On Aug 16, 2005, at 10:33 PM, David S. Miller wrote:
> From: Paul Mackerras <paulus@samba.org>
> Date: Wed, 17 Aug 2005 11:38:20 +1000
>
>
>> Kumar Gala writes:
>>
>>
>>> Made <asm/segment.h> a dummy include like it is in ppc64 and removed
>>>
> any
>
>>> users if it in arch/ppc.
>>>
>>
>> Why can't we just delete asm-ppc/segment.h (and asm-ppc64/segment.h
>> too, for that matter) entirely?
>>
>
> I concur, in fact we should really kill that thing off entirely.
I'm all for killing it off entirely but got some feedback that on
i386 segment.h can be included by userspace programs.
Here is the in kernel consumers that are outside of arch specific
directories:
./drivers/char/mxser.c:#include <asm/segment.h>
./drivers/isdn/hisax/hisax.h:#include <asm/segment.h>
./drivers/media/video/adv7170.c:#include <asm/segment.h>
./drivers/media/video/adv7175.c:#include <asm/segment.h>
./drivers/media/video/bt819.c:#include <asm/segment.h>
./drivers/media/video/bt856.c:#include <asm/segment.h>
./drivers/media/video/saa7111.c:#include <asm/segment.h>
./drivers/media/video/saa7114.c:#include <asm/segment.h>
./drivers/media/video/saa7185.c:#include <asm/segment.h>
./drivers/serial/68328serial.c:#include <asm/segment.h>
./drivers/serial/crisv10.c:#include <asm/segment.h>
./drivers/serial/icom.c:#include <asm/segment.h>
./drivers/serial/mcfserial.c:#include <asm/segment.h>
./drivers/video/q40fb.c:#include <asm/segment.h>
./include/linux/isdn.h:#include <asm/segment.h>
./sound/oss/os.h:#include <asm/segment.h>
- kumar
next prev parent reply other threads:[~2005-08-17 5:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-16 22:00 Kumar Gala
2005-08-17 1:38 ` Paul Mackerras
2005-08-17 3:33 ` David S. Miller
2005-08-17 5:43 ` Kumar Gala [this message]
2005-08-17 8:16 ` Geert Uytterhoeven
2005-08-17 8:30 ` Christoph Hellwig
2005-08-17 8:56 ` Miklos Szeredi
2005-08-17 9:09 ` Christoph Hellwig
2005-08-17 9:15 ` Miklos Szeredi
2005-08-17 9:20 ` Christoph Hellwig
2005-08-17 10:07 ` Miklos Szeredi
2005-08-18 16:25 ` Kumar Gala
2005-08-18 23:40 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=032E6AED-9456-4271-9B06-C5DCE5970193@freescale.com \
--to=kumar.gala@freescale.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=galak@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®