From: "Lynch, Rusty" <rusty.lynch@intel.com>
To: <davidm@hpl.hp.com>
Cc: <akpm@osdl.org>,
"Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com>,
<linux-kernel@vger.kernel.org>, <linux-ia64@vger.kernel.org>
Subject: RE: [patch] Kprobes ia64 qp fix
Date: Thu, 26 May 2005 11:23:44 -0700 [thread overview]
Message-ID: <032EB457B9DBC540BFB1B7B519C78B0E073AE2CC@orsmsx404.amr.corp.intel.com> (raw)
>>>>>> On Thu, 26 May 2005 10:51:45 -0700, Rusty Lynch
><rusty.lynch@intel.com> said:
>
> Rusty> The following patch is for the 2.6.12-rc5-mm1 + my previous
> Rusty> "Kprobes ia64 cleanup" patch that fixes a bug where a kprobe
still
> Rusty> fires when the instruction is predicated off. So given the
p6=0,
> Rusty> and we have an instruction like:
>
> Rusty> (p6) move loc1=0
>
> Rusty> we should not be triggering the kprobe. This is handled by
> Rusty> carrying over the qp section of the original instruction into
> Rusty> the break instruction.
>
>What about:
>
> (p6) cmp.eq.unc p9,p10=rX,rY
>
>would the code handle that right? Similary, you may want to check for
>the correct handling of instructions that cannot be predicated (such
>as "cover").
>
> --david
Thanks, I need to look into this one. Let me update my test to cover
both of these cases and then take another look at our logic.
--rusty
next reply other threads:[~2005-05-26 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-26 18:23 Lynch, Rusty [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-05-26 17:51 Rusty Lynch
2005-05-26 18:18 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=032EB457B9DBC540BFB1B7B519C78B0E073AE2CC@orsmsx404.amr.corp.intel.com \
--to=rusty.lynch@intel.com \
--cc=akpm@osdl.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davidm@hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®