From: Alexey Khoroshilov <khoroshilov@ispras.ru>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>, Arnd Bergmann <arnd@arndb.de>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] serial: 8250: fix error handling in of_platform_serial_probe()
Date: Tue, 18 Jul 2017 10:33:06 +0300 [thread overview]
Message-ID: <032e9a8b-8013-fe60-4a49-11cbf5cc28ed@ispras.ru> (raw)
In-Reply-To: <20170718072732.GA15573@kroah.com>
On 18.07.2017 10:27, Greg Kroah-Hartman wrote:
> On Sat, Jul 01, 2017 at 01:49:29AM +0300, Alexey Khoroshilov wrote:
>> clk_disable_unprepare(info->clk) is missed in of_platform_serial_probe(),
>> while irq_dispose_mapping(port->irq) is missed in of_platform_serial_setup().
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
>> ---
>> drivers/tty/serial/8250/8250_of.c | 20 +++++++++++++-------
>> 1 file changed, 13 insertions(+), 7 deletions(-)
>
> I've had to drop this from my tree due to the obvious build warning it
> adds to the system. Always test-build your patches before sending them
> out, it makes maintainers grumpy when you do not do that :(
>
> greg k-h
>
The problem is in conflict with e2860e1f62f2 "serial: 8250_of: Add reset
support" that was not in the Linus tree when the patch was developed.
I will rebase the patch and resend it.
--
Alexey
next prev parent reply other threads:[~2017-07-18 7:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 22:49 Alexey Khoroshilov
2017-07-18 7:27 ` Greg Kroah-Hartman
2017-07-18 7:33 ` Alexey Khoroshilov [this message]
2017-07-18 11:32 ` [PATCH v2] " Alexey Khoroshilov
2017-07-18 15:06 ` Andy Shevchenko
2017-07-18 15:45 ` Johan Hovold
2017-07-18 15:55 ` Andy Shevchenko
2017-07-19 8:32 ` [PATCH v3] " Alexey Khoroshilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=032e9a8b-8013-fe60-4a49-11cbf5cc28ed@ispras.ru \
--to=khoroshilov@ispras.ru \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®