Re: [PATCH net-next v1 8/9] net: dsa: microchip: init predictable IPV to queue mapping for all non KSZ8xxx variants

[<Arun.Ramadoss@microchip.com>]

Hi Oleksij,

On Thu, 2024-03-28 at 17:05 +0100, Oleksij Rempel wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> Init priority to queue mapping in the way as it shown in IEEE 802.1Q
> mapping example.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  drivers/net/dsa/microchip/ksz_common.c | 53 ++++++++++++++--------
> ----
>  1 file changed, 29 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/net/dsa/microchip/ksz_common.c
> b/drivers/net/dsa/microchip/ksz_common.c
> index 08426f85f7707..78e9610044ea8 100644
> --- a/drivers/net/dsa/microchip/ksz_common.c
> +++ b/drivers/net/dsa/microchip/ksz_common.c
> @@ -24,6 +24,7 @@
>  #include <linux/of_net.h>
>  #include <linux/micrel_phy.h>
>  #include <net/dsa.h>
> +#include <net/ieee8021q.h>
>  #include <net/pkt_cls.h>
>  #include <net/switchdev.h>
> 
> @@ -2692,9 +2693,29 @@ static int ksz_port_mdb_del(struct dsa_switch
> *ds, int port,
>         return dev->dev_ops->mdb_del(dev, port, mdb, db);
>  }
> 
> +static int ksz_set_default_prio_queue_mapping(struct ksz_device
> *dev, int port)

Since this function is related to KSZ9477 series switch, do we need to
move this function out of ksz_common.c or function name prefixed with
ksz9477_set_default_prio_queue_mapping to differentiate it.