From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm6115: Fix up cluster idle states
Date: Tue, 13 Jun 2023 21:14:58 +0200 [thread overview]
Message-ID: <0331a3c0-e3ab-9d5e-9d9b-99db798b1c64@linaro.org> (raw)
In-Reply-To: <20230613-topic-6115idlestates-v1-1-fa017052319d@linaro.org>
On 13.06.2023 21:13, Konrad Dybcio wrote:
> The lowest nibble of the PSCI suspend param denotes the CPU state.
> It was mistakenly set to mimic the cluster state, resulting in poking
> PSCI with undocumented 0x2 and 0x4 states (both of which seem to be
> implemented and undocumented). Also, GDHS cluster param was wrong for C1.
>
> Fix that.
>
> Fixes: b5de1a9ff1f2 ("arm64: dts: qcom: sm6115: Add CPU idle-states")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
Of course I remember about the tags right after I hit send..
Reported-by: Stephan Gerhold <stephan@gerhold.net>
Konrad
> arch/arm64/boot/dts/qcom/sm6115.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> index 55118577bf92..07d8b842d7be 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> @@ -225,7 +225,7 @@ domain-idle-states {
> CLUSTER_0_SLEEP_0: cluster-sleep-0-0 {
> /* GDHS */
> compatible = "domain-idle-state";
> - arm,psci-suspend-param = <0x40000022>;
> + arm,psci-suspend-param = <0x40000023>;
> entry-latency-us = <360>;
> exit-latency-us = <421>;
> min-residency-us = <782>;
> @@ -234,7 +234,7 @@ CLUSTER_0_SLEEP_0: cluster-sleep-0-0 {
> CLUSTER_0_SLEEP_1: cluster-sleep-0-1 {
> /* Power Collapse */
> compatible = "domain-idle-state";
> - arm,psci-suspend-param = <0x41000044>;
> + arm,psci-suspend-param = <0x41000043>;
> entry-latency-us = <800>;
> exit-latency-us = <2118>;
> min-residency-us = <7376>;
> @@ -243,7 +243,7 @@ CLUSTER_0_SLEEP_1: cluster-sleep-0-1 {
> CLUSTER_1_SLEEP_0: cluster-sleep-1-0 {
> /* GDHS */
> compatible = "domain-idle-state";
> - arm,psci-suspend-param = <0x40000042>;
> + arm,psci-suspend-param = <0x40000023>;
> entry-latency-us = <314>;
> exit-latency-us = <345>;
> min-residency-us = <660>;
> @@ -252,7 +252,7 @@ CLUSTER_1_SLEEP_0: cluster-sleep-1-0 {
> CLUSTER_1_SLEEP_1: cluster-sleep-1-1 {
> /* Power Collapse */
> compatible = "domain-idle-state";
> - arm,psci-suspend-param = <0x41000044>;
> + arm,psci-suspend-param = <0x41000043>;
> entry-latency-us = <640>;
> exit-latency-us = <1654>;
> min-residency-us = <8094>;
>
> ---
> base-commit: 1f6ce8392d6ff486af5ca96df9ded5882c4b6977
> change-id: 20230613-topic-6115idlestates-ba341792ebb2
>
> Best regards,
next prev parent reply other threads:[~2023-06-13 19:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 19:13 Konrad Dybcio
2023-06-13 19:14 ` Konrad Dybcio [this message]
2023-06-13 19:31 ` Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0331a3c0-e3ab-9d5e-9d9b-99db798b1c64@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®