From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7D0025487C for ; Sat, 30 Aug 2025 18:02:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756576952; cv=none; b=QKLYlYHv7ge4wqQY8GWQBOvb8Rt2fSbgmDWGdrOk0ZgxCntmqy+j1eWIlV6vWfgfm2YS98A4EbwcpuNMeopEb5BTn/8Du4uMNMBtCKgFENmLjC0PYRg6Zp22+l7myefvtzLPLxtnJvFbZEd2g8GtwtXCTSjaBSNI4gnQp2fsW4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756576952; c=relaxed/simple; bh=LL1hd9q8LJpTq1VIPJ6jPwhtJlsQGlDix5UjkykB4Z0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eGbw4XAtwkiDWXoCRQznUUcJx3S/W3eESftz2L6Vrys5v/Y2ivA0lxyuZMs0MNhH4t8HkOyCGy6SXsz20Jic2npzM4rSfulx9STt3mIhX62Z3UscuTGdL6w9ZMXv3T72tZ7j2IQIRjaJhKVeQwfRZ1eWqJoJB3FiTifrrJ9BSpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=d4kFHbRn; arc=none smtp.client-ip=209.85.160.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="d4kFHbRn" Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-30cceb07f45so3219153fac.2 for ; Sat, 30 Aug 2025 11:02:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1756576950; x=1757181750; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PD2EKFpAobF4U0TIuLMjpEcO1H/Nnyn+f8Dfu+DnkNI=; b=d4kFHbRnKQoKXBWL1zWyAwAs9XrZhybRacslpYsfOE/8svlNjSAa8Db/NCLXxiJRfA J2QD4/foHnDmHwjuCSsOjuJdbemw7PsoCS5Uu6HXPTYCRCgcgnVvheVSKQyQpip6/XBP MXz5Fm4B1McmU3Wff8PnTJzziO8LqKydzV6W7lgjTSLztkWWi8KoF8jJh5zTod8q8sIa wdfUEv0LJL8woK7iGwOs86dgFktN/7oUDsaxpR4w8skkPSaKoxIEI7ZTIEdD0ImcJ/2B NNHGtdWgXgCxV140u8AZQooK2BGzWxAuHzVH5fzMh7d38ELATTJP4PjnOCL/xLmLDsBH 4Piw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756576950; x=1757181750; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PD2EKFpAobF4U0TIuLMjpEcO1H/Nnyn+f8Dfu+DnkNI=; b=jdHVQewUTGIYwcRfk2M8gB7C2+ONC63+BDhGGhlU/hvQgd4q4o13iKdZZRuTdwqDBt Uka2Uw5wBIciag19efJ05JGDhFuLWAC/R/DfMsH5Hn7vGQqd5YWrwsbvnI1MvUfuc5Qe FEoXYURKeM0h3OFH/3Fj7+rFopSHVHLs5cYfn9e075KTxCOy1F3NbUlNEfdiMaxiZx1L xhIsWpp7SmP/Pnc3cn6cLu5WtjAQtl/sFKl0ZnRqeWa579JSQudVIhP6OmD2Tn/deHrp wPQgu3344/qMOO8Rg+7IoywIOyRzoLcR97LB+u8N4CUe2W7eGCslr4HJycwIa6A7YJAs UX7A== X-Forwarded-Encrypted: i=1; AJvYcCVKdQqTEVJQ0QiTLN7aiX6ohBik9dF2+9kw43xZXtUrtjdQFtfoJiFfPXMPTYHHkv3ZHmWqA3kXkWwpnsc=@vger.kernel.org X-Gm-Message-State: AOJu0YwqJiM2l2JksvXw7iWg+p7eje4R5F9XtZidVSLPQqNh7On0w7mN q6DtqfpaDltz9HrgUxMpyaAns955ffjylQbiToexm2GIF0421PJFudmZMWTgB9pa1Gw= X-Gm-Gg: ASbGnct1A8LLKu0VCRYWxdRPHFqc3Vnv8DDqF6MllJ1Xknl1WqHfHhosclriUI/b8Hc aPrf87l4DHKPa54xXY9xHMSEk89P8aoz6TFF4O4ubG6ik4DMoYQ5vJlON0BLoCwihFwQ7lWkYCM cInF0KCrldCxg3AIfPcjj1ayu/PcuOpoEot7rWLoYg07NT3W+WiqcGO736QlgwhWqgyRbRWDdt1 Te2I44yIUJA/OoaZTAk0re/sQpLbc862OEpvOlkRWDEkL46KTNNmHswTLAxtOMVqfF4OARA0fss /1IKOFp+omtC8PjfXP2GWIqpHbc/mRP51vnoE2ig2IvYsoM6tGqZFf9XORxXp/dkExzuTobW1Y6 djT6ghfZspfsIc8w9MbGfje6QGukgeGGJb+6ouHnZx7zSqmma5z39UlZSsmbIxmOCb+RU8xPnRB U+VR6Mc7tDlQ== X-Google-Smtp-Source: AGHT+IGSJvFvC9dcmKaGf9glwESPFKs7sboRW3GSWHC52Tz6jlzKsP6xrkD7Hc7UHEkT8qvw/3aY5Q== X-Received: by 2002:a05:6870:c0d:b0:315:b768:bd23 with SMTP id 586e51a60fabf-319633c79a1mr1298016fac.34.1756576949951; Sat, 30 Aug 2025 11:02:29 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:f7b4:dfbd:5110:c59d? ([2600:8803:e7e4:1d00:f7b4:dfbd:5110:c59d]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3196d2a7f3csm392769fac.8.2025.08.30.11.02.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Aug 2025 11:02:29 -0700 (PDT) Message-ID: <033e8639-67db-4397-b8c1-d1b7774eb9fe@baylibre.com> Date: Sat, 30 Aug 2025 13:02:28 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/15] dt-bindings: iio: adc: adi,ad4030: Add adi,clock-mode To: Marcelo Schmitt , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-spi@vger.kernel.org Cc: jic23@kernel.org, Michael.Hennerich@analog.com, nuno.sa@analog.com, eblanc@baylibre.com, andy@kernel.org, corbet@lwn.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, broonie@kernel.org, Jonathan.Cameron@huawei.com, andriy.shevchenko@linux.intel.com, ahaslam@baylibre.com, sergiu.cuciurean@analog.com, marcelo.schmitt1@gmail.com References: <1acb071f7140c9d44ed616a9eaea00b0ee423164.1756511030.git.marcelo.schmitt@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <1acb071f7140c9d44ed616a9eaea00b0ee423164.1756511030.git.marcelo.schmitt@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/29/25 7:43 PM, Marcelo Schmitt wrote: > AD4030 and similar designs support three different options for the clock > that frames ADC output data. Each option implies a different hardware > configuration for reading ADC data. Document AD4030 clock mode options. > > Co-developed-by: Sergiu Cuciurean > Signed-off-by: Sergiu Cuciurean > Signed-off-by: Marcelo Schmitt > --- > .../devicetree/bindings/iio/adc/adi,ad4030.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml > index bee85087a7b2..1e4e025b835f 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml > @@ -78,6 +78,18 @@ properties: > interrupt-names: > const: busy > > + adi,clock-mode: > + $ref: /schemas/types.yaml#/definitions/string > + enum: [ spi, echo, host ] > + default: spi > + description: > + Describes how the clock that frames ADC data output is setup. > + spi - Spi-compatible. Normal SPI operation clocking. > + echo - Echo-clock. Synchronous clock echoing to ease timing requirements > + when using isolation on the digital interface. > + host - Host. The Host clock mode uses an internal oscillator to clock out > + the data bits. In this mode, the spi controller is not driving SCLK. > + > required: > - compatible > - reg I think this would make sense as a common property in spi-peripheral-props.yaml as this is something that is not specific to just this ADC and also requires a supporting SPI controller with the matching wiring. I would also tweak the names and descriptions a bit to describe how it is wired rather than how it is used. spi-sclk-source: enum: [ controller, echo, peripheral ] default: controller description: | Indicates how the SCLK is wired. controller: The SCLK line is driven by the controller (typical SPI bus). echo: The SCLK line is driven by the controller and the peripheral echos the clock back to an input on the controller on a second line. peripheral: The SCLK line from the controller is not connected to the peripheral and an independent clock output driven by the peripheral is connected to an input on the controller.