Re: [PATCH net-next v16 00/12] net: pcs: Introduce support for fwnode PCS

[Maxime Chevallier <maxime.chevallier@bootlin.com>]

Hi,

On 9/22/26 12:12, Christian Marangi (Ansuel) wrote:
> Il giorno lun 21 set 2026 alle ore 22:59 Jakub Kicinski
> <kuba@kernel.org> ha scritto:
>>
>> On Thu, 17 Sep 2026 01:51:26 +0200 Christian Marangi wrote:
>>> This series introduce a most awaited feature that is correctly
>>> provide PCS with fwnode without having to use specific export symbol
>>> and additional handling of PCS in phylink.
>>>
>>> At times there were 2 different implementation (this and the one
>>> from Sean) but Sean agreed that this can be picked and used in favor
>>> of his implementation as long as his case with race condition is
>>> correctly handled.
>>
>> Looks like the review for one of the patches failed so it won't be
>> emailed out:
>> https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260916235200.20712-2-ansuelsmth@gmail.com
>>
>> Are all of the issues invalid?
> 
> Only one is relevant, but expected.
> 
> The remark on the fwnode patch are invalid. The driver is expected
> to return those error as probe defer is not supported.
> (a notifier and late attach/detach is used to align to phylink logic)
> 
> For the specific Airoha PCS driver it's really speculation from the AI
> but HW doesn't work as described by AI.
> 
> The only real comment that is valid is about the alternative way
> to give supported interface with the .get_capabilites OP.
> 
> This is currently not supported as there isn't any user and it will
> be implemented as soon as there will be one. It's really to limit
> the patch delta of this change and to progress further.
> 
> Maybe FIXME might be suitable?
> 
>>
>> Once the AI review is cleared, some human will have to review this
>> and vouch for you as a maintainer. Better still be your co-maintainer.
> 
> I think some revision ago there was Andrew that reviewed some code.
> Anyway thank a lot for checking this once in a while, I feel it's a pretty
> important change but I understand it's complex to handle as it does
> introduce a whole new subsystem.

I'm attending a Rust training until thursday, I'll see if I can squeeze in some
time to re-test on mvpp2 :(

There're a few series pending for rockchip and S32 on stmmac that deal with
PCS support and their PCS handle. It would be nice to have some stmmac glue
maintainers that are using complex PCS to help with maintainance or at least
testing, maybe Coia can help with the tests ?

Maxime