From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Wolfram Sang" <wsa@kernel.org>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Matti Vaittinen" <Matti.Vaittinen@fi.rohmeurope.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Peter Rosin" <peda@axentia.se>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"Michael Tretter" <m.tretter@pengutronix.de>,
"Shawn Tu" <shawnx.tu@intel.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Mike Pagano" <mpagano@gentoo.org>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Marek Vasut" <marex@denx.de>
Subject: Re: [PATCH v5 0/8] i2c-atr and FPDLink
Date: Thu, 8 Dec 2022 16:40:58 +0200 [thread overview]
Message-ID: <0340d15c-be0a-cd28-4149-7976896f8eb1@ideasonboard.com> (raw)
In-Reply-To: <Y5HYBzZlkTrsdjfX@smile.fi.intel.com>
Hi Andy,
On 08/12/2022 14:26, Andy Shevchenko wrote:
> On Thu, Dec 08, 2022 at 12:42:13PM +0200, Tomi Valkeinen wrote:
>> On 08/12/2022 12:39, Tomi Valkeinen wrote:
>
> ...
>
>> +#include <linux/fwnode.h>
>> #include <linux/i2c-atr.h>
>> #include <linux/i2c.h>
>> #include <linux/kernel.h>
>> #include <linux/module.h>
>> #include <linux/mutex.h>
>> -#include <linux/of.h>
>> #include <linux/slab.h>
>
> + Blank line here?
>
There is a blank line there.
>> +#define ATR_MAX_ADAPTERS 99 /* Just a sanity limit */
>> +#define ATR_MAX_SYMLINK_LEN 16 /* Longest name is 10 chars: "channel-99" */
>
> ...
>
>> + u16 *new_buf;
>> +
>> + new_buf = kmalloc_array(num, sizeof(chan->orig_addrs[0]),
>> + GFP_KERNEL);
>
> new_buf = kmalloc_array(num, sizeof(*new_buf), GFP_KERNEL);
>
> ?
Yes, I think that looks better here.
>> + if (!new_buf)
>> return -ENOMEM;
>
> ...
>
>> struct i2c_atr_cli2alias_pair *c2a;
>> - u16 alias_id = 0;
>> - int ret = 0;
>> + u16 alias_id;
>> + int ret;
>
> Is it mangled or it's missing blank line here?
Also here there is a blank line. Is the mail somehow mangled on your
side? On lore it looks fine:
https://lore.kernel.org/all/c5eac6a6-f44b-ddd0-d27b-ccbe01498ae9@ideasonboard.com/
>> c2a = kzalloc(sizeof(*c2a), GFP_KERNEL);
>> if (!c2a)
>
> ...
>
>> struct device;
>> struct i2c_atr;
>> +struct fwnode_handle;
>
> Order?
Yep, I'll fix.
> ...
>
>> /**
>> - * Helper to add I2C ATR features to a device driver.
>> + * struct i2c_atr - Represents the I2C ATR instance
>> */
>
> This is incomplete. Have you run kernel doc validator against this file?
What's kernel doc validator? Do you mean that it's incomplete and kernel
doc doesn't work correctly, or that there should be more information here?
I don't get any errors/warnings from any tool I have used. But I agree
it looks a bit odd with only the name of the struct in the doc.
Tomi
next prev parent reply other threads:[~2022-12-08 14:41 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 10:39 Tomi Valkeinen
2022-12-08 10:39 ` [PATCH v5 1/8] i2c: core: let adapters be notified of client attach/detach Tomi Valkeinen
2022-12-08 12:30 ` Andy Shevchenko
2022-12-08 16:10 ` Tomi Valkeinen
2022-12-11 16:55 ` Laurent Pinchart
2022-12-19 8:51 ` Luca Ceresoli
2022-12-19 9:48 ` Andy Shevchenko
2022-12-26 16:54 ` Laurent Pinchart
2022-12-27 20:07 ` Andy Shevchenko
2022-12-08 10:40 ` [PATCH v5 2/8] i2c: add I2C Address Translator (ATR) support Tomi Valkeinen
2022-12-08 12:53 ` Andy Shevchenko
2022-12-08 16:01 ` Tomi Valkeinen
2022-12-08 18:09 ` Andy Shevchenko
2022-12-08 10:40 ` [PATCH v5 3/8] dt-bindings: media: add bindings for TI DS90UB913 Tomi Valkeinen
2022-12-11 17:13 ` Laurent Pinchart
2022-12-11 17:21 ` Laurent Pinchart
2022-12-13 13:36 ` Tomi Valkeinen
2022-12-26 16:46 ` Laurent Pinchart
2023-01-04 8:12 ` Tomi Valkeinen
2023-01-04 12:52 ` Laurent Pinchart
2022-12-13 13:21 ` Tomi Valkeinen
2022-12-08 10:40 ` [PATCH v5 4/8] dt-bindings: media: add bindings for TI DS90UB953 Tomi Valkeinen
2022-12-09 21:27 ` Rob Herring
2023-01-04 8:26 ` Tomi Valkeinen
2022-12-11 17:34 ` Laurent Pinchart
2022-12-13 14:06 ` Tomi Valkeinen
2022-12-08 10:40 ` [PATCH v5 5/8] dt-bindings: media: add bindings for TI DS90UB960 Tomi Valkeinen
2022-12-09 21:30 ` Rob Herring
2022-12-11 17:58 ` Laurent Pinchart
2022-12-13 14:25 ` Tomi Valkeinen
2022-12-26 16:52 ` Laurent Pinchart
2023-01-04 8:59 ` Tomi Valkeinen
2023-01-04 12:57 ` Laurent Pinchart
2023-01-04 14:05 ` Tomi Valkeinen
2023-01-05 6:54 ` Laurent Pinchart
2022-12-08 10:40 ` [PATCH v5 6/8] media: i2c: add DS90UB960 driver Tomi Valkeinen
2022-12-08 10:40 ` [PATCH v5 7/8] media: i2c: add DS90UB913 driver Tomi Valkeinen
2022-12-11 18:33 ` Laurent Pinchart
2022-12-14 6:29 ` Tomi Valkeinen
2022-12-14 6:36 ` Tomi Valkeinen
2022-12-26 16:56 ` Laurent Pinchart
2022-12-26 19:25 ` Tomi Valkeinen
2023-01-04 13:55 ` Laurent Pinchart
2023-01-04 14:13 ` Tomi Valkeinen
2023-01-04 15:32 ` Laurent Pinchart
2023-01-04 15:43 ` Tomi Valkeinen
2022-12-26 17:01 ` Laurent Pinchart
2022-12-27 20:09 ` Andy Shevchenko
2023-01-04 13:29 ` Laurent Pinchart
2022-12-14 6:48 ` Tomi Valkeinen
2022-12-08 10:40 ` [PATCH v5 8/8] media: i2c: add DS90UB953 driver Tomi Valkeinen
2022-12-08 10:42 ` [PATCH v5 0/8] i2c-atr and FPDLink Tomi Valkeinen
2022-12-08 12:26 ` Andy Shevchenko
2022-12-08 14:40 ` Tomi Valkeinen [this message]
2022-12-08 15:57 ` Andy Shevchenko
2022-12-08 15:58 ` Andy Shevchenko
2022-12-08 16:05 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0340d15c-be0a-cd28-4149-7976896f8eb1@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=khalasa@piap.pl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.tretter@pengutronix.de \
--cc=marex@denx.de \
--cc=mchehab@kernel.org \
--cc=mpagano@gentoo.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnx.tu@intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®