From: Reinette Chatre <reinette.chatre@intel.com>
To: Peter Newman <peternewman@google.com>, <fenghua.yu@intel.com>
Cc: <Babu.Moger@amd.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <eranian@google.com>,
<gupasani@google.com>, <hpa@zytor.com>, <james.morse@arm.com>,
<linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
<skodak@google.com>, <tony.luck@intel.com>, <tglx@linutronix.de>,
<x86@kernel.org>
Subject: Re: [PATCH v3 1/3] x86/resctrl: Factor rdtgroup lock for multi-file ops
Date: Fri, 10 Feb 2023 15:21:01 -0800 [thread overview]
Message-ID: <03414cfb-1f82-0422-73e7-4e5b2479bc5e@intel.com> (raw)
In-Reply-To: <20230125101334.1069060-2-peternewman@google.com>
Hi Peter,
On 1/25/2023 2:13 AM, Peter Newman wrote:
> rdtgroup_kn_lock_live() can only release a kernfs lock for a single file
how about s/kernfs lock/kernfs reference/?
> before waiting on the rdtgroup_mutex, limiting its usefulness for
> operations on multiple files, such as rename.
>
> Factor the work needed to respectively break and unbreak active
> protection on an individual file into rdtgroup_kn_{get,put}().
>
> This should not result in any functional change.
>
"should" has been a trigger word on occasion. You can just
write "No functional change." (also in second patch).
Reinette
next prev parent reply other threads:[~2023-02-10 23:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 10:13 [PATCH v3 0/3] x86/resctrl: Implement rename to help move containers' tasks Peter Newman
2023-01-25 10:13 ` [PATCH v3 1/3] x86/resctrl: Factor rdtgroup lock for multi-file ops Peter Newman
2023-02-10 23:21 ` Reinette Chatre [this message]
2023-01-25 10:13 ` [PATCH v3 2/3] x86/resctrl: Factor work to update task CLOSID/RMID Peter Newman
2023-01-25 10:13 ` [PATCH v3 3/3] x86/resctrl: Implement rename op for mon groups Peter Newman
2023-02-10 23:21 ` Reinette Chatre
2023-03-02 14:26 ` Peter Newman
2023-03-02 22:26 ` Reinette Chatre
2023-03-03 15:10 ` Peter Newman
2023-03-03 19:05 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03414cfb-1f82-0422-73e7-4e5b2479bc5e@intel.com \
--to=reinette.chatre@intel.com \
--cc=Babu.Moger@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=gupasani@google.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peternewman@google.com \
--cc=skodak@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome