From: Dan Carpenter <dan.carpenter@linaro.org>
To: drosdeck <edson.drosdeck@gmail.com>
Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com,
Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs:Fix coding style errors and warning
Date: Wed, 11 Oct 2023 20:30:21 +0300 [thread overview]
Message-ID: <03446a07-ef54-49c3-a7a2-644715603891@kadam.mountain> (raw)
In-Reply-To: <20231011164232.28866-1-edson.drosdeck@gmail.com>
You need to fix your From: header.
On Wed, Oct 11, 2023 at 01:42:32PM -0300, drosdeck wrote:
> Warning found by checkpatch.pl script. Fixes warning replacing printk to
> pr_crit and fixes conding style.
>
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 21 +++++++++-----------
> 1 file changed, 9 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index 490431484524..e178a6881e0c 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -48,7 +48,6 @@ static void sd_sync_int_hdl(struct sdio_func *func)
> {
> struct dvobj_priv *psdpriv;
>
> -
> psdpriv = sdio_get_drvdata(func);
>
> if (!psdpriv->if1)
> @@ -73,7 +72,7 @@ static int sdio_alloc_irq(struct dvobj_priv *dvobj)
> err = sdio_claim_irq(func, &sd_sync_int_hdl);
> if (err) {
> dvobj->drv_dbg.dbg_sdio_alloc_irq_error_cnt++;
> - printk(KERN_CRIT "%s: sdio_claim_irq FAIL(%d)!\n", __func__, err);
> + pr_crit("%s: sdio_claim_irq FAIL(%d)!\n", __func__, err);
Use dev_crit() instead.
Otherwise the rest of the changes are fine, but you'll need to break
the patch up into multiple patches.
regards,
dan carpenter
next prev parent reply other threads:[~2023-10-11 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 16:42 drosdeck
2023-10-11 16:39 ` Nam Cao
2023-10-11 17:30 ` Dan Carpenter [this message]
2023-10-11 17:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03446a07-ef54-49c3-a7a2-644715603891@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=Larry.Finger@lwfinger.net \
--cc=edson.drosdeck@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®