From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96588C4167B for ; Wed, 13 Dec 2023 10:23:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235301AbjLMKXN (ORCPT ); Wed, 13 Dec 2023 05:23:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235299AbjLMKXM (ORCPT ); Wed, 13 Dec 2023 05:23:12 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C72BD5 for ; Wed, 13 Dec 2023 02:23:15 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40c41df5577so36004145e9.0 for ; Wed, 13 Dec 2023 02:23:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702462994; x=1703067794; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=LB4BasK5GoWh/K84I8G86ib6X3/yOsf6mofMtXVoDTU=; b=VHwvZE7A1Jg/tAu5C1eGdSvvsZJ7Cv+6WfrPSFVPnCd/NTL+wbIlZlMSNtOERPW2l5 jZUZaEnw0yFmnrFcoGomDEq1kCUCslD2R8ugRx3XJujXdYEKjO7zXHq1eWlvgwF5Awmz CmBH7/mI9syr0KhFfZ0bl9FquiTzFAYXGMVFJAHXV0rVXUDmvyr8pJ1tDoNOScYSZilp bwczJjOLpBvX0CX7R8mT5kAfsyiML4PA4MmZauh6v07bR0Hf8rf2lKL0v20g7J8ISP/s xXhQjQ3fWga4x8HO04L7QzcC4n4MVVy/pGhBqChPbMAGCiMhjpWg4JYWFKgEPHHP7Yau iEJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702462994; x=1703067794; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LB4BasK5GoWh/K84I8G86ib6X3/yOsf6mofMtXVoDTU=; b=oKZpic/STeYuyIAbuQM3lNJLnbYPChyhbsoC1fIocWgCNHVz+3VIQZtXN1hF3h29MV QqA+ZNg6Zkv/fKQZ3CZokPD54/OA/KMxUxpFS5vsqADWyO8M88A7TPCWuBJ/GC5APJgG GNNSHGWOCGr8yMfOq5Bkk+WcSwg5zdDp0HxZa3tIlbTkuPISxJPWdwN58atAMY48hGXJ xOcSNm0pNd+pDH+qxL3wPkPvoFnO6dZlPwcg4l28C8/j43sE7hV2O/34a+AkjG/Cl+X+ W26xu3GKJHvBXgztT5e840YVS8vjSl90LTCLyx1ItoV7oIXvo7i3gfFQQWCxpJAxr3ZK WAcw== X-Gm-Message-State: AOJu0YzL+GjoEc5y6jzYvWUGwpo+R4RrFNv2flpvtNMhMqCb9v/VZWSY J9LgLaInwyXEdeKwtLvrPROAoA== X-Google-Smtp-Source: AGHT+IEvVp4F2aI9Ka4d5ZnfFChJkVgwYC5tlOnduuCZ9TXMNMxQElEDJXhMex4K9PKfu6zHwN1I/g== X-Received: by 2002:a05:600c:6022:b0:40c:25c0:4927 with SMTP id az34-20020a05600c602200b0040c25c04927mr2081870wmb.302.1702462993821; Wed, 13 Dec 2023 02:23:13 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:596e:6d4f:fc0a:ec65? ([2a01:e0a:982:cbb0:596e:6d4f:fc0a:ec65]) by smtp.gmail.com with ESMTPSA id p14-20020a05600c358e00b0040c37c4c229sm17167006wmq.14.2023.12.13.02.23.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 02:23:13 -0800 (PST) Message-ID: <0346d0cf-d5e6-4d74-b563-1ad3ae717701@linaro.org> Date: Wed, 13 Dec 2023 11:23:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/3] soc: qcom: pmic_pdcharger_ulog: Search current directory for headers Content-Language: en-US, fr To: Andrew Halaney Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231205-pmicpdcharger-ulog-fixups-v1-0-71c95162cb84@redhat.com> <20231205-pmicpdcharger-ulog-fixups-v1-1-71c95162cb84@redhat.com> <320864f5-fdd2-4345-a0dd-b97bcf17f473@linaro.org> <139f9af0-ca6a-4a58-ae18-79ef6fac47e3@linaro.org> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On 12/12/2023 23:21, Andrew Halaney wrote: > On Tue, Dec 12, 2023 at 08:21:41PM +0100, Neil Armstrong wrote: >> On 12/12/2023 17:52, Neil Armstrong wrote: >>> On 12/12/2023 17:15, Andrew Halaney wrote: >>>> On Tue, Dec 12, 2023 at 09:54:48AM -0600, Andrew Halaney wrote: >>>>> On Tue, Dec 12, 2023 at 04:23:20PM +0100, Neil Armstrong wrote: >>>>>> Hi Andrew, >>>>>> >>>>>> On 06/12/2023 00:05, Andrew Halaney wrote: >>>>>>> As specified in samples/trace_events/Makefile: >>>>>>> >>>>>>>       If you include a trace header outside of include/trace/events >>>>>>>       then the file that does the #define CREATE_TRACE_POINTS must >>>>>>>       have that tracer file in its main search path. This is because >>>>>>>       define_trace.h will include it, and must be able to find it from >>>>>>>       the include/trace directory. >>>>>>> >>>>>>> Without this the following compilation error is seen: >>>>>>> >>>>>>>         CC      drivers/soc/qcom/pmic_pdcharger_ulog.o >>>>>>>       In file included from drivers/soc/qcom/pmic_pdcharger_ulog.h:36, >>>>>>>                        from drivers/soc/qcom/pmic_pdcharger_ulog.c:15: >>>>>>>       ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory >>>>>>>          95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) >>>>>>>             |                                          ^ >>>>>>>       compilation terminated. >>>>>> >>>>>> I never experienced such error, and no CI even reported it, can you explain how you got this ? >>>>> >>>>> To be honest, I am unsure why I'm experiencing this (and until I saw >>>>> another thread about it today I thought maybe I had screwed something >>>>> up!). >>>>> >>>>> I just took it as an opportunity to try and read up on the tracing >>>>> infrastructure and sent this series. Definitely no expertise with the >>>>> in's and out's of tracing :) >>>>> >>>>> I'm able to reproduce this on next-20231211: >>>>> >>>>>      ahalaney@fedora ~/git/linux-next (git)-[b4/b4-stmmac-handle-mdio-enodev] % ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make mrproper >>>>>      >>>>>      ahalaney@fedora ~/git/linux-next (git)-[b4/b4-stmmac-handle-mdio-enodev] % ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make defconfig >>>>>      >>>>>      *** Default configuration is based on 'defconfig' >>>>>      # >>>>>      # configuration written to .config >>>>>      # >>>> >>>> Realized I missed a step, actually enabling tracing and the driver at >>>> play here... but the result is the same. >>>> >>>> Attached is a config where I hit this. >>>> >>>>>      130 ahalaney@fedora ~/git/linux-next (git)-[b4/b4-stmmac-handle-mdio-enodev] % ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make drivers/soc/qcom/pmic_pdcharger_ulog.o >>>>>        HOSTCC  scripts/dtc/dtc.o >>>>>      >>>>>        CC      drivers/soc/qcom/pmic_pdcharger_ulog.o >>>>>      In file included from drivers/soc/qcom/pmic_pdcharger_ulog.h:36, >>>>>              from drivers/soc/qcom/pmic_pdcharger_ulog.c:15: >>>>>      ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory >>>>>         95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) >>>>>      >>>>>      2 ahalaney@fedora ~/git/linux-next (git)-[b4/b4-stmmac-handle-mdio-enodev] % >>>>> >>>>> I even tried it in a fedora container with the above build commands and >>>>> the following podman invocation (plus some package installs) and saw the error: >>>>> >>>>>      podman run -it -v ~/git/linux-next:/linux-next:z quay.io/fedora/fedora:latest /bin/bash >>>>> >>>>> So I'm unsure if it's a fedora package version thing (which I'm running on my host) >>>>> or something else... Once I saw it was sort of spelled out in the >>>>> examples I referenced here I just decided it was something needed >>>>> fixing, regardless of why I'm hitting it while others seem ok. >>> >>> Interesting, I don't get the problem with the same tag, same .config but with gcc-arm-10.3-2021.07-x86_64-aarch64-none-linux-gnu >>> >>> I'll try with gcc 13. >> >> Ok tried with ARM's arm-gnu-toolchain-13.2.rel1-x86_64-aarch64-none-linux-gnu (https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads), >> and no error, and I even tried with https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/13.2.0/ and same no error... > > Hmm. I'm unsure what's up. I tried with a debian container and a fresh > clone and still saw it :/ > > If you want, something like (swap docker for podman if that's your > thing): podman run -it debian:latest /bin/bash > should let you reproduce after cloning etc. I was able to reproduce it in fedora:latest: CC [M] drivers/soc/qcom/pmic_pdcharger_ulog.o In file included from drivers/soc/qcom/pmic_pdcharger_ulog.h:36, from drivers/soc/qcom/pmic_pdcharger_ulog.c:15: ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) | ^ and debian:latest: CC [M] drivers/soc/qcom/pmic_pdcharger_ulog.o In file included from drivers/soc/qcom/pmic_pdcharger_ulog.h:36, from drivers/soc/qcom/pmic_pdcharger_ulog.c:15: ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) | ^ But in my build setup I always build of of tree: $ ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make O=$PWD/out/ drivers/soc/qcom/pmic_pdcharger_ulog.o ... CC drivers/soc/qcom/pmic_pdcharger_ulog.o make[1]: Leaving directory '/linux-next/out' So why building out of tree works ? (likewise all CI builds out of tree) Neil > >> >> Neil >> >>> >>> Neil >>> >>>>> >>>>>> >>>>>> Thanks, >>>>>> Neil >>>>>> >>>>>>> >>>>>>> Fixes: 086fdb48bc65 ("soc: qcom: add ADSP PDCharger ULOG driver") >>>>>>> Signed-off-by: Andrew Halaney >>>>>>> --- >>>>>>>    drivers/soc/qcom/Makefile | 1 + >>>>>>>    1 file changed, 1 insertion(+) >>>>>>> >>>>>>> diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile >>>>>>> index 110108e23669..05b3d54e8dc9 100644 >>>>>>> --- a/drivers/soc/qcom/Makefile >>>>>>> +++ b/drivers/soc/qcom/Makefile >>>>>>> @@ -10,6 +10,7 @@ obj-$(CONFIG_QCOM_PDR_HELPERS)    += pdr_interface.o >>>>>>>    obj-$(CONFIG_QCOM_PMIC_GLINK)    += pmic_glink.o >>>>>>>    obj-$(CONFIG_QCOM_PMIC_GLINK)    += pmic_glink_altmode.o >>>>>>>    obj-$(CONFIG_QCOM_PMIC_PDCHARGER_ULOG)    += pmic_pdcharger_ulog.o >>>>>>> +CFLAGS_pmic_pdcharger_ulog.o    :=  -I$(src) >>>>>>>    obj-$(CONFIG_QCOM_QMI_HELPERS)    += qmi_helpers.o >>>>>>>    qmi_helpers-y    += qmi_encdec.o qmi_interface.o >>>>>>>    obj-$(CONFIG_QCOM_RAMP_CTRL)    += ramp_controller.o >>>>>>> >>>>>> >>> >> >