From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AA9D413623 for ; Tue, 9 Jun 2026 12:38:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781008696; cv=none; b=Kky9nORy3+2ri90ceFb64ueIF5Cc9V077gf7X8ZY5VtbH2NHNDz/evZPzBWqeKmVVdjX1DBjbt+5LvIZhknG+px2CC9sJ4XnfjaztDpvlcQPRDRE60uhgR8MJQaRri4cN/DSLDuJqX5Lj9922JYIJbwcY02gzKpvcyVtlAzDAE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781008696; c=relaxed/simple; bh=mRigYsMz/Vz1sevTe6C/YeJI+ZTCaQr7OOMfR1RkZx8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=twlCZuIYaNWzYPc976R9Sob9seN+8IpIcAsLwdEv5zOgDqmZHguDG4EC4WL1juDhFMzlotSSA7hXdT/jVNKtjd+W20pnRC3PAlQg4HXRErHMxoayp5pQnBg4GMfWmCwjZBnkeRhLysGYy6nTouw4YpawFpmXuwC76G7WDnEhw0E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YZFeaw/a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ah/X19r5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YZFeaw/a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ah/X19r5" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 659BnODP519361 for ; Tue, 9 Jun 2026 12:38:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SxPEQW6F7iAG3Vm1VHZntU8xGHPruOwa/hNoZljcUiU=; b=YZFeaw/aOXFI6/Po ZJB4LKmVfB3UXxucNHCzwUlUdadVODlnA9gmYzlSIZW704lKc2MnQiqi0zXxJYuG a4XkTarBFqPpxYdLoU+wQeeU1djgLp6UIowZvSpew8iOK48O3sITbgmaYAwhiRDx U8c1cD8DGrfTT3YzzZGFdj5b+9cib4NdqmGlJwmFMEFor7nj+oH27KvBujkZUWsb 0EETFvLwS1QBdhN3c9ksibXR7YhqqPDrj4AZuyUc9QqN0kGe1oHrzhUVhhv2wa99 erYtxRAw6ZS4DSik9FxCHtkWIQjm/VWr6AOhG73EajrRQ8/xZdLjzFHHrHbzO/2/ Zm9pNQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epf0ss45t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 12:38:13 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-517796be724so10971351cf.3 for ; Tue, 09 Jun 2026 05:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781008693; x=1781613493; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SxPEQW6F7iAG3Vm1VHZntU8xGHPruOwa/hNoZljcUiU=; b=ah/X19r5Zx+R+LlxG432xjlsZzmzixUphOXANjTrqj5/WWYAdmoEZndN2Yp1exl0ye b+LTj2itUXvnZFihkEshIbg5pqB0+rjduyIFdza0D273lEv0iqAqXAfx6x8XvHzeHd7v o3mYq/CCz5tUF9RkGIZe1NC8X4HVU1jSGZcNlcWgnN4EQGvWwRgMnkatNmFWT3ilNJbW Pigu8bn9k2hjpTo7EIEnRoIBs8NC8VK92UUfFetlputsa+UjU+pxfHNhnTxggy4ucO00 cjQkIdiMnd0qbhTKihGm1hA32sVwIWZe+luT+jSjN2ZJlCoCgkw1Ezee1yxgisBStzQT 3s5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781008693; x=1781613493; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SxPEQW6F7iAG3Vm1VHZntU8xGHPruOwa/hNoZljcUiU=; b=SRmbf1sHa+CI1xlSA9Ed8iTinWgQFhdA4UFu9XT10w+vVn02y9CcR8Uaj0uixnIP/6 2nGYD0vMfx4GZuB99lf5Aj9v/Enl6gllw++XmdGz8AFEC/Jzz14whm8LoYxc65Cvvmr/ 1fP1inKw35ztadQEw30jP5RXjcVQJbF1Tbo1Rt35XyQIOJLLpqe3hSH0KIffaQUSO3Jc v+3Gb5t3nvwL7txkuoN2/G1w/8rucmSM8S5eR2kaf/LsaTAMMMMtIsJe0M6+n01l/hv9 yf1j/Jjmb+2sJ8P1ToXRlVicZ/Pd1wF+5XfFyp35ZWrjHNbZwYqnFvxkxOcpNnGmtX7t 75ow== X-Forwarded-Encrypted: i=1; AFNElJ+VkOVrAzCTOyJZzdMerAGxE+TyrH5vlkRR8y2LzFlwDTEgXM5gIXkUyYRhlXXvUQqB60FQyGsZAt+AmYA=@vger.kernel.org X-Gm-Message-State: AOJu0YzK9zg7lB7cXtwhR3IBHSa+jYd01IWixFh7r00Y84UcqQJ2P7dZ 6HQ4qqkAThqfLemNaqa0E7F+M0rUvDQn7XydsMScRYXA6tB10h8P0tYj5mZXv6ZiI83L2qdurT7 dXXPa8du5P+LnJvFqzTfmS1cc2Phd2wuhNOD77DrZD0ipkifF9iq2tOYlxVfiDzyapp4= X-Gm-Gg: Acq92OH9Z6CBpSarp/Mwv55jGy/SuGy6PgjUH+BupksmY1DlfXV0A9KN2pPzZzhG/YH YAsx78LQ8N5HZS8gJvguuD5yXS7xxuthVuUnMRBf0AfsLL23YvL98OhyFmDTIvqTd9TD+AMcMGV BFuesUoZq4OVd2dp/hVwJHA/w2OX1eHqCDuoa55kLXAINThsCECYceixKdYIH2kQuvHI7sUeEBa vz5Px5/xunjBJh0rFI/D3T9OLnrvt8KdUX1UJ+mMgZafbkqV0Uey/7D8RZ0oBsKOG2jDi8VoqTb MRbDN+3ZyirLYqEIAtEx4W1VUJjHUjymWBqS6sSNhg4o3LiZhoHS3mova1g/A2jl8dXW+QIjCMv Cn0pCmecChKezUUJOHsZrltiUBOBevYWfevaNNY5e2dKL04D6tcdGFHld X-Received: by 2002:a05:622a:93:b0:50e:5e6a:c7d5 with SMTP id d75a77b69052e-51795aa8074mr167158931cf.1.1781008692667; Tue, 09 Jun 2026 05:38:12 -0700 (PDT) X-Received: by 2002:a05:622a:93:b0:50e:5e6a:c7d5 with SMTP id d75a77b69052e-51795aa8074mr167158511cf.1.1781008692089; Tue, 09 Jun 2026 05:38:12 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf051c85e76sm1053734866b.15.2026.06.09.05.38.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 05:38:11 -0700 (PDT) Message-ID: <034a70bb-43f7-4b94-8a85-dce466081473@oss.qualcomm.com> Date: Tue, 9 Jun 2026 14:38:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/7] clk: qcom: Add generic clkref_en support To: Qiang Yu , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krishna.chundru@oss.qualcomm.com References: <20260527-tcsr_qref_0527-v4-0-ded83866c9d9@oss.qualcomm.com> <20260527-tcsr_qref_0527-v4-2-ded83866c9d9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260527-tcsr_qref_0527-v4-2-ded83866c9d9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDEyMCBTYWx0ZWRfX2caKHyDjFbuv dB4VbbxPjJQhwirw98Pa9K1IC6hGRTTnnOSo0n0NM5Yk7/GjgQWNrTrQmxhlxqOpldNIBOwk1gx IHYwM9SDvZdY9GV/AMoIjyttj8GSqD8XJUXGkT3KQ5xSZf03WTF4Pk8CcaZ5Mmwu/i2rQ1o5GCN nZt/BIC/eKw8K3FSQwqaW+RXOOFAkhn+GUxgcpGOqxk0UvMxZa+KfYwrVqITLN9TyROhTIAQ+AT JX7P2xARHuWjdzjBq55bnts9Ak3EF0lzTd+GRDwdd7e43wfoBPqRlXMiXJnFtpNSwD9IMYntYaW 1QnoE3eNt++uAR8uQzfuYjiBNaJmXQETbYEUtRL6ov88aWm/NH0VlSU3ntLyPxd5ekkAxL63CEa Go2c3Wz9hBwfTIwRZGKx9OcGLjB0VBOWdIgba05l27rhW9emJbeagoWCmw8S/YcvyDXVEVWN3R/ ITIUbpxPCXFzayg/mKA== X-Proofpoint-ORIG-GUID: WPlHkO9BOmpqzIaBsDswvf7VkAPezgUk X-Proofpoint-GUID: WPlHkO9BOmpqzIaBsDswvf7VkAPezgUk X-Authority-Analysis: v=2.4 cv=GeonWwXL c=1 sm=1 tr=0 ts=6a280935 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=4hBvweVN3K0BpMZFuekA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090120 On 5/28/26 4:29 AM, Qiang Yu wrote: > Before XO refclk is distributed to PCIe/USB/eDP PHYs, it passes through > a QREF block. QREF is powered by dedicated LDO rails, and the clkref_en > register controls whether refclk is gated through to the PHY side. > > These clkref controls are different from typical GCC branch clocks: > - only a single enable bit is present, without branch-style config bits > - regulators must be voted before enable and unvoted after disable > > Model this as a dedicated clk_ref clock type with custom clk_ops instead > of reusing struct clk_branch semantics. > > Also provide a common registration/probe API so the same clkref model > can be reused regardless of where clkref_en registers are placed, e.g. > TCSR on glymur and TLMM on SM8750. > > Signed-off-by: Qiang Yu > --- [...] > +struct qcom_clk_ref { > + struct clk_hw hw; > + struct clk_init_data init_data; We don't need init_data for each one of these, we can construct it in probe scope: struct clk_init_data init_data = { }; init_data.name = clk_ref->desc.name; init_data.parent_data = &qcom_clk_ref_parent_data; init_data.num_parents = 1; init_data.ops = &qcom_clk_ref_ops; clk_ref->hw.init = &init_data; ret = devm_clk_hw_register(dev, hw); // not needed past that point, __clk_register zeroes hw->init internally Konrad