From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751283AbdAQJcs (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Jan 2017 04:32:48 -0500
Received: from out4439.biz.mail.alibaba.com ([47.88.44.39]:16940 "EHLO
        out4439.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1750957AbdAQJcd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Jan 2017 04:32:33 -0500
X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03307;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---.7SxvGzW_1484645432;
Reply-To: "Hillf Danton" <hillf.zj@alibaba-inc.com>
From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Michal Hocko'" <mhocko@kernel.org>,
        "'Andrew Morton'" <akpm@linux-foundation.org>
Cc: "'Johannes Weiner'" <hannes@cmpxchg.org>,
        "'Mel Gorman'" <mgorman@suse.de>, "'Vlastimil Babka'" <vbabka@suse.cz>,
        "'David Rientjes'" <rientjes@google.com>, <linux-mm@kvack.org>,
        "'LKML'" <linux-kernel@vger.kernel.org>,
        "'Michal Hocko'" <mhocko@suse.com>
References: <20170117091543.25850-1-mhocko@kernel.org> <20170117091543.25850-2-mhocko@kernel.org>
In-Reply-To: <20170117091543.25850-2-mhocko@kernel.org>
Subject: Re: [PATCH 1/4] mm, page_alloc: do not report all nodes in show_mem
Date: Tue, 17 Jan 2017 17:30:32 +0800
Message-ID: <034b01d270a4$5a0aa440$0e1fecc0$@alibaba-inc.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQMZc92x2uhxZfNj6Op/FtjOamLIhgIq6EuInp0IusA=
Content-Language: zh-cn
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Tuesday, January 17, 2017 5:16 PM Michal Hocko wrote: 
> 
> From: Michal Hocko <mhocko@suse.com>
> 
> 599d0c954f91 ("mm, vmscan: move LRU lists to node") has added per numa
> node statistics to show_mem but it forgot to add skip_free_areas_node
> to fileter out nodes which are outside of the allocating task numa
> policy. Add this check to not pollute the output with the pointless
> information.
> 
> Acked-by: Mel Gorman <mgorman@suse.de>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
> ---
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>

>  mm/page_alloc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 8ff25883c172..8f4f306d804c 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -4345,6 +4345,9 @@ void show_free_areas(unsigned int filter)
>  		global_page_state(NR_FREE_CMA_PAGES));
> 
>  	for_each_online_pgdat(pgdat) {
> +		if (skip_free_areas_node(filter, pgdat->node_id))
> +			continue;
> +
>  		printk("Node %d"
>  			" active_anon:%lukB"
>  			" inactive_anon:%lukB"
> --
> 2.11.0