From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5378C0015E for ; Wed, 26 Jul 2023 17:03:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230258AbjGZRD1 (ORCPT ); Wed, 26 Jul 2023 13:03:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229528AbjGZRDY (ORCPT ); Wed, 26 Jul 2023 13:03:24 -0400 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87B8810EC for ; Wed, 26 Jul 2023 10:03:18 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id EC3DA5C019E; Wed, 26 Jul 2023 13:03:17 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Wed, 26 Jul 2023 13:03:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690390997; x=1690477397; bh=pffJfAxWXhzPqO9RJUcLmLEFkSH/WJE9Vpj UyBhgoSs=; b=SALvpCzKcgZXLm3OywUOCz20SERT2uXtdYzioLk0cGE2gO6ePRe kuub08yT/wrbxvx9FglxWwvGMeZflBvA+2MCI+4MAP1yISd26rk6WLfHGh2VI6lp CW1VR4AjflWfr7AI2D8OCYaC460eIRKyo1FOJZdXjOHJQowFFFXdeYtFr3kjPKOq wTTgkObJksTY/wsKjQMZ/FGhv4StS9lFFgcAzVbaUfVn856ZToQfRVYvDhD5Rwyk C4OtkL6xJqkYJ+o9breA99zo5PpdmOot+VCw436ThBHqr7BxDtSafvxqr+Z/vDwv P9hOYbmGJwJqwYRd9fpJGP8JnPn4VSPqBaw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690390997; x=1690477397; bh=pffJfAxWXhzPqO9RJUcLmLEFkSH/WJE9Vpj UyBhgoSs=; b=iGLHxr763+TKShDHHm4Ozn8CKZdGBAcaDh5SIgmPFyGP7d0RL7y j54sttEtCBmcDbBmFUs1GXqiW+EqKj2ovXnHwIZxzpNRqRYK741a0TJ2B4yNRTbX 26dtYvth8M71aqkvq4egnr1AfCMTOnq75pHfuXHERHL8yOpLlKPBHnETAafhJHxK z/1IOv45crukvGosp7VIu/VbmH25acnLCcOZP2LkcpIyo1hwIGAMzWTN1D6gbtpY RS8NVhV4OHY4S7mmofuJmXSBK5R2HLLbvlhbPNdOWNQdKeIewuBY1yBMo6UsVjWO Cx+AXruefBOs1+hlO/0iaVnw3LDv9P9ENJQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedriedvgddutdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeegfeejhedvledvffeijeeijeeivddvhfeliedvleevheejleetgedukedt gfejveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 410B6B6008D; Wed, 26 Jul 2023 13:03:17 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-592-ga9d4a09b4b-fm-defalarms-20230725.001-ga9d4a09b Mime-Version: 1.0 Message-Id: <034f0b5e-3c61-4392-8360-ebd57749d53e@app.fastmail.com> In-Reply-To: References: <20230726143348.724611-1-arnd@kernel.org> Date: Wed, 26 Jul 2023 19:02:55 +0200 From: "Arnd Bergmann" To: "Nick Desaulniers" , "Arnd Bergmann" Cc: "Paul E. McKenney" , "Andrew Morton" , "Kees Cook" , "Peter Zijlstra" , "Sami Tolvanen" , "Alexey Dobriyan" , "Masahiro Yamada" , "Josh Poimboeuf" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] init: keep boot_command_line after init Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 26, 2023, at 18:25, Nick Desaulniers wrote: > On Wed, Jul 26, 2023 at 7:33=E2=80=AFAM Arnd Bergmann wrote: >> >> From: Arnd Bergmann >> >> The boot command line is not available after the init section gets di= scarded, >> so adding a permanent reference to it causes a link time warning: >> >> WARNING: modpost: vmlinux: section mismatch in reference: cmdline_loa= d_proc_show+0x2 (section: .text) -> boot_command_line (section: .init.da= ta) > > cmdline_load_proc_show is probably inlined, but should it also be > marked __init? It's lone call site seems to be __init AFAICT. > No, that's not what it does: cmdline_load_proc_show() is called when someone reads /proc/cmdline_load from userspace. It's only the function that creates this procfs file that is __init, but the call happens later. Arnd