From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FAF81A2621 for ; Mon, 2 Sep 2024 14:33:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725287634; cv=none; b=EEswWimb/bBEVDpwd+JYNNij595/ppdEZbvd8DLCw5OAoi5sb1/I89km3osNupzc93XuAPfSrmZlfKfWuiDiL1I4Yae6GePbX7mjJbGV8DacIVCiN5AkSEmQ9AJ8+I5pNqdO7RFWxMW2Mu/OmwN+l2X3ge6zDUxfVuz0pizWa2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725287634; c=relaxed/simple; bh=JzVTjocKl+bphpBD5G+fM/hg9Tbx+P9WcKzGCilaHJI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JJbnB/PO7F/gWetxtDq0lOzxtPkwv6VBlN5DFYQnIgbbv0nTrpNvKzT05tjpvIN9veyGyvqcrvwKOx1XdqxM+AWBikopOKs8xyT8UfqQUDmGFU2rhItBjnIV4Zps7Jkx9/iMHXYN4Gwf6eHAZkd+MPxyGZAjsNuDjN4Udjl2lBA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XpGodFBX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XpGodFBX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725287631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0evm9WjGUWx+lWTgpOOfHNevcitwA8CTvoebEtMLMGs=; b=XpGodFBXdHm+vCDdQNSoVfXNWjuHUlJ55lotT24PqxZybdzK72qZneMG4jh4csuOsJWj7Q 9+RcBwNX7D180ylr04rVo8EijrmAGIJAnDUBD+VgqtiHEjaEXmqnBMG5la5UVX4AbdI23l nKtv2BKCIcia5rVLDXypE1zA7L32Nrg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-298-8_DqHls7NDyIebOlxbhzaQ-1; Mon, 02 Sep 2024 10:33:50 -0400 X-MC-Unique: 8_DqHls7NDyIebOlxbhzaQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42bb5950d1aso49016605e9.2 for ; Mon, 02 Sep 2024 07:33:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725287629; x=1725892429; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0evm9WjGUWx+lWTgpOOfHNevcitwA8CTvoebEtMLMGs=; b=s4/Z3AMBui1YBoc17pgG118OhUXzNIkvoWoR5ZqkIW7bnUjOofj0SxJVhcp3bgp1ix Tnk+0TVi8w+xk1RhP41L5hwGJ8/Xv2XysI9z2tddd8tKzAJyQwcv2WwBbgZmCdnKSVy5 MZHMEay5jEn/ANSOpnV6KIg4LLVwW9/cz/tRspml36Sohd4FzV/Vp97wSuZLPXl1ZTFL kMuwu5twAbls0d7eyT7t72FsFFvnzeS0yxBwg09LsIXU0G5iRmHMIzCHv+id0KwvMTSQ ZtlD0jcGjZRVaALX7gKADEyOAOfxdYdVlffiWRz4dgtW9jPNfn5lRHxdePuceW5EmUSU I4RQ== X-Forwarded-Encrypted: i=1; AJvYcCWwBcmXPc600v0EEik8Nqt0vLZJAZjlwARKkKT4YAWxc+TK0fOlMBs18hsEKSLNaM3NVbH6fjJcZ80QNVg=@vger.kernel.org X-Gm-Message-State: AOJu0Yya7lnKirkQX6vt4thFpDDf+b/j3U9/ok3yuCAB5GQkc0s7n1ea i9PZyjRUgwr4FQTITKQswTTNw53SKZtYR9mXJ8so/vSLUyA9SX9jTuY/IbRMoRgNQUIW/xpQ1ni dJKofmNK9LZo6wCTeSHzJsFoAL5muzlfMCXNo7uKwuZHhcH657qVXLC5n9b3Sbg== X-Received: by 2002:a05:600c:a01:b0:426:6857:3156 with SMTP id 5b1f17b1804b1-42bb01edd50mr137287085e9.27.1725287628966; Mon, 02 Sep 2024 07:33:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHe/tNIvb95kY1M8aGe3wpJipnsqvbxOHPj9EZllErvmdyF0JicK3fveS4Lt8NG1DRsNPPcjA== X-Received: by 2002:a05:600c:a01:b0:426:6857:3156 with SMTP id 5b1f17b1804b1-42bb01edd50mr137286635e9.27.1725287628133; Mon, 02 Sep 2024 07:33:48 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6df795asm139696075e9.21.2024.09.02.07.33.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Sep 2024 07:33:47 -0700 (PDT) Message-ID: <034f3269-7290-4599-8f12-72b63bf75195@redhat.com> Date: Mon, 2 Sep 2024 16:33:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v2 PATCH 1/2] hugetlb: arm64: add mte support To: Yang Shi , catalin.marinas@arm.com, will@kernel.org, muchun.song@linux.dev, akpm@linux-foundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240821184752.3535276-1-yang@os.amperecomputing.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240821184752.3535276-1-yang@os.amperecomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21.08.24 20:47, Yang Shi wrote: > Enable MTE support for hugetlb. > > The MTE page flags will be set on the head page only. When copying > hugetlb folio, the tags for all tail pages will be copied when copying > head page. > > When freeing hugetlb folio, the MTE flags will be cleared. > > Signed-off-by: Yang Shi > --- > arch/arm64/include/asm/hugetlb.h | 11 ++++++++++- > arch/arm64/include/asm/mman.h | 3 ++- > arch/arm64/kernel/hibernate.c | 7 +++++++ > arch/arm64/kernel/mte.c | 25 +++++++++++++++++++++++-- > arch/arm64/kvm/guest.c | 16 +++++++++++++--- > arch/arm64/kvm/mmu.c | 11 +++++++++++ > arch/arm64/mm/copypage.c | 25 +++++++++++++++++++++++-- > fs/hugetlbfs/inode.c | 2 +- > 8 files changed, 90 insertions(+), 10 deletions(-) > > v2: * Reimplemented the patch to fix the comments from Catalin. > * Added test cases (patch #2) per Catalin. > > diff --git a/arch/arm64/include/asm/hugetlb.h b/arch/arm64/include/asm/hugetlb.h > index 293f880865e8..00a1f75d40ee 100644 > --- a/arch/arm64/include/asm/hugetlb.h > +++ b/arch/arm64/include/asm/hugetlb.h > @@ -11,6 +11,7 @@ > #define __ASM_HUGETLB_H > > #include > +#include > #include > > #ifdef CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION > @@ -20,7 +21,15 @@ extern bool arch_hugetlb_migration_supported(struct hstate *h); > > static inline void arch_clear_hugetlb_flags(struct folio *folio) > { > - clear_bit(PG_dcache_clean, &folio->flags); > + const unsigned long clear_flags = BIT(PG_dcache_clean) | > + BIT(PG_mte_tagged) | BIT(PG_mte_lock); > + > + if (!system_supports_mte()) { > + clear_bit(PG_dcache_clean, &folio->flags); > + return; > + } > + > + folio->flags &= ~clear_flags; > } > #define arch_clear_hugetlb_flags arch_clear_hugetlb_flags > > diff --git a/arch/arm64/include/asm/mman.h b/arch/arm64/include/asm/mman.h > index 5966ee4a6154..304dfc499e68 100644 > --- a/arch/arm64/include/asm/mman.h > +++ b/arch/arm64/include/asm/mman.h > @@ -28,7 +28,8 @@ static inline unsigned long arch_calc_vm_flag_bits(unsigned long flags) > * backed by tags-capable memory. The vm_flags may be overridden by a > * filesystem supporting MTE (RAM-based). > */ > - if (system_supports_mte() && (flags & MAP_ANONYMOUS)) > + if (system_supports_mte() && > + (flags & (MAP_ANONYMOUS | MAP_HUGETLB))) > return VM_MTE_ALLOWED; > > return 0; > diff --git a/arch/arm64/kernel/hibernate.c b/arch/arm64/kernel/hibernate.c > index 02870beb271e..722e76f29141 100644 > --- a/arch/arm64/kernel/hibernate.c > +++ b/arch/arm64/kernel/hibernate.c > @@ -266,10 +266,17 @@ static int swsusp_mte_save_tags(void) > max_zone_pfn = zone_end_pfn(zone); > for (pfn = zone->zone_start_pfn; pfn < max_zone_pfn; pfn++) { > struct page *page = pfn_to_online_page(pfn); > + struct folio *folio; > > if (!page) > continue; > > + folio = page_folio(page); > + > + if (folio_test_hugetlb(folio) && > + !page_mte_tagged(&folio->page)) > + continue; Can we have folio_test_mte_tagged() whereby you make sure that only folio_test_hugetlb() uses it for now (VM_WARN_ON_ONCE) and then make sure that nobody uses page_mte_tagged() on hugetlb folios (VM_WARN_ON_ONCE)? Same for folio_set_mte_tagged() and other functions. We could slap a "hugetlb" into the function names, but maybe in the future we'll be able to use a single flag per folio (I know, it's complicated ...). -- Cheers, David / dhildenb