From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 819A7C433B4 for ; Thu, 6 May 2021 13:34:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D23B613C2 for ; Thu, 6 May 2021 13:34:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234110AbhEFNf2 (ORCPT ); Thu, 6 May 2021 09:35:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48680 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233461AbhEFNfY (ORCPT ); Thu, 6 May 2021 09:35:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620308066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tPc+W/XTdGwFLPXo+j4WvorK8DhXEDBZU8KGl987Scc=; b=HezdePtU9eE67/UkbfzxJu2kNIQQqziDD+bQdhqhClifYNc7QlKIJ9/7hS3JBc80NbH+J2 wHYndC/RC40Vfb7CHP0gKtVuoIhuZW/zsvu6gmYcim4MVJvFOsvAZwrmSiYte+OIyUtz2e UVYEOFpg+RhzIH2ehGu/xkP0wI+E6zo= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-284-KAYT67QLPuCzoxgF73n4rg-1; Thu, 06 May 2021 09:34:22 -0400 X-MC-Unique: KAYT67QLPuCzoxgF73n4rg-1 Received: by mail-ej1-f69.google.com with SMTP id r14-20020a1709062cceb0290373a80b4002so1694100ejr.20 for ; Thu, 06 May 2021 06:34:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tPc+W/XTdGwFLPXo+j4WvorK8DhXEDBZU8KGl987Scc=; b=Z5RNe9ZajgxneTN22hM5LBAwpUs3XLSO+gqAWysckQTsw/WSEgeFHKu+2TY6MbNT55 /mg4ghJCh5ysiNXhNGf/fjQQ+UE7il8weyYJtGmw5u16MTaZCOG3UfGA4bm5Kh3QiD13 ND1318NpqMYp1ozMvAvK+qsJKGePznS5T2+iqZDpfxmtqYroPmn/XdWOsIECf1DfF015 tb/B39s+j/ynev4TRF6huI81EHFvxaGvbqCYnR9RrVMG/Ue2NaE7k0LCLvySi44vLvsV pc/gu5PXFw+Y0LKhjj67RJeUa4P0MUQbKSU2aaLWRUag8zMMCaG8hExRkXxsTNs6hCgg gM2Q== X-Gm-Message-State: AOAM53086A/2yjkd7ra0YWDy3rcbEtmKtWJwlgydn//e9lJcYnzIY2Ax 1hmibXkLXdESZWDtKndIfr3Ha2V1FaXFgHSTCvJ5DSrAuGDqyE1ivFuNRTH5HxjYAKJRBuAigiY uAZ1TqZNV1xYvaIBfD1ED4/CH X-Received: by 2002:a17:906:4553:: with SMTP id s19mr4437562ejq.117.1620308061620; Thu, 06 May 2021 06:34:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjcUafqwF3p+FEiROr7dUWC9UVn6oG30p4J15nqDKeTSU6ntNMN3NwQeZBpZpi0zPBWgAZEg== X-Received: by 2002:a17:906:4553:: with SMTP id s19mr4437548ejq.117.1620308061481; Thu, 06 May 2021 06:34:21 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id v14sm1718061edx.5.2021.05.06.06.34.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 May 2021 06:34:20 -0700 (PDT) Subject: Re: [PATCH] iio: bme680_spi: Remove ACPI support To: Guenter Roeck , Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko References: <20210506133145.2266604-1-linux@roeck-us.net> From: Hans de Goede Message-ID: <034f8cbf-775c-6ee6-1c41-0a951368e998@redhat.com> Date: Thu, 6 May 2021 15:34:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210506133145.2266604-1-linux@roeck-us.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 5/6/21 3:31 PM, Guenter Roeck wrote: > BME0680 is not an official ACPI ID, so let's remove it before someone > starts using it. > > Cc: Andy Shevchenko > Cc: Hans de Goede > Signed-off-by: Guenter Roeck Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/iio/chemical/bme680_spi.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/iio/chemical/bme680_spi.c b/drivers/iio/chemical/bme680_spi.c > index 6f56ad48cc40..cc579a7ac5ce 100644 > --- a/drivers/iio/chemical/bme680_spi.c > +++ b/drivers/iio/chemical/bme680_spi.c > @@ -4,7 +4,6 @@ > * > * Copyright (C) 2018 Himanshu Jha > */ > -#include > #include > #include > #include > @@ -145,12 +144,6 @@ static const struct spi_device_id bme680_spi_id[] = { > }; > MODULE_DEVICE_TABLE(spi, bme680_spi_id); > > -static const struct acpi_device_id bme680_acpi_match[] = { > - {"BME0680", 0}, > - {}, > -}; > -MODULE_DEVICE_TABLE(acpi, bme680_acpi_match); > - > static const struct of_device_id bme680_of_spi_match[] = { > { .compatible = "bosch,bme680", }, > {}, > @@ -160,7 +153,6 @@ MODULE_DEVICE_TABLE(of, bme680_of_spi_match); > static struct spi_driver bme680_spi_driver = { > .driver = { > .name = "bme680_spi", > - .acpi_match_table = ACPI_PTR(bme680_acpi_match), > .of_match_table = bme680_of_spi_match, > }, > .probe = bme680_spi_probe, >