From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B84AC04AB3 for ; Wed, 29 May 2019 08:30:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2056420665 for ; Wed, 29 May 2019 08:30:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726428AbfE2IaP (ORCPT ); Wed, 29 May 2019 04:30:15 -0400 Received: from relay.sw.ru ([185.231.240.75]:42042 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725911AbfE2IaP (ORCPT ); Wed, 29 May 2019 04:30:15 -0400 Received: from [172.16.25.169] by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1hVtyM-0001yM-CE; Wed, 29 May 2019 11:30:10 +0300 Subject: Re: [PATCH] mm: Fix recent_rotated history To: akpm@linux-foundation.org, daniel.m.jordan@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <155905972210.26456.11178359431724024112.stgit@localhost.localdomain> From: Kirill Tkhai Message-ID: <0354e97d-ecc5-f150-7b36-410984c666db@virtuozzo.com> Date: Wed, 29 May 2019 11:30:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <155905972210.26456.11178359431724024112.stgit@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Missed Johannes :( CC On 28.05.2019 19:09, Kirill Tkhai wrote: > Johannes pointed that after commit 886cf1901db9 > we lost all zone_reclaim_stat::recent_rotated > history. This commit fixes that. > > Fixes: 886cf1901db9 "mm: move recent_rotated pages calculation to shrink_inactive_list()" > Reported-by: Johannes Weiner > Signed-off-by: Kirill Tkhai > --- > mm/vmscan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index d9c3e873eca6..1d49329a4d7d 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1953,8 +1953,8 @@ shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec, > if (global_reclaim(sc)) > __count_vm_events(item, nr_reclaimed); > __count_memcg_events(lruvec_memcg(lruvec), item, nr_reclaimed); > - reclaim_stat->recent_rotated[0] = stat.nr_activate[0]; > - reclaim_stat->recent_rotated[1] = stat.nr_activate[1]; > + reclaim_stat->recent_rotated[0] += stat.nr_activate[0]; > + reclaim_stat->recent_rotated[1] += stat.nr_activate[1]; > > move_pages_to_lru(lruvec, &page_list); > >