From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FA76405844 for ; Mon, 29 Jun 2026 13:00:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782738059; cv=none; b=qvKz2fIHWBcdrGh9plmq2CZU5owqQ42Bp5pdnJ5rZ4oLfJlpBR+DsEn/4N1sKUl72VHOHhVh37dbIlwqaEzHVraIc6U7yVmH0iLtHhu20IORtQqfRD+DppE9OGGEDtUhTv0JQpnG0ppOZnDSVL33+jtrxdT4qOjSP/SQEyar7mg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782738059; c=relaxed/simple; bh=ptC+qOiC6+d1qdGlhlfC4UXNJ/q88wxddxLLdklLOWY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IDqgPwGaykBc3CUUFqBu7hoN0SLbznYmKKp/QQm6dhs1cJmdYOF+wpd0uMOxo+5QLV7mPAejOgdqVOJDFInhSlvjbI0sfHDEyMru7aNA3UfvAv1vvvH+RHoDphzeI6reryO9/8paVUPrymh6cBPQ6T4Xa7RYLVahGxBe4MHtvXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=N8HusOvo; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N8HusOvo" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5aea63b44eeso277349e87.2 for ; Mon, 29 Jun 2026 06:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1782738056; x=1783342856; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=m3Fai9RBjd+npFV53TQmqA1uln8pKm/M0yqFuuvwOko=; b=N8HusOvoin7uG2/EDkYzV7wQ+Q8alB4l6/xWidNN9lmCSqMyeVPtT2KMppQ3liD/xw cmMKfosyZdTbIilJsJ4jmfe7BlOWMIZ/LnhzzUljhb6x7QiCxuUDJVSulqOo+m0Chj8U ONcmysFd3E77TDyqEFOgvywFRMMmHl1/l2aaeRr0iZ0Mm614nJk8+SDcBr8+u7jc2Tkk O+53pKL856zhCZvDo5RqVKV5yZYgS0fs0a5OPb1XH7XUae2j4IeujsFCBfdpnCGVbZNK WoTJzeaL68jasp4fwny9j9YndVvS8iPKQmBbkUlaHPG2zlucVDrmye6OwWOeQ7wRczNH 6RDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782738056; x=1783342856; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=m3Fai9RBjd+npFV53TQmqA1uln8pKm/M0yqFuuvwOko=; b=KXDYn/5QYtZr6kuOiE/A/188CM5sDoitlqVd1s7TvoXpNb0Afi7o6Be9/bccEIloN5 bg475XBwa/gto9qGIitVdbRqdEgZKWaaAsCBb6iuJ7Pqgp4E81Ni7EVv9xDBNVDfoUQG pftB2jAApsS4vaISm79iIPbmjgFcJh2yHdZJzxUpibKUWi1Ds9S7zIJs1M87UXMOexGf X+5hM1KEbQSNvurLFF3NPvEECLmT4h4mYoiUDNxbaJpB+0N12VpcvBRyFmBwvdlbu+if mhfLg/kYLKvPCnQ4ot+7tsdMgQRO69G/injL3BzEFQ9YIxzZa8ESiVCoG2BseW3W+YrW XMtg== X-Forwarded-Encrypted: i=1; AHgh+RruU/Zbm1CS8dFJ+ahwMke/KbpimEcuqt8t5M4O3XEcecQaMgwI/HFwMaPteC3/vyVO2SQKrX36y7VrcMQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyYlQh53ZJPJZ2kOjBxxJoEQ1kPAMUOyBlhxifL4YdGvz5LwknQ qboN11jkxUMNotVDalu/2zE/zCPwAgnP6XHZpBybNSaSd8DHPD+/nntk98GMNydJm7o= X-Gm-Gg: AfdE7clDV+nlxnZLYB6K565kcHEQMpZcBkdcmdP9qsiuLqqeV9xq6Jx/9CDvUzSuG2e Iy33h/t93rDPtUZP67CeEaCd1DynQq/DRLG87WHhgy3O/cMm7Ceoj1Kr3eYi2YUnMPD0EntSzX6 1Ap7eA+LXYjdz5JHirWqdxCY51Ku7QUdr4SeIkHcXrO0QN7kWF16IzYMA75InsKFS0E8hdESgAt NAeV2drZ+QD384sl/10bqNSgofiuak/8DHuTg4aLbTjHt++iYjKWUUZmOYPAxBvNnTj55fqa8o5 mmUGECtGGbdwOj6ghvoooWc82KSbuaP3j1QqXM3fSthgGQMBoeTg5sk8HDOtqymwkp5AF+73okj x76qwwgL/rD5gRSVSILbzmHn9HhAhx6oUtcgT5kj5cBTw2b+s8adKQgMoBvsLkKuL248102YRol gD8G6hq+8JG3EaCAeYJzonxnrVILA0SXWCuuFRMVebDnn1phc1bO+3ed2F6Z76K/3L0Gw= X-Received: by 2002:a05:6512:3b11:b0:5ae:ba7d:8fad with SMTP id 2adb3069b0e04-5aeba7d9145mr373785e87.4.1782738055280; Mon, 29 Jun 2026 06:00:55 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aebd32dbf3sm45796e87.46.2026.06.29.06.00.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 06:00:54 -0700 (PDT) Message-ID: <03596c5b-9448-49e3-a035-25c0475df9be@linaro.org> Date: Mon, 29 Jun 2026 16:00:46 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: enable ALWAYS_ON for titan_top_gdsc To: Brian Masney Cc: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260626-camcc-sc8280xp-titan-top-v1-1-2ca246886493@redhat.com> <41a76941-2e21-49ce-b0cd-0ae6a8b2eb1f@linaro.org> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Brian, On 6/29/26 14:03, Brian Masney wrote: > Hi Vladimir, > > On Fri, Jun 26, 2026 at 07:54:39PM +0300, Vladimir Zapolskiy wrote: >> On 6/26/26 19:32, Konrad Dybcio wrote: >>> On 6/26/26 6:26 PM, Brian Masney wrote: >>>> With the introduction of sync_state support in the clk and pmdomain >>>> subsystems, the following warning happens when the unused clocks are >>>> shutdown in camcc-sc8280xp: >>> >>> Stuck at _on_ sounds wrong.. does clk_ignore_unused / removing >>> the sync state from the clock part only resolve this? There may >>> be a clock dependency for the TITAN_TOP_GDSC that we're failing to >>> describe >>> >> >> Let me remind that there is a series, which solves this problem in a proper >> and elegant way, it would be nice to get the review tags though: >> >> [1] https://lore.kernel.org/linux-clk/20260331140142.892579-1-vladimir.zapolskiy@linaro.org > > As I mentioned in my other message, this series didn't address my issue. > sc8280xp wasn't included in your series, so I had to make the following > change in my tree: absolutely, sc8280xp CAMCC should be also fixed in that respect. > > diff --git a/drivers/clk/qcom/camcc-sc8280xp.c b/drivers/clk/qcom/camcc-sc8280xp.c > index 18f5a3eb313e1..4724ea54c5f67 100644 > --- a/drivers/clk/qcom/camcc-sc8280xp.c > +++ b/drivers/clk/qcom/camcc-sc8280xp.c > @@ -2995,6 +2995,7 @@ static const struct qcom_cc_desc camcc_sc8280xp_desc = { > .num_resets = ARRAY_SIZE(camcc_sc8280xp_resets), > .gdscs = camcc_sc8280xp_gdscs, > .num_gdscs = ARRAY_SIZE(camcc_sc8280xp_gdscs), > + .cc_gdsc = &titan_top_gdsc, > }; > > static const struct of_device_id camcc_sc8280xp_match_table[] = { > commenting the series I was also directed by Konrad's review comment on it. In addition one problem, which I immediate observe, is that camcc_sc8280xp_desc misses the necessary .use_rpm flag, can you please do me a favour and test my series plus the add-on change below? diff --git a/drivers/clk/qcom/camcc-sc8280xp.c b/drivers/clk/qcom/camcc-sc8280xp.c index 18f5a3eb313e..a15e9754bfb2 100644 --- a/drivers/clk/qcom/camcc-sc8280xp.c +++ b/drivers/clk/qcom/camcc-sc8280xp.c @@ -2995,6 +2995,8 @@ static const struct qcom_cc_desc camcc_sc8280xp_desc = { .num_resets = ARRAY_SIZE(camcc_sc8280xp_resets), .gdscs = camcc_sc8280xp_gdscs, .num_gdscs = ARRAY_SIZE(camcc_sc8280xp_gdscs), + .use_rpm = true, + .cc_gdsc = &titan_top_gdsc, }; static const struct of_device_id camcc_sc8280xp_match_table[] = { Anyway despite my posted series and the above change for sc8280xp resolve one well-established problem in the CAMCC drivers, I believe there might be more unresolved issues on top, which should be addressed separately. -- Best wishes, Vladimir