From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13AB9C433FF for ; Fri, 2 Aug 2019 14:32:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D49A621726 for ; Fri, 2 Aug 2019 14:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564756351; bh=7IdaB/Ghuyv4Cj8yhU/Am5uia2oxMEzSJaJfa45BtFk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=T/dN75vTkjNH7sacIsmnQvyIknEZLGEkPeqka9vnygqX+91wnnBVxoOATJ8TygJH5 Vf5mwyk9hEDffhKkrQ2Czb/ho2ih/HchtEaKiYTkLG6Am063qB/8gPNj4s9zzSDl0x +XkBvQifOLjRZ7h4N95wDccvmdqL+puljxwXYx8M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394949AbfHBOca (ORCPT ); Fri, 2 Aug 2019 10:32:30 -0400 Received: from foss.arm.com ([217.140.110.172]:52840 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389189AbfHBOca (ORCPT ); Fri, 2 Aug 2019 10:32:30 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B82AF1570; Fri, 2 Aug 2019 07:32:29 -0700 (PDT) Received: from [10.1.197.61] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4FE283F575; Fri, 2 Aug 2019 07:32:28 -0700 (PDT) Subject: Re: [PATCH] arm64/kvm: fix -Wimplicit-fallthrough warnings To: Qian Cai Cc: james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, christoffer.dall@linaro.org, drjones@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org References: <1564755788-28485-1-git-send-email-cai@lca.pw> From: Marc Zyngier Organization: Approximate Message-ID: <0361d2e8-e57c-5cac-f0ff-5e56675ba71d@kernel.org> Date: Fri, 2 Aug 2019 15:32:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1564755788-28485-1-git-send-email-cai@lca.pw> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/2019 15:23, Qian Cai wrote: > The commit a892819560c4 ("KVM: arm64: Prepare to handle deferred > save/restore of 32-bit registers") introduced vcpu_write_spsr32() but > seems forgot to add "break" between the switch statements and generates > compilation warnings below. Also, adding a default statement as in > vcpu_read_spsr32(). See https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git/commit/?id=3d584a3c85d6fe2cf878f220d4ad7145e7f89218 The default statement is pretty pointless by construction. Thanks, M. -- Jazz is not dead, it just smells funny...