From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8B991CB51B for ; Tue, 11 Feb 2025 07:56:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739260592; cv=none; b=gWTHO/A5/0BBuLWwxMLlbwkxIgw0DaaJZjUx6wJdZKoUr+CYj4jylvTLxgKl1p4P792P15ZYKCK53X4ZZ2efRpcVuSqvT997Pplen3auLMIlDYBueeoKT+0ZI7tqgdo/GfETiBvVq0q3v3uTBpQXVLPggNYc1kuW6tCF9N+Qs3Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739260592; c=relaxed/simple; bh=UzwistTOiGxOKlMk6jUmAHmPTkXoKbfEXKNs9GNBgVU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KkIIKFRXeNhQzeAcT2N9ZusKILYydStX0I1/pUv6NeST6LduUSPloMZwPNESnqF+miXKwvs89p+0Y8AKDVaoCeRgaSmoGJyWEh7d0Vhu9Rku3pZZkfay7u36J7NPmPuONsnk2om3DwabTgbzRjC5HBh1jwP593G+6BYLNefN590= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=R2NSUzlO; arc=none smtp.client-ip=212.227.15.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="R2NSUzlO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1739260557; x=1739865357; i=markus.elfring@web.de; bh=b8cDJ4lSmHlxSHHsrsR6Ku6y7KJbcpSf5mf6dGPdv9A=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=R2NSUzlOENGGd9tSVqZOlw+RF+S1ervuJIcdhRRkzK0Dd1dX9iIMYaeu6AzTtT2e NSQBJqdyukDNTUwO3xXLCCoDI6IeGRjQ4cFkQDKJSXcObw0MuGD9K4IZWCpFd5peh 13Q8F1oBNRrfyQJE2O8wZRVmVXnOB6FtNK2RhJDK7Z3AC6HYKc1pgPO5Kt8bWNW/R rrEhF4NXWp0NPEqk0rHiXvYt9xfsMMpbYapvZ9wsMH/r17rs73Tg3AF9nEoBA/iPe xYcnAy+nmtG5Iuj3pDd2RJrB/lhBQ2p8Z96drI3F3YLZjOJLVfRuKGX3A5Eo4G5uJ JZDN5C62ZuoCmlmAaA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.29] ([94.31.93.9]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MFrxr-1tbUw639Xr-004dft; Tue, 11 Feb 2025 08:55:57 +0100 Message-ID: <03681acf-9524-4fd1-b40d-a7cafe1c5572@web.de> Date: Tue, 11 Feb 2025 08:55:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v2] drm: xlnx: zynqmp_dpsub: Add NULL checks in zynqmp_audio_init() To: Charles Han , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Cc: LKML , David Airlie , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Michal Simek , Simona Vetter , Thomas Zimmermann , Tomi Valkeinen , Vishal Sagar References: <20250211032830.2400-1-hanchunchao@inspur.com> Content-Language: en-GB From: Markus Elfring In-Reply-To: <20250211032830.2400-1-hanchunchao@inspur.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:USnYnQXWxocGuM37zSToa8h9T0sJugExpCOPAS5wXImCLuqUR6f kLJhstS1kXuTCHVqA3fJIsdplst6DMALOOKqjeFeId2Q7VTrWPzFqE++bKGc5BqxsbyXXIq B1aXysi6VQyK5yFFob6D7zUp2GpHjotI5kYKrDsDYg8HHYcbhfk3KO31letLzoYY7gTVrQ5 cFeUQobbXq0eaMDYDXPig== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:xKVS0rHKMsY=;RT9f9ib+CuKUU0bTTT0xk/moXNt XuBhhKM25BotD4SkvCeaUmZHS5aCNq5p1PkdeiODx3Ivn4/5zxoWqlfIdG3sZy7B91X9u9uOe Pj4hBfDuG0krWTSgrmkkJSo9faHdtSSSYWZRbTbnhz0QmXHty+Aa6uhR1Te1mFYhnA4hsYdyw PHbkjIV5kUElluQjhwismap1f1XTNdx8CPMqLl+OGfjSD3GpeLQ+i1Sw3bfSK/F7qRcYS67ym AnmPrHy+Z4F1I3jkpJrcW3lh2+wLzAO8qDm4Onx/3X0TyiGNB+oougeItKB9qEbh0R7yf/YD7 +PK5PjAHcvRsjtGEOAB355UnxxguF9sXY4WH8mF1Dt4qkLJ8I1UHWDlCXjAp0lmQQL4U+2h15 K2sPhCogeDxM66Dghq4Uyft8qES9SOdTVotzqdXAdsIf+yKg2U8PEiobSzlAEgJQt9L00giJC s9UgJVO+VVrmioKbYMKlUMUwRGhrVuHlWlT5F/WUnSnqDVSemETdIuDI5Czo01CXEpVyzRUCy DEMipsp1zpiextHARBaxkEGmtxgjB61+CEtA/GBGavFGvHmr5xetaU9mApP2TMBcLPSzIU+Zn 1DyzGEzy5cyY4FPB3Q0q69PnFyGIbh1bD0kkc09cDec9pzijTBtMBNJFNxYxITRxei+l9DPKd 3AWteFMwnUZk3kQwSTuKEFjiSH5iAxRGB3nQ0a41ZbVvnrWKF65lJ68IR5oS7npJp+SEsO5Zn RKBXXexZqIlKnB1o7xAoJU0G/khcYwxSc3+7RBH/5mTkOrby1lf8AXuBUB1ho4xXMR/SrhLjb 8sIS1mWxWvOp8TJ+vpUMJT9QoH9T7g+I23RVInMVJSUCICkYoK5i2yURnyCFg6HuVwqvhdLfv si4bbTHj4UHRQDurNA8co72WIWy1CRVzUfuTuKwtdyMf68dHlxnfJDNP9PQO1L+fnM13wq14W ovOAanmQZ9NsfezU9MQ6kbMkXiX6EgQa8PcBqTAg7TQJKJ4AUD3D4ueJHwSBgfzDpxVlpCwN1 NJNBi69Tt4PaHGfSS9GzmpGJ8HeNpJ9mr/TSlGsVxh6ZJlccHVzUu33bqIvrYN6kCbO297E9t jnAXTUPXyPEYfxml2XcQd5Wow93ivStQaqlnTdN00mNh3kAVjcerOTSa1/n3+eXzfbIYaa/gl SVSmfMWPZnzVgh2TEtiBFSLdfF150CiGIsD6U6pMK1+KysxHQ1Wo/b8Kmp9bvuZbN4AXQnHOl jQAL/vFL1wjQTW4KFDlNnARwMGduVJZ51zFzCaWMr4FqatRs5ojVxDt3iN/HulA3MQJ8ARKAg OMQWlPSRhuRAk888eCnIETknM/lbg7U62jgptRoYDicRd0ZmnWWDrZnhcILbk5FX+7xROyBf6 G7WdxvdCPpFD7bW9SjDIu0LNocvVxpPlqs084XR1cUcA0uqD1cAoI6FCP5BeftxbOvb6v8CJf 2jn9rug== =E2=80=A6 > Add NULL check in zynqmp_audio_init(), to handle kernel NULL > pointer dereference error. * Can it be more desirable to prevent such issues? * Would the message subject have been nicer with a key word like =E2=80=9C= PATCH=E2=80=9D (besides other refinements)? =E2=80=A6 > --- > drivers/gpu/drm/xlnx/zynqmp_dp_audio.c | 4 ++++ =E2=80=A6 Will you become more familiar with patch version descriptions? https://lore.kernel.org/all/?q=3D%22This+looks+like+a+new+version+of+a+pre= viously+submitted+patch%22 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/process/submitting-patches.rst?h=3Dv6.14-rc2#n310 Regards, Markus