mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Kieran Bingham <kbingham@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>
Subject: Re: [PATCH 0/2] scripts/gdb/symbols: make BPF debug info available to GDB
Date: Thu, 6 Nov 2025 07:07:54 +0100	[thread overview]
Message-ID: <0368bc9e-b5de-4b35-9f96-1bdc32aa6b02@siemens.com> (raw)
In-Reply-To: <ea1f1fd23d1bf4937c91be3bd45744b07b000b1e.camel@linux.ibm.com>

On 05.11.25 20:32, Ilya Leoshkevich wrote:
> On Thu, 2025-10-30 at 17:47 +0100, Jan Kiszka wrote:
>> On 10.07.25 13:53, Ilya Leoshkevich wrote:
>>> Hi,
>>>
>>> This series greatly simplifies debugging BPF progs when using QEMU
>>> gdbstub by providing symbol names, sizes, and line numbers to GDB.
>>>
>>> Patch 1 adds radix tree iteration, which is necessary for parsing
>>> prog_idr. Patch 2 is the actual implementation; its description
>>> contains some details on how to use this.
>>>
>>> Best regards,
>>> Ilya
>>>
>>> Ilya Leoshkevich (2):
>>>   scripts/gdb/radix-tree: add lx-radix-tree-command
>>>   scripts/gdb/symbols: make BPF debug info available to GDB
>>>
>>>  scripts/gdb/linux/bpf.py          | 253
>>> ++++++++++++++++++++++++++++++
>>>  scripts/gdb/linux/constants.py.in |   3 +
>>>  scripts/gdb/linux/radixtree.py    | 139 +++++++++++++++-
>>>  scripts/gdb/linux/symbols.py      |  77 ++++++++-
>>>  4 files changed, 462 insertions(+), 10 deletions(-)
>>>  create mode 100644 scripts/gdb/linux/bpf.py
>>>
>>
>> This wasn't picked up yet, right? Sorry for the late reply, my part
>> of
>> the "maintenance" here is best effort based.
>>
>> Looks good to me regarding integration. I haven't tried it out, I'm
>> just
>> wondering if it has notable performance impact on starting gdb or
>> interacting or when that could be the case. BPF programs are not
>> uncommon in common setups today. But if you don't want to debug them,
>> does this add unneeded overhead?
>>
>> Otherwise, I think it could move forward if it still applies (which
>> it
>> likely does).
>>
>> Jan
> 
> Thanks for taking a look!
> 
> I have to admit the performance implications are noticeable due to
> having to spawn an external process for each BPF prog.
> 
> What do you think about hiding this behind `lx-symbols --bpf` flag?

Sounds like a reasonable path.

Just one detail: I think gdb only uses a single dash for flags, thus:
lx-symbols -bpf.

Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

      reply	other threads:[~2025-11-06  6:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-10 11:53 Ilya Leoshkevich
2025-07-10 11:53 ` [PATCH 1/2] scripts/gdb/radix-tree: add lx-radix-tree-command Ilya Leoshkevich
2025-07-10 11:53 ` [PATCH 2/2] scripts/gdb/symbols: make BPF debug info available to GDB Ilya Leoshkevich
2025-08-05 13:22 ` [PATCH 0/2] " Ilya Leoshkevich
2025-08-05 16:48   ` Alexei Starovoitov
2025-08-27 11:26     ` Ilya Leoshkevich
2025-10-30 16:47 ` Jan Kiszka
2025-11-05 19:32   ` Ilya Leoshkevich
2025-11-06  6:07     ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0368bc9e-b5de-4b35-9f96-1bdc32aa6b02@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=kbingham@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®