From: David Brownell <david-b@pacbell.net>
To: paulus@samba.org, greg@kroah.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: unnecessary use of set_bit
Date: Sat, 27 Apr 2002 07:19:53 -0700 [thread overview]
Message-ID: <037201c1edf6$9a39c6e0$6800000a@krypton> (raw)
In-Reply-To: <15562.39130.683869.175699@argo.ozlabs.ibm.com>
> The ohci_hub_status_data() procedure in drivers/usb/host/ohci-hub.c in
> 2.5.11 is broken in a couple of ways: it uses set_bit on a char *
> address and it assumes little-endian byte order in the bitmap.
Greg already submitted my patch to Linus, but I guess it didn't
make it in yet. You'll be glad to know it stopped using set_bit().
Looks like your patch also preserves the API requirement that
the result be in little-endian byte order.
- Dave
prev parent reply other threads:[~2002-04-27 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-27 12:26 Paul Mackerras
2002-04-27 14:19 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='037201c1edf6$9a39c6e0$6800000a@krypton' \
--to=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®