From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754672AbcH0G1d (ORCPT <rfc822;w@1wt.eu>);
        Sat, 27 Aug 2016 02:27:33 -0400
Received: from mout.web.de ([217.72.192.78]:64050 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750895AbcH0G1b (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 27 Aug 2016 02:27:31 -0400
Subject: Re: IA64-IRQ: Use kmalloc_array() in sn_irq_lh_init()
To: Julia Lawall <julia.lawall@lip6.fr>
References: <349bbfb4-bada-628e-2981-ca2a315299fc@users.sourceforge.net>
 <2e046b40-1c8e-717f-68b1-534c3125724c@users.sourceforge.net>
 <alpine.DEB.2.10.1608261557130.3645@hadrien>
Cc: linux-ia64@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>,
        Tony Luck <tony.luck@intel.com>, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <0374f7bd-4623-fc4c-8913-894b1e0bb612@users.sourceforge.net>
Date: Sat, 27 Aug 2016 08:20:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.10.1608261557130.3645@hadrien>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:tsUxwvbsCaZisBfc4iKJKWcv5hV7yaHXJBzunT8Rno8fLiNUDQz
 fmf8YHIOF/ew0jqHqaHHhCXH3zxXtV6MaeUqfGcjs0Q81OqHfqGsnXtSc53sexXhjNnTyY0
 Ork1SaKpPc9x1hwW/vyZvuuyUg9LHTNiItxeeO7kovyws6cKUrLx9NuxGdw3koFKH7jcPsZ
 iDSkKleSxEKRDgNtxPQTA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:C57eJBWlW5U=:rn25vWqsGp+av9VLhktshE
 Lbw/TADssOkIL+hlrUeC2rugoM82eIoouRmy8slosPsL/TEjJVOvKPdsp8/TWaxwqSlwE9XL4
 TnhSi5jJmHM8ViUCeScvcNE69K+uxF8PgMyRC1MBR37ms5PF1Fvc5I1gXLrO8K6tyh+F+jBer
 Bl7gLr+6vQOMBHa1nRAzwuTUferiImHtaF/WWP8B64EJvcmsH7p7TLQJZkTILAZ6S07fjWHXw
 eJyLheZImC8+L5FhKGpSaIzymJ5BGzANHhNFLbpVho1JxHwxBc6ADKmhoUsNjyjf9WR+WfKTR
 QjhvaOq2DSrGB3oHfGGesFZTqLiXzNsa0cGY9TrPDFPceTSTqfGz51ylh+aYiMk87T8GcV2Fx
 MLg2g664jQC34zczmCWxQuW52Px4hxq94IuVaB8Mje+CfYmhFwO02kTaNxC37CGS1T1pyhV74
 caLIsWWrD/+ph0oO2SYHpE3QZSbUGh/+r+5ToLXg8DkIhhQ8qiPrCUS4uI5+mX/Xa/dDJ1tAB
 Q6pw4Rjpa5RsVHd7YxSZEPC+8roySXeR9vP4S2prngjOqoCY+ZaDJtdeGZNuUlMPUj+nLNwnK
 2c1N4IJ7ra7juvcOA5xrujMj9EDYQG1AO5VXi/OGw99HCsyB+gjeLJ6T7EefdwhNybL+u85Xu
 QZw5pxWhqnXMtXLyddytoR4Zk7Qy5NKuw1VH+rZN1C9E0KCxM7WJaGdQZN3+92KmbnSuCtMNc
 vJ7OitMV0zHn/wKh99+c4tRNxf9/HrIrJv/WBuAO50Enu2+0e4Wg92u5e1flTMNg+eReG8QSS
 HNGYsMQ
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> -		sn_irq_lh[i] = kmalloc(sizeof(struct list_head), GFP_KERNEL);
>> +		sn_irq_lh[i] = kmalloc(*sn_irq_lh[i], GFP_KERNEL);
> 
> Did a sizeof get lost here?

Unfortunately,  yes.

It is strange that I overlooked such a hiccup yesterday.


Should I start to automate the source code transformation which I imagined here
better with further scripts for the semantic patch language?

Regards,
Markus