mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Wang, Shane" <shane.wang@intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>
Cc: "Cihula, Joseph" <joseph.cihula@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"arjan@linux.intel.com" <arjan@linux.intel.com>,
	"andi@firstfloor.org" <andi@firstfloor.org>,
	"chrisw@sous-sol.org" <chrisw@sous-sol.org>,
	"jmorris@namei.org" <jmorris@namei.org>,
	"jbeulich@novell.com" <jbeulich@novell.com>,
	"peterm@redhat.com" <peterm@redhat.com>,
	"Wei, Gang" <gang.wei@intel.com>
Subject: RE: [RFC v6][PATCH 0b/4] intel_txt: Intel(R) Trusted Execution Technology support for Linux - Details
Date: Wed, 12 Aug 2009 23:42:56 +0800	[thread overview]
Message-ID: <037F493892196B458CD3E193E8EBAD4F01EAB641FD@pdsmsx502.ccr.corp.intel.com> (raw)
In-Reply-To: <4A82DBA2.2000509@zytor.com>

H. Peter Anvin wrote:
> On 08/12/2009 07:53 AM, Ingo Molnar wrote:
>> * Ingo Molnar <mingo@elte.hu> wrote:
>> 
>>> i reviewed & tried the latest patches. Structure of v6 looks now
>>> looks pretty good, but there are some build problems:
>>> 
>>> arch/x86/kernel/tboot.c: In function 'tboot_probe':
>>> arch/x86/kernel/tboot.c:76: error: implicit declaration of function
>>> 'set_fixmap' arch/x86/kernel/tboot.c:76: error: 'FIX_TBOOT_BASE'
>>> undeclared (first use in this function) arch/x86/kernel/tboot.c:76:
>>> error: (Each undeclared identifier is reported only once
>>> arch/x86/kernel/tboot.c:76: error: for each function it appears
>>> in.) arch/x86/kernel/tboot.c:77: error: implicit declaration of
>>> function 'fix_to_virt' arch/x86/kernel/tboot.c:77: warning: cast to
>>> pointer from integer of different size  
>>> 
>>> config attached.
>> 
>> ok, hpa fixed this bug - i tested it some more and here's the next
>> issue:
>> 
>> arch/x86/built-in.o: In function `tboot_shutdown':
>> (.text+0x2e3b5): undefined reference to
>> `acpi_wakeup_address'arch/x86/built-in.o: In function `tboot_sleep':
>> (.text+0x2e679): undefined reference to `acpi_wakeup_address' 
>> 
>> Config attached below.
>> 
> 
> tboot_sleep() references acpi_wakeup_address, which is only defined if
> CONFIG_ACPI_SLEEP is set.  We *could* make TBOOT require
> CONFIG_ACPI_SLEEP, but that looks like the wrong thing to do to me,
> unless TXT somehow depends on having S3 support.
> 
> 	-hpa

oh, S3 support by TXT is one of TXT support. We have code to secure S3 sleep and resume.
Without S3 support, TXT code is incomplete.

Shane

  reply	other threads:[~2009-08-12 15:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01  2:30 Joseph Cihula
2009-08-07  7:27 ` Ingo Molnar
2009-08-12 14:53   ` Ingo Molnar
2009-08-12 15:11     ` H. Peter Anvin
2009-08-12 15:42       ` Wang, Shane [this message]
2009-08-12 16:28         ` H. Peter Anvin
2009-08-12 16:30           ` Arjan van de Ven
2009-08-12 17:51             ` H. Peter Anvin
2009-08-12 18:20           ` Andi Kleen
2009-08-12 22:37             ` Wang, Shane
2009-08-12 23:07               ` H. Peter Anvin
2009-08-13  3:45                 ` Wang, Shane
2009-08-13  6:48       ` Ingo Molnar
2009-08-13  6:19     ` [PATCH 1/1] intel_txt: to fix build errors of CONFIG_ACPI_SLEEP Wang, Shane
2009-08-13  6:46       ` Ingo Molnar
2009-08-13 15:08         ` H. Peter Anvin
2009-08-13 15:46           ` Ingo Molnar
2009-08-13 15:57             ` H. Peter Anvin
2009-08-14  2:06           ` Wang, Shane
2009-08-14  2:54             ` H. Peter Anvin
2009-08-14  3:04             ` H. Peter Anvin
2009-08-14  8:52               ` Wang, Shane
2009-08-17  8:03                 ` [build bug] " Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=037F493892196B458CD3E193E8EBAD4F01EAB641FD@pdsmsx502.ccr.corp.intel.com \
    --to=shane.wang@intel.com \
    --cc=andi@firstfloor.org \
    --cc=arjan@linux.intel.com \
    --cc=chrisw@sous-sol.org \
    --cc=gang.wei@intel.com \
    --cc=hpa@zytor.com \
    --cc=jbeulich@novell.com \
    --cc=jmorris@namei.org \
    --cc=joseph.cihula@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®