From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC8DC4332F for ; Thu, 9 Nov 2023 09:35:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231341AbjKIJfu (ORCPT ); Thu, 9 Nov 2023 04:35:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229559AbjKIJfr (ORCPT ); Thu, 9 Nov 2023 04:35:47 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB9E5271F for ; Thu, 9 Nov 2023 01:35:44 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2c509d5ab43so8618951fa.0 for ; Thu, 09 Nov 2023 01:35:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699522543; x=1700127343; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=73mU5ZjtYMnmOZJ9gd4UkTXOrS0RPRiuoYmSTTyggiI=; b=wj4REZYx73zjK94OQYBUI/WC3qKjiMf380M9YeKBtZOFOvbZtN0sv/QpSEwvvj5Q9s eKU22UK9UPvjQNz5D6InyGewHePO0uvPAflLR/Dg8AZQ4JCVDAxtAs8bcKFSDGAm7g5C fl5DK78GvGPujg0trda+WdhqvN0y1UE0Zx39jnx+NOzOUx2Cc3qdorWtOL89VsfVOeb6 TI685ARJSQ7oADipdtKnXNX/Ef1N4KCuW87AJ10VTokvwwPN7c/P4aoDTx6WCQ0VL8yN w1fO1opEuzSt7uMHippFiB6tYKGISlu9o4x2KgT1TT31qlWEn/muMeeGJ1Ne1w24EA0a Eqzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699522543; x=1700127343; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=73mU5ZjtYMnmOZJ9gd4UkTXOrS0RPRiuoYmSTTyggiI=; b=orbLDLYkmkJPGAtlZLf77N9A2ma0vGrZrYXCoc7nkfC6ux+S4/xjl6k49SStbXk3Ad f1b3bBWvKh+cJNBYM+KkGCC6G/800rb9O/FY3zgZIQXDcpJP9v807TJX6Gz0O5rEieW8 2ARurMgtT8WsDHMAiwhfGLwFyQbRk4u/Z1r6aWywp4xDuUC2HfjU3fPKrgFbLtC61eBQ be+C9YrG/OR/y0kpXTAsI2RNkmCenqnc7SpoBgrfTero6iHEWz1pPLyquqABpcnH0aYF oPz4qkEVWR2ZKapfpaE4GmumOujh+Q6f7BrCZd/MHvbEXTW1M54B/6EskCMXs1SqARLF mYsg== X-Gm-Message-State: AOJu0YxJuVqlN+rOHchJla0XHeT6cSMXZZkRs0QQZ0tDfMOhj03omI5M xOz9a56CLQe4JrCp0xibEzexGQ== X-Google-Smtp-Source: AGHT+IFtQgXZTLwwEFsOtUMMFxL6SbYkRsyymCt7oQntHcwPfmp8c9NkolyeRieJTi4ZQHQnbS6CCg== X-Received: by 2002:a05:651c:504:b0:2c5:ffa:375d with SMTP id o4-20020a05651c050400b002c50ffa375dmr3948286ljp.11.1699522543062; Thu, 09 Nov 2023 01:35:43 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id o13-20020a05600c378d00b003fbe4cecc3bsm1493670wmr.16.2023.11.09.01.35.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Nov 2023 01:35:42 -0800 (PST) Message-ID: <037f44d9-7240-4daf-9fe1-ac89fae9499c@linaro.org> Date: Thu, 9 Nov 2023 10:35:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] hwmon: Add support for Amphenol ChipCap 2 Content-Language: en-US To: Javier Carrasco , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jean Delvare , Guenter Roeck , Jonathan Corbet , Liam Girdwood , Mark Brown Cc: Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org References: <20231020-topic-chipcap2-v1-0-087e21d4b1ed@gmail.com> <20231020-topic-chipcap2-v1-3-087e21d4b1ed@gmail.com> <285ec1d8-d277-403c-961f-3de523fc799f@gmail.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2023 09:59, Javier Carrasco wrote: > > > On 09.11.23 09:40, Krzysztof Kozlowski wrote: >> On 08/11/2023 17:35, Javier Carrasco wrote: >>>>> + >>>>> + data->regulator = devm_regulator_get_optional(dev, "vdd"); >>>>> + if (!IS_ERR(data->regulator)) { >>>>> + ret = cc2_retrive_alarm_config(data); >>>>> + if (ret) >>>>> + goto cleanup; >>>>> + } else { >>>>> + /* No access to EEPROM without regulator: no alarm control */ >>>> >>>> Test your code with deferred probe. Are you sure you handle it >>>> correctly? To me, it looks like you handle deferred probe the same as >>>> any error. >>>> >>> The -EPROBE_DEFER is propagated to the probe function and it is the >>> returned value. I clarified the error path in v2 so no error messages >> >> Really? >> >> I see: >> if (!IS_ERR(data->regulator)) { >> // so you do not go here >> } else { >> goto dev_register; >> } >> dev_register is not error path. So how do you return EPROBE_DEFER? >> >> Which line of code does it? >> > EPROBE_DEFER is returned if the command window was missed, which is How "command window was missed" is related to the place I commented? > checked in cc2_retrieve_alarm_config() (there is a typo I just corrected > -> cc2_retrive_alarm_config() in the current version). It could then > happen where you added a comment, but not because > devm_regulator_get_optional() failed. > > Are you expecting a probe deferring if devm_regulator_get_optional() > fails as well? Like if the regulator is still not ready when the > function is called. We talk only about this place. Not others. Best regards, Krzysztof