From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8219DC27C40 for ; Thu, 24 Aug 2023 12:55:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240819AbjHXMy5 (ORCPT ); Thu, 24 Aug 2023 08:54:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241379AbjHXMyc (ORCPT ); Thu, 24 Aug 2023 08:54:32 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93C141BFB for ; Thu, 24 Aug 2023 05:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692881587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kKQ9WOE2Aragce0+o/m7aVIS5d41CLufSWNbA4ImA4I=; b=JvrNEu1IDJI5bvBa+hV2LqzCn8qU2ztZ337bKq6qx4Yuh/zbTSPXC2f1w5jy3xVVNJNr+w V/gpFndsHsjIA4cWKLXLgBHRj1vDktofNNPiMOe2Kyu79GMRntPHZ9b2iSa+BfryB6fWcW aH1Wx06mbJmarLG2TFfXaTXlmHxnJzc= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-qFeQJbwdOfek5WhzepGK2A-1; Thu, 24 Aug 2023 08:53:05 -0400 X-MC-Unique: qFeQJbwdOfek5WhzepGK2A-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-94a356c74e0so506205266b.2 for ; Thu, 24 Aug 2023 05:53:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692881584; x=1693486384; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kKQ9WOE2Aragce0+o/m7aVIS5d41CLufSWNbA4ImA4I=; b=U/wSXElwnQd5dSfBijCYL/7AHmdC8BQDz9eonNS13sBMn8ZpmCeeVNjYVrPfzqdRqL Z0W5l6dT06H26n4Ir+fEFKS5YiqhGeFnR68V/4NgKasRYIQExsOUyfP16Mj9ZazUMAHj IQHyOLkkhiI85umjwo/79TbSO7NEMt3iJOeMeS8b16AJO2dpy76x8b+LDoSrNUC0dx5m lXnEGOHOYmkeCQ5WeL1THsVnua0REKLhvNBn6yDNFK4udlFVr64KQusGf1nxPatQyICX KYBxLWAxZw58pcDA5ZMBVWpxOh9XSd6HgOutvG4t2D9IvOCmC05ohknyOYWgnwu+HrEu D8uA== X-Gm-Message-State: AOJu0YwUIGCpF5DOVZw5KVEIujptokxJBQ8c51pN4eCux3B6/PPfwgVb OfA7birsQpYMtw2XbTCA3gakTjI6JGudQ/t8ijV8k518WEyUNCNglJTpEk7oqjcNxJLDnxleJTI intlOKAjMVHWNoPTqFikt6YnV X-Received: by 2002:a17:907:778d:b0:9a1:d7cd:603a with SMTP id ky13-20020a170907778d00b009a1d7cd603amr4013264ejc.58.1692881584346; Thu, 24 Aug 2023 05:53:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHX6wkHtTAdCUwl5KxmFYb257JKgY0QOHqKG5XpgYEz7M1IInC82odlL1o5XG742djsg7RGlA== X-Received: by 2002:a17:907:778d:b0:9a1:d7cd:603a with SMTP id ky13-20020a170907778d00b009a1d7cd603amr4013249ejc.58.1692881584054; Thu, 24 Aug 2023 05:53:04 -0700 (PDT) Received: from ?IPV6:2a02:810d:4b3f:de9c:642:1aff:fe31:a15c? ([2a02:810d:4b3f:de9c:642:1aff:fe31:a15c]) by smtp.gmail.com with ESMTPSA id lv27-20020a170906bc9b00b0099cb349d570sm10915871ejb.185.2023.08.24.05.53.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 05:53:03 -0700 (PDT) Message-ID: <03804681-51f1-0840-6583-1753bd0a18d3@redhat.com> Date: Thu, 24 Aug 2023 14:53:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 18/20] drm/drm_gpuva_mgr: Remove set but unused variable 'prev' Content-Language: en-US To: Lee Jones Cc: Thomas Zimmermann , linux-kernel@vger.kernel.org, Maxime Ripard , =?UTF-8?Q?Christian_K=c3=b6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Sumit Semwal , linux-media@vger.kernel.org References: <20230824073710.2677348-1-lee@kernel.org> <20230824073710.2677348-19-lee@kernel.org> From: Danilo Krummrich Organization: RedHat In-Reply-To: <20230824073710.2677348-19-lee@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, On 8/24/23 09:37, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/drm_gpuva_mgr.c: In function ‘__drm_gpuva_sm_map’: > drivers/gpu/drm/drm_gpuva_mgr.c:1079:39: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable] Thanks for fixing this up. However, I already had a patch in the queue addressing the warning, which I already applied to drm-misc/drm-misc-next-fixes. - Danilo > > Signed-off-by: Lee Jones > --- > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: "Christian König" > Cc: Danilo Krummrich > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > --- > drivers/gpu/drm/drm_gpuva_mgr.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gpuva_mgr.c b/drivers/gpu/drm/drm_gpuva_mgr.c > index f86bfad74ff8a..ad99c9cfedac7 100644 > --- a/drivers/gpu/drm/drm_gpuva_mgr.c > +++ b/drivers/gpu/drm/drm_gpuva_mgr.c > @@ -1076,7 +1076,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr, > u64 req_addr, u64 req_range, > struct drm_gem_object *req_obj, u64 req_offset) > { > - struct drm_gpuva *va, *next, *prev = NULL; > + struct drm_gpuva *va, *next; > u64 req_end = req_addr + req_range; > int ret; > > @@ -1106,7 +1106,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr, > ret = op_unmap_cb(ops, priv, va, merge); > if (ret) > return ret; > - goto next; > + continue; > } > > if (end > req_end) { > @@ -1151,7 +1151,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr, > ret = op_remap_cb(ops, priv, &p, NULL, &u); > if (ret) > return ret; > - goto next; > + continue; > } > > if (end > req_end) { > @@ -1184,7 +1184,7 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr, > ret = op_unmap_cb(ops, priv, va, merge); > if (ret) > return ret; > - goto next; > + continue; > } > > if (end > req_end) { > @@ -1205,8 +1205,6 @@ __drm_gpuva_sm_map(struct drm_gpuva_manager *mgr, > break; > } > } > -next: > - prev = va; > } > > return op_map_cb(ops, priv,