From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-238.mta0.migadu.com [91.218.175.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE96E431482 for ; Thu, 13 Aug 2026 21:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.238 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786656722; cv=none; b=n8IszKiYaEZtdWb25ioPo4usXBTSKBOtKS0iYZIfa2HglAGmjlS9zwBx4qIW1POcjvmarhYq2rAbVvtrKjcB9C81h/G2YjJ/hbUoynjMbShkqlgrTeNLQcGALrgQAGsRYgczBNqFa11wKK1XC+FfXnwbuYdfHTDJz0CD/PNrUZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786656722; c=relaxed/simple; bh=6J8sP/C7V6GGg1p+KUp/a1yRHoCcDJDRcT0E3q+spIs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XXmzKU+zeBZ4N8ckP0KhHae6+wx2wMZDQA9qFO5s7QG8ZZWhrE720Gaka6w1hOp9vpRtDUanSLqMbMT5XwO7WsX/6mntg7yccNySlrk2Gndb13AGA/XMtKrowg0u/+wVGqB8YAutA46gvDYmJuylgbiaHmXSxqIEI4rlahcrWqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=tVROt7Ie; arc=none smtp.client-ip=91.218.175.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="tVROt7Ie" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=6J8sP/C7V6GGg1p+KUp/a1yRHoCcDJDRcT0E3q+spIs=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1786656717; v=1; x=1787261517; b=tVROt7IeV+qICLRYtCYakm1lFswXP1JNAX6r8UhONpcGd/nIw/NGLCML6jSW75iNB8zcBr31 tZuCoXNIIBqgWI3ok2Vq6IqE21RHit4odEOIL3rP136LEPaEQL/0y3F0VRWVcslsQGA2QWTuApE smdK2FbwjW/X+I8a3DYNhNgI= X-Envelope-To: linux-kernel@vger.kernel.org Received: from [192.168.1.24] (64.43.42.247) by smtp.migadu.com with ESMTPS id 005fb556f5729059; Thu, 13 Aug 2026 21:31:46 +0000 X-Migadu-Flow: FLOW_OUT Message-ID: <038cb83b-ad8f-493c-b904-05bec353aaf4@linux.dev> Date: Thu, 13 Aug 2026 22:31:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v7 3/3] dpll: zl3073x: add PTP clock support To: Ivan Vecera , netdev@vger.kernel.org Cc: Petr Oros , Chris du Quesnay , Arkadiusz Kubalewski , Jakub Kicinski , Jiri Pirko , Min Li , Paolo Abeni , Richard Cochran , linux-kernel@vger.kernel.org References: <20260811134700.1211010-1-ivecera@redhat.com> <20260811134700.1211010-4-ivecera@redhat.com> Content-Language: en-US From: Vadim Fedorenko In-Reply-To: <20260811134700.1211010-4-ivecera@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/08/2026 14:47, Ivan Vecera wrote: > Add PTP clock support for the ZL3073x DPLL driver. A PTP clock device > is registered for each DPLL channel regardless of the initial channel > state, providing gettimex64, settime64, adjtime, adjfine, adjphase > and getmaxphase callbacks. > > Callback availability depends on the current channel state: > - adjfine: when NCO pin is connected (returns -EOPNOTSUPP otherwise) > - adjphase: available when tracking a reference, uses TIE write > - adjtime: always available and uses > * phase step for sub-second deltas when NCO pin is connected > * TIE write when tracking a reference > * plain ToD read-modify-write otherwise > - gettime/settime: always available > > The adjtime callback splits multi-second adjustments into a ToD > read-modify-write for the seconds part and a sub-second mechanism > (phase step or TIE write) for the remainder. On partial failure > where seconds were already committed, success is returned to > prevent the PTP servo from retrying and applying seconds again. > > All PTP callbacks are serialized by the existing per-DPLL zldpll->lock > mutex, which is also used by DPLL pin and device callbacks. > > Reviewed-by: Petr Oros > Tested-by: Chris du Quesnay > Signed-off-by: Ivan Vecera It's a bit weird on formatting because of functions reordering. Anyways, main parts LGTM Reviewed-by: Vadim Fedorenko