From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9CDC3EFD15 for ; Wed, 20 May 2026 15:39:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779291591; cv=none; b=MybtB6wL6pueE2WA/IvDwQtjXTEoF+xKWaMfUZztpuxHH6Of0MObEUE3xvH7T0PVmtsdviMVsp6D6hw+LouMpFPb6PeLvV3qbZyTc7sPBoORWx/z8UdDAu+83rRQa7KX6E4jkEQtAWctSBcbFCQIGntEr7+IorARGPh/nNuAsKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779291591; c=relaxed/simple; bh=Nr2JR0dpmuWjfz/WKWJ82bULQ71y+4zZb6kDz6jYenM=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:From:To:Cc: References:In-Reply-To; b=ft2roDd+6p89aNaPpJiwqWb1/TegpgQEAMdhlQdgBnkn+glKbdv2zEb06XOOEsQW8GSNxO1qXO/U/5XdcDCRFdPzEM7oRoQc8nsB1o7Hqz68rXgcAAp+ocN07qcr1gMbxUSUkmTaSrWx750xHOtXDDGn1xl6YA2jG8TeoQkFzy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A3lKGGOy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LisuZ38h; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A3lKGGOy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LisuZ38h" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64KDXiVf1798416 for ; Wed, 20 May 2026 15:39:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=KDEsJl+ouBVmHeKEwleH/vX4 IKf0Y5kx3a9fe6U5jtw=; b=A3lKGGOyHVCC26b/kKVZSeKENVLeJuhALwex6RqG Of4u57otpR+2/FQuIvvyMZnuRB6s7phqVB+Jhp29axK3V107G+owsh1Qq0Kmc3eD b9w7gT1kgl0ub9b+CpGpq/DNCtjjTVYiKdn/xTsuPpmQ1CCewTmwFlg/3KRqzRGw c2yCZzKlaQSgtiQ++mE0qYMb5BxARRK7xAG2lBMdBckYjkeJ5gqgmqjuQaIEWR/u 9RF2CUmJ2DMJ4Vm/I5LdLRakXAygBE7yhM5eRrW49jpGoVXwolkKE4W14b3b0dGN iD1rzeQLM8eVJEIE5bBkEyBRlAM5/3SjdR3OfHTl3KxHbg== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9dxu0h5h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 15:39:48 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-6312aa1d7adso4176507137.0 for ; Wed, 20 May 2026 08:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779291587; x=1779896387; darn=vger.kernel.org; h=in-reply-to:content-language:references:cc:to:from:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=KDEsJl+ouBVmHeKEwleH/vX4IKf0Y5kx3a9fe6U5jtw=; b=LisuZ38hB33w6fTjcJuroNKtkOpEhJXCL1fPez2xhm7rn+dBb/nSWyvHI+wsap4dWR YF7tpQB6y6xTz3YulCAwv8LavM00YDtNao9eLNmg69mmSJfY2aH1HBru7XvCNLYlrSbx L/SEHV+LBhpLDnw5z/I4vFldnqX0/6lGfArxcg7DPO7kqoZsiKqeY1CdNlkAqBlCyJot dnRewB64CMCJMpbRPHaSfIMC6SrSuQtO7AKW6DP9NtmEb9fV8Xf2FytbYR+Ug9ro3IEA ubtPxTiYVJ6XWV245L7Y7IDYZTBTeDfLC/bgUKRi7fjfQTA9A6JoMbP/+QY2XHBVghdt 5UKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779291587; x=1779896387; h=in-reply-to:content-language:references:cc:to:from:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KDEsJl+ouBVmHeKEwleH/vX4IKf0Y5kx3a9fe6U5jtw=; b=r4FqqWGu4Id1f6J0VgvRl1lZK6LtnriXo2+4X2tXeSGRfgq+SX+Ta3meK8Bh50a1TV EyG7HKUe26pV8kfC3dW54uS39noiYQuo6Je3l6kgVGxHP9W+9lwizOI3qHlJRaGVpXGM Tu0vdjIZBR649izFiIAZyA3YWzAuD7MhxSyxAYytP3le9Szpj3zJOgei7+qBmWXkqTH7 aECTbKWeCoc7yGC0ZQScrcuaPaHB03SoBBBNaGOSIqLYfGn4zoJxZSFZpQy7gOatfHF0 9QckbnRbaedxNh6p/NaSlimaRKhzmTbjlgmQ0AiGti1IIqGy+/KV4qHkQmwfPC6gZRIi kmtQ== X-Forwarded-Encrypted: i=1; AFNElJ91PdcY//PO9Iv/vrMPoPl5n8fA6XnMEjjN43fZa2HuS4J5Z5bhB4GxUr4seYQFzTmCizxPYH80lodB+DY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+oibVMW6vkJjvWa0GAooQQe3Xd+2bYhE9+J2FAwrk8Niqlu7X GMKYXpaU1pq8S+GszSa3R1kSVvqkS4C6KprYWXJbFUXuFiKe9Qzj+RmeBhwz6hpU7UmVTJkuN4+ vodAk0zxjNT5YI1nON8bY7AiF//tVZ96VPBm+EF5kBA35Ix9QrGHJDMnf0C1sQ0p771M= X-Gm-Gg: Acq92OFrppFY9fnKslirUBelAS5S4rj9+r/dYK5l2IJiZvtbObxrXjqarbOLTOniyzL ckJsnuMGHHLcFq2bPOxfqYt0IgwwXNwMmWDSvs53YBM/7Y842k5gqEU2aWXFfbpUiVmmxY4cviJ I719D96NQh7MzHR8OMaERSDpJ9zQyr/Ux314ZT3bkT6IB+cpv6Mut+yDpQWMcgdjRcUX1gBuXcf hWeNM8qGJmj3zooLMllyCzu4t8VnGEezysWgY5oU7uOUodKeXmuQO0ipatgFqOS7gMp5RuQtSKQ wIbpXc3iZlnXLsJc1am7Ncxq6zDihhsQaKFBHMbQrLsEz+R/NkGlbckr7uDje5/3fSYzcq2fEZa lYMEIDDtVDpzfxncZbVS7upvDjfcr9i2nHzOSfKsrXuVZtf8T8tlXKwVl11ftLUrCQGpIpsHUvg V3llArS88GNi4PHxiIbtmvkcBHGy/hCT4EgI/FBgAGuZzajyEJGmRlqDjJg2lcH+W9+5PSrLRSl wfQgDM/i4WMciGa X-Received: by 2002:a05:6102:3752:b0:631:3bbb:f268 with SMTP id ada2fe7eead31-63a3fea4735mr11679085137.23.1779291586956; Wed, 20 May 2026 08:39:46 -0700 (PDT) X-Received: by 2002:a05:6102:3752:b0:631:3bbb:f268 with SMTP id ada2fe7eead31-63a3fea4735mr11679054137.23.1779291586517; Wed, 20 May 2026 08:39:46 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4c2a68dsm887643266b.18.2026.05.20.08.39.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 08:39:45 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------3AmKf01MW2hv0Vhzmru0T8mx" Message-ID: <038fc58a-7233-49b4-822b-a6d99abf2382@oss.qualcomm.com> Date: Wed, 20 May 2026 17:39:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 13/15] media: qcom: camss: Add CAMSS Offline Processing Engine driver From: Hans de Goede To: Loic Poulain , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , Kees Cook , "Gustavo A. R. Silva" , Bryan O'Donoghue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, devicetree@vger.kernel.org, laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com References: <20260508-camss-isp-ope-v3-0-bb1055274603@oss.qualcomm.com> <20260508-camss-isp-ope-v3-13-bb1055274603@oss.qualcomm.com> <3f75dd6a-96d8-4feb-b44c-39c8f5d3492b@oss.qualcomm.com> Content-Language: en-US, nl In-Reply-To: <3f75dd6a-96d8-4feb-b44c-39c8f5d3492b@oss.qualcomm.com> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDE1MSBTYWx0ZWRfX868wp3U2/Qpf GA9pR4smOigoZSqKcHPT5aTJwkw/91mpDWM9ppZ1R6AiNbSEe1mOSo6NGv1qDvF1X/OjUIFvWFN o8D/9wl7CypL9AOvInzLbXd28ksSo0TZeJ1uN5Xskk2pBdDBA4kVv53vMx8f8mUJA+6sVzwe8e0 DLArwNZdqLIsjUddeMIl/a8iCLq6VRVUVKkf88p2Ge4s0jTCAfTr9VR+NYmh/zmdxn8swPYr5Rc J95ddrzEPFsdp3VrwP/eA4kxD3anzMNvex6h1Uq9/s6MWojYE6/7TtWcEfF3Eknwb4DXiwckBmY a3+YognFYS+opaeqtUu+c76vZrxHXxPPfdbh7NYjYXsYUub66oxQ4h+PCnNtaDbQ1RCr9Wo4AJx i4O/VxlG4ZgW2H4hDShATUEfpaARSAdDSpwKhmgMTOaFQFWOJ8MuJgxWJ18MV6if8iEWQFzsTtK oPjbSGhtD4rJFDtu7RA== X-Authority-Analysis: v=2.4 cv=Zckt8MVA c=1 sm=1 tr=0 ts=6a0dd5c4 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=r77TgQKjGQsHNAKrUKIA:9 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=H1Te7B14W6HF1q1WNAgA:9 a=QEXdDO2ut3YA:10 a=wa7H0P_oPzXo1QdaWhUA:9 a=B2y7HmGcmWMA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-GUID: -7ocf2IiPa9KvZdAA6ba49FWKP9Ltum- X-Proofpoint-ORIG-GUID: -7ocf2IiPa9KvZdAA6ba49FWKP9Ltum- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 phishscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200151 This is a multi-part message in MIME format. --------------3AmKf01MW2hv0Vhzmru0T8mx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi All, On 20-May-26 17:32, johannes.goede@oss.qualcomm.com wrote: > 4. The v3 driver limits supported capture formats for the ope_disp_output > node (ope_enum_fmt_vid_cap()) to those matching ctx->proc_mbus_code, but > this not how this supposed to work. For media-controller centric > drivers, userspace is supposed to be able to enumerate all supported output > formats, as well as output formats for a specific mbus-code. > > This is controlled by the v4l2_fmtdesc.mbus_code field, if this is 0 > then all formats should be returned and if it is set then only formats > which can be outputted for that mbus-code should be returned. > > No active driver state like ctx->proc_mbus_code should be queried, > setting a compatible mbus code on the sink pad which is the source > for the /dev/video# capture node is userspace's responsibility. > > Also see: > https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/vidioc-enum-fmt.html > "Regardless of the value of the mbus_code field, the enumerated image > formats shall not depend on the active configuration of the video > device or device pipeline." FYI attached is a patch fixing this, feel free to squash into the next version. Regards, Hans --------------3AmKf01MW2hv0Vhzmru0T8mx Content-Type: text/x-patch; charset=UTF-8; name="0001-media-qcom-camss-OPE-Fix-ope_enum_fmt_vid_cap.patch" Content-Disposition: attachment; filename="0001-media-qcom-camss-OPE-Fix-ope_enum_fmt_vid_cap.patch" Content-Transfer-Encoding: base64 RnJvbSBhMTMzOTI3YzI4ZWQyNGRiZDVmZWMwYjQ4ZGU4NzE4ZTY3YTBhZGEyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIYW5zIGRlIEdvZWRlIDxqb2hhbm5lcy5nb2VkZUBv c3MucXVhbGNvbW0uY29tPgpEYXRlOiBUdWUsIDE5IE1heSAyMDI2IDIxOjQ5OjA3ICswMjAw ClN1YmplY3Q6IFtQQVRDSCAxLzJdIG1lZGlhOiBxY29tOiBjYW1zczogT1BFOiBGaXggb3Bl X2VudW1fZm10X3ZpZF9jYXAoKQoKVGhlIHYzIGRyaXZlciBsaW1pdHMgc3VwcG9ydGVkIGNh cHR1cmUgZm9ybWF0cyBmb3IgdGhlIG9wZV9kaXNwX291dHB1dApub2RlIChvcGVfZW51bV9m bXRfdmlkX2NhcCgpKSB0byB0aG9zZSBtYXRjaGluZyBjdHgtPnByb2NfbWJ1c19jb2RlLCBi dXQKdGhpcyBub3QgaG93IHRoaXMgc3VwcG9zZWQgdG8gd29yay4gRm9yIG1lZGlhLWNvbnRy b2xsZXIgY2VudHJpYwpkcml2ZXJzLCB1c2Vyc3BhY2UgaXMgc3VwcG9zZWQgdG8gYmUgYWJs ZSB0byBlbnVtZXJhdGUgYWxsIHN1cHBvcnRlZCBvdXRwdXQKZm9ybWF0cywgYXMgd2VsbCBh cyBvdXRwdXQgZm9ybWF0cyBmb3IgYSBzcGVjaWZpYyBtYnVzLWNvZGUuCgpUaGlzIGlzIGNv bnRyb2xsZWQgYnkgdGhlIHY0bDJfZm10ZGVzYy5tYnVzX2NvZGUgZmllbGQsIGlmIHRoaXMg aXMgMAp0aGVuIGFsbCBmb3JtYXRzIHNob3VsZCBiZSByZXR1cm5lZCBhbmQgaWYgaXQgaXMg c2V0IHRoZW4gb25seSBmb3JtYXRzCndoaWNoIGNhbiBiZSBvdXRwdXR0ZWQgZm9yIHRoYXQg bWJ1cy1jb2RlIHNob3VsZCBiZSByZXR1cm5lZC4KCk5vIGFjdGl2ZSBkcml2ZXIgc3RhdGUg bGlrZSBjdHgtPnByb2NfbWJ1c19jb2RlIHNob3VsZCBiZSBxdWVyaWVkLApzZXR0aW5nIGEg Y29tcGF0aWJsZSBtYnVzIGNvZGUgb24gdGhlIHNpbmsgcGFkIHdoaWNoIGlzIHRoZSBzb3Vy Y2UKZm9yIHRoZSAvZGV2L3ZpZGVvIyBjYXB0dXJlIG5vZGUgaXMgdXNlcnNwYWNlJ3MgcmVz cG9uc2liaWxpdHkuCgpBbHNvIHNlZToKaHR0cHM6Ly93d3cua2VybmVsLm9yZy9kb2MvaHRt bC9sYXRlc3QvdXNlcnNwYWNlLWFwaS9tZWRpYS92NGwvdmlkaW9jLWVudW0tZm10Lmh0bWwK IlJlZ2FyZGxlc3Mgb2YgdGhlIHZhbHVlIG9mIHRoZSBtYnVzX2NvZGUgZmllbGQsIHRoZSBl bnVtZXJhdGVkIGltYWdlCiBmb3JtYXRzIHNoYWxsIG5vdCBkZXBlbmQgb24gdGhlIGFjdGl2 ZSBjb25maWd1cmF0aW9uIG9mIHRoZSB2aWRlbwogZGV2aWNlIG9yIGRldmljZSBwaXBlbGlu ZS4iCgpOb3RlIGFzIGZvciB0aGUgc291cmNlLXBhZCBmZWVkaW5nIGludG8gdGhlIHNpbmst cGFkIGxpbmluZyB1cCBmbXQgLwptYnVzLWNvZGUgd2lzZSwgdGhpcyBpcyBhbHNvIHVzZXJz cGFjZSdzIHJlc3BvbnNpYmlsaXR5IGFuZCBzaG91bGQgYmUKY2hlY2tlZCBieSBjYWxsaW5n IG1lZGlhX3BpcGVsaW5lX3N0YXJ0KCkgYXQgc3RyZWFtLW9uIHRpbWUuCgpTaWduZWQtb2Zm LWJ5OiBIYW5zIGRlIEdvZWRlIDxqb2hhbm5lcy5nb2VkZUBvc3MucXVhbGNvbW0uY29tPgot LS0KIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vcWNvbS9jYW1zcy9jYW1zcy1pc3Atb3BlLmMg fCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkK CmRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Fjb20vY2Ftc3MvY2Ftc3Mt aXNwLW9wZS5jIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9xY29tL2NhbXNzL2NhbXNzLWlz cC1vcGUuYwppbmRleCAxZmViZTNlNzQxN2YuLjQ5NWQ0YjBiMTAxZiAxMDA2NDQKLS0tIGEv ZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9xY29tL2NhbXNzL2NhbXNzLWlzcC1vcGUuYworKysg Yi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Fjb20vY2Ftc3MvY2Ftc3MtaXNwLW9wZS5jCkBA IC0xODAwLDcgKzE4MDAsNyBAQCBzdGF0aWMgaW50IG9wZV9lbnVtX2ZtdF92aWRfY2FwKHN0 cnVjdCBmaWxlICpmaWxlLCB2b2lkICpwcml2LCBzdHJ1Y3QgdjRsMl9mbXRkZQogCXVuc2ln bmVkIGludCBpLCBuID0gMDsKIAogCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKG9wZV9v dXRwdXRfZm10cyk7IGkrKykgewotCQlpZiAob3BlX291dHB1dF9mbXRzW2ldLm1idXNfY29k ZSAhPSBjdHgtPnByb2NfbWJ1c19jb2RlKQorCQlpZiAoZi0+bWJ1c19jb2RlICYmIG9wZV9v dXRwdXRfZm10c1tpXS5tYnVzX2NvZGUgIT0gZi0+bWJ1c19jb2RlKQogCQkJY29udGludWU7 CiAJCWlmIChuKysgPT0gZi0+aW5kZXgpIHsKIAkJCWYtPnBpeGVsZm9ybWF0ID0gb3BlX291 dHB1dF9mbXRzW2ldLmZvdXJjYzsKLS0gCjIuNTQuMAoK --------------3AmKf01MW2hv0Vhzmru0T8mx--