From: Joe Perches <joe@perches.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
Greg KH <gregkh@linuxfoundation.org>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
speakup@linux-speakup.org
Subject: Re: [PATCH] staging: speakup: Fix coding style
Date: Sun, 13 May 2018 14:49:06 -0700 [thread overview]
Message-ID: <039ab80bd6a653505e606bf87fceae156fe127e1.camel@perches.com> (raw)
In-Reply-To: <20180513093830.lwspfmjaxjixpaew@var.youpi.perso.aquilenet.fr>
On Sun, 2018-05-13 at 11:38 +0200, Samuel Thibault wrote:
[]
> @@ -68,7 +68,7 @@ int spk_punc_level, spk_reading_punc;
> char spk_str_caps_start[MAXVARLEN + 1] = "\0";
> char spk_str_caps_stop[MAXVARLEN + 1] = "\0";
> char spk_str_pause[MAXVARLEN + 1] = "\0";
> -bool spk_paused = 0;
> +bool spk_paused;
> const struct st_bits_data spk_punc_info[] = {
> {"none", "", 0},
> {"some", "/$%&@", SOME},
> @@ -1782,8 +1782,7 @@ static void speakup_con_update(struct vc
> /* Speakup output, discard */
> return;
> speakup_date(vc);
> - if (vc->vc_mode == KD_GRAPHICS && !spk_paused && spk_str_pause[0])
> - {
> + if (vc->vc_mode == KD_GRAPHICS && !spk_paused && spk_str_pause[0]) {
> synth_printf("%s", spk_str_pause);
> spk_paused = 1;
probably nice to change the assignments of
spk_paused to true&false too
next prev parent reply other threads:[~2018-05-13 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-13 9:38 Samuel Thibault
2018-05-13 21:49 ` Joe Perches [this message]
2018-12-24 10:12 Daniel Smith
2018-12-24 13:07 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ab80bd6a653505e606bf87fceae156fe127e1.camel@perches.com \
--to=joe@perches.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®