From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FB5BC7618F for ; Fri, 26 Jul 2019 03:55:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7794E218DA for ; Fri, 26 Jul 2019 03:55:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726023AbfGZDzd (ORCPT ); Thu, 25 Jul 2019 23:55:33 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2764 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725842AbfGZDzc (ORCPT ); Thu, 25 Jul 2019 23:55:32 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 9BD8BF112BB1844FE3BE; Fri, 26 Jul 2019 11:55:30 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.211) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 26 Jul 2019 11:55:26 +0800 Subject: Re: [PATCH] fs: f2fs: Remove unnecessary checks of SM_I(sbi) in update_general_status() To: Jia-Ju Bai , CC: , References: <20190726034512.32478-1-baijiaju1990@gmail.com> From: Chao Yu Message-ID: <039c2c03-51eb-0666-bfac-696fb678a733@huawei.com> Date: Fri, 26 Jul 2019 11:55:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190726034512.32478-1-baijiaju1990@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/7/26 11:45, Jia-Ju Bai wrote: > In fill_super() and put_super(), f2fs_destroy_stats() is called > in prior to f2fs_destroy_segment_manager(), so if current > sbi can still be visited in global stat list, SM_I(sbi) should be > released yet. > For this reason, SM_I(sbi) does not need to be checked in > update_general_status(). > Thank Chao Yu for advice. > > Signed-off-by: Jia-Ju Bai Reviewed-by: Chao Yu Thanks,