mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Song Liu <songliubraving@fb.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-raid <linux-raid@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	Matthew Ruffell <matthew.ruffell@canonical.com>,
	"Xiao Ni" <xni@redhat.com>
Subject: Re: Revert "dm raid: remove unnecessary discard limits for raid10"
Date: Wed, 9 Dec 2020 23:14:07 +0000	[thread overview]
Message-ID: <03EC7F7D-DF6E-4962-BBA7-FA554509C2E5@fb.com> (raw)
In-Reply-To: <20201209223615.GA2752@redhat.com>



> On Dec 9, 2020, at 2:36 PM, Mike Snitzer <snitzer@redhat.com> wrote:
> 
> On Wed, Dec 09 2020 at  4:58pm -0500,
> Song Liu <songliubraving@fb.com> wrote:
> 
>> This reverts commit f0e90b6c663a7e3b4736cb318c6c7c589f152c28.
>> 
>> Matthew Ruffell reported data corruption in raid10 due to the changes
>> in discard handling [1]. Revert these changes before we find a proper fix.
>> 
>> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1907262/ 
>> Cc: Matthew Ruffell <matthew.ruffell@canonical.com>
>> Cc: Xiao Ni <xni@redhat.com>
>> Cc: Mike Snitzer <snitzer@redhat.com>
>> Signed-off-by: Song Liu <songliubraving@fb.com>
> 
> If you're reverting all the MD code that enabled this DM change, then
> obviously the DM change must be reverted too.  But please do _not_
> separate the DM revert from the MD reverts.

Good point! I should have thought about it through. 

Thanks,
Song

[...]



  reply	other threads:[~2020-12-09 23:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09 21:58 [PATCH] " Song Liu
2020-12-09 22:36 ` Mike Snitzer
2020-12-09 23:14   ` Song Liu [this message]
2020-12-09 22:38 ` Mike Snitzer
2020-12-10  4:09 ` [PATCH] " kernel test robot
2020-12-10  5:33 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03EC7F7D-DF6E-4962-BBA7-FA554509C2E5@fb.com \
    --to=songliubraving@fb.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=matthew.ruffell@canonical.com \
    --cc=snitzer@redhat.com \
    --cc=xni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®