From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB9CCF9C1 for ; Tue, 7 Oct 2025 01:03:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759798989; cv=none; b=Hsf/0VaH7pLBk7ofV+jorWTccNyW7dERzoPwoeSRwzwdxjHYDm8AAsHc+FXKBzXsihE8UkRwLAVMeuAihOssaFsmOGswCZsTUj1oUhBCU+x9ysS3RN/SYyFPF/RxjyxiIeHsyLks2C40s2IGZcG1gj6iho9Eb9OuHcN1t0MV3qE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759798989; c=relaxed/simple; bh=UzFkx3V2abUc/caTx+es4GrOpbz+tlZiDJJUXkho6gc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CjuGLMf+j9rCCaLMHKbZ8pT55hyh4xEDvsBZxRuonOUQ3u8eYpkSaIOxp4qQaoZqczcnjKlnmymZSjPwkYHG+SkXEvPP7JNVgOnxmvR4JZt27D+NzSHGOZwTa86Hn+0iQwxLazlR2fNTq1C0/dMR41SCSJMvOLVPX9xbvv+HMus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CdlW7SjD; arc=none smtp.client-ip=209.85.222.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CdlW7SjD" Received: by mail-ua1-f49.google.com with SMTP id a1e0cc1a2514c-8eafd5a7a23so2590423241.1 for ; Mon, 06 Oct 2025 18:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759798987; x=1760403787; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8SBkp7v3+iaIFjg2UJKNokAvDTy3nHBsuuGSn7XWGZE=; b=CdlW7SjDHjoBM2V1yMrNF2PRNUFEX6oPGJcEZyiPvnAhcl1/DrPkn4uICGodLURs+w bEhe0VLKgCbRmzRR9BRszv1GFeB0BFwyfpDn2b9brarePKmjQ3xKNmIBlaiW6oyWxOmN c4kc3mOZfRf2+/ZF8vwPSfZn3r0a1kgtjQEEbUPmjVMTzd3pCU/GyujKY1PjnU/hO7Gv 4/0+xNOTM6ZtkN9/qGHWirUaaVxH4KkWrUNOTkMrO4ohfbiZIwjEUs8BBDisUp4WyHjG yvbuwMO9YMUQT0rVVFA5qpnW42aeiAu+XS1Nu+Vqag3v3fHT5x6XqHpDYc59oII5LRtf tRyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759798987; x=1760403787; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8SBkp7v3+iaIFjg2UJKNokAvDTy3nHBsuuGSn7XWGZE=; b=ddWFXAcsfYG8cU0rG95dEhPqZkuQu8Kn1KBvNSQ/l2j2gPA6yFzhjV7lSUMS0bWvtN ak4J2t9Yc3cOg8Y6lADT5y/rlT94pMekccoN7qBso5KkFla+/JOCzTMtRBqlwA8voTqT 9OplR0qPPO/enpKACBk9knbWdhIfTeHhdAPou0SLEaid8pUcylLtPytNPjsq/S/K1n8v yrEV/sDLD050TBMBpABlk1kBe8GqkRnHFigH58pSa/ZD1rSd5oxo5/WAgEsX78rcT9uu ZGwCPo5A95ygW1Sbas4of+wBTOjwbxcR5mLDAcVnzD8zM36uJnNeBUre5IPciULgOPuQ WDkw== X-Forwarded-Encrypted: i=1; AJvYcCVa/pp0UjdRa9B1TY/72NTnX0ufgfHg+kM8zhyJvCSphMy0sZo19ZK+g1uI7w9ccXx/jACV2DmSCBCMTuQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzPnHH+lv42WvVj7W0iJMGRrJ5LudkJ6iqRkrQGc8qLce+SQgBj 16d85lTsYhkHrZT4q55JnZjFk2PjEOVjr5cm+q0T+Qd97gLYPT2KXmQK X-Gm-Gg: ASbGnctogLZQEGQbwVDc2oA70g6GJl9s/6d6DVqg5nENrLot7pbv4+PwO5ZhKd/L+RJ vNdsW9NnN8BpNxk3m6Nn+ZPCw30rnxnTcmrf84Y8eBxbWB9UU/zkhVUDbJ8Yca4V9qEcIL6WMdx lx4yODeZCP6zIEDT5kHxF0qcyKVZtYCGhKqT0ldAs8GU/5ueY7o6vSmv3b5zxA5UO9s7F7o1Fw7 YeA4Yw54sxhb9+VE0L9VrTemoegNRtu9V7yzlvLfBy9LirElKfZCgRy/yGwbyPpw8mxUxSyzPPD 5HmwXs7WtNWgKDU/mN8vV025kTQTawDMmjdl6zb5EIWbooCTgY7E1l6t5UTPQrRG2eTinur0wLP kUzLIZdqebLUthEybEYjiO7zgoRoCKeXk4+j2kJOE4QiBprb5BywsxrQB9pm8cAuwl7obcnSGRQ == X-Google-Smtp-Source: AGHT+IFKzaGjI5KF3o8XjbsbEV/y+PYj4yekSF7is/jJyVeOW5Z3tWkcMSrolqH6JqxaNt8Zy5fevw== X-Received: by 2002:a05:6102:160a:b0:5a4:60ff:80c3 with SMTP id ada2fe7eead31-5d5d4d401aemr672803137.14.1759798986666; Mon, 06 Oct 2025 18:03:06 -0700 (PDT) Received: from [192.168.1.145] ([104.203.11.126]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5d5d383430asm419000137.2.2025.10.06.18.03.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Oct 2025 18:03:06 -0700 (PDT) Message-ID: <03a4cb5e-85da-44f3-8fcc-67e23920cd5a@gmail.com> Date: Mon, 6 Oct 2025 21:03:03 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: serial: fix: space prohibited before comma separator To: vivek yadav , Johan Hovold Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev References: <20251004065618.70151-1-vivekyadav1207731111@gmail.com> Content-Language: en-US From: David Hunter In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/6/25 13:54, vivek yadav wrote: > Hi Johan, > Thanks for giving time for the review of my patch. > I understand your point and will avoid such kind of practice. > > > ~~Vivek > > On Mon, Oct 6, 2025 at 5:42 PM Johan Hovold wrote: >> >> On Sat, Oct 04, 2025 at 12:26:18PM +0530, vivekyadav1207731111@gmail.com wrote: >>> From: Vivek Yadav >>> >>> Run `checkpatch.pl` script on path `drivers/usb/serial/*`. >> >> Yeah, don't do that, that is, don't run checkpatch on code that's >> already in the tree. Use it on your on patches before submitting them to >> catch potential issues, but always use your own judgement when >> considering its output. >> >> If you just want to practise sending patches, changes like these are >> accepted for drivers/staging for that purpose. >> >> Johan Please don't top-post. please look at the following wikipedia page to see what top-post means: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style