From: Markus Elfring <Markus.Elfring@web.de>
To: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
linux-pci@vger.kernel.org, Anand Moon <linux.amoon@gmail.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Bjorn Helgaas <bhelgaas@google.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PCI/pwrctrl: Propagate dev_err_probe return value
Date: Sat, 18 Oct 2025 18:05:36 +0200 [thread overview]
Message-ID: <03a8fd58-cce5-4b84-adef-6cec235c582b@web.de> (raw)
In-Reply-To: <7b153f5f-fbec-4434-8d07-155b0f1161b3@wanadoo.fr>
> > slot->num_supplies = ret;
> > ret = regulator_bulk_enable(slot->num_supplies, slot->supplies);
> > if (ret < 0) {
> > - dev_err_probe(dev, ret, "Failed to enable slot regulators\n");
> > + ret = dev_err_probe(dev, ret, "Failed to enable slot regulators\n");
> > regulator_bulk_free(slot->num_supplies, slot->supplies);
> > return ret;
>
> Doing:
> regulator_bulk_free(slot->num_supplies, slot->supplies);
> return dev_err_probe(dev, ret, "Failed to enable slot regulators\n");
>
> Would be more consistent.
How does this view fit to the commit ab81f2f79c683c94bac622aafafbe8232e547159
("PCI/pwrctrl: Fix double cleanup on devm_add_action_or_reset() failure")
from 2025-08-13?
Regards,
Markus
next prev parent reply other threads:[~2025-10-18 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-18 7:02 [PATCH v1] " Anand Moon
2025-10-18 7:31 ` Christophe JAILLET
2025-10-18 16:05 ` Markus Elfring [this message]
2025-10-19 8:16 ` [PATCH] " Anand Moon
2025-10-19 8:56 ` Markus Elfring
2025-10-19 10:19 ` Anand Moon
2025-10-18 15:13 ` [PATCH] " Markus Elfring
2025-10-31 8:28 ` [PATCH v1] " Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03a8fd58-cce5-4b84-adef-6cec235c582b@web.de \
--to=markus.elfring@web.de \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=christophe.jaillet@wanadoo.fr \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marek.vasut+renesas@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®