From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C683D288AD for ; Mon, 26 Jan 2026 16:19:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769444352; cv=none; b=TksX55tokRdhttimH1d2ps7hWc3iMrTf7DtIcLiOODwYXP+sQRkm/YZLm6LxPOYBME7KChpKHdsxjFY8gD4SNzgJgvmqCf7KbKGkJNQiKXsmi0e8sFeW9hubdkdmAXAfMDzzUkU9hnr05rIfyNPp5niYFsoXYGXBFo6ta/8CdMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769444352; c=relaxed/simple; bh=lJr+9LjXijVG2L3doiOysGn3q8Yh/YioTMPp6/ZPQOI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ct/cmjQjxOMMQaeiQrV852uHuZsvh9iXvzVgjob1ys1rrq3EbH4IJdENj6uKWCRy2O/aJ5xwNNrlCdu6Nk52Gk0fYapuMA5fRlPGusz05/R0HFPN4fiY5+BU++2fUfUFsWCeA4l+DzOpejG2fsJEXpikrInXhV1kVVD0nXgyCzg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RVFL7IkK; arc=none smtp.client-ip=209.85.167.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RVFL7IkK" Received: by mail-oi1-f195.google.com with SMTP id 5614622812f47-45c958d480aso1381429b6e.1 for ; Mon, 26 Jan 2026 08:19:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769444350; x=1770049150; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Re7o1luj0nF8ENFMBzSgQp4htPbrtZUdaJYqDNv3ZpA=; b=RVFL7IkKyB3uSibg7IdzRVOLDoTggaKbr0utLxr9EXoUCCcjH7+tBmWQ2w4G/KShnx POGnFUrzXxFjkYP3qFE+3zuTkHYlGAgpLlBnZWDWMdBtvlVYhH8S95QhNvwJbcq1ESTo d9K2p4hBCGdgyrNSrlugNaQpIX61inCnhvvs9fCxNmVXUOXcBN0wgCIb9SVqJPMXdCQn VhdPySo0/F1GfHjKgHw4ogjgP7ogtu7+fKAkJwe2SaOdYeVq2FTc37VjLcZOU52j8bpx 0woOkJFTvZXLR73NALOTxQLF/WbduP+bNFKEjjAUs2krkeFWcj57STGLe5PNqSJ2cc5w UhBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769444350; x=1770049150; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Re7o1luj0nF8ENFMBzSgQp4htPbrtZUdaJYqDNv3ZpA=; b=md9cz3KwRvA6G6vJcBDmOtgC18sAYhNRQ3+N9L2bJiCEBYBlTuHYM9y2ScAYkN+HC5 mZl0eEg0deGdWoVrbgmHv9dppfR5EQBNpWbC7vhjrB4gDX/A1i/icpsdGUHCsK7JqOAu IY0xKMeczzhHxNt78oSlVMvJna+FaKsf1RT8QBwSOBPVDoMT/jqtlLBTwBC9g4ApS7C4 1pXDhIgue8JNYPgt4F0s1TI4JGuEcBL413LEP+jtkkjGjGLoz+rd1KImZv0zwP67B3RB ZZBZBJefTtz0RUsw8AqqUSgImHo9Z0KD5WpKkWXFu34OV5OM2bZjWOAirLnmSbrVHAk9 EI6A== X-Forwarded-Encrypted: i=1; AJvYcCXKlzI1mB629SAiLWNI8r6yGyG3KEIjnnWyIMDcNDnNrdghf1KmtlkT2LHgoZnDV4typbIytpu70ScUs34=@vger.kernel.org X-Gm-Message-State: AOJu0YzSy3+y7EzcTewyiTtHXuevBB6b4YqEMJDSvpvyaZsp6ArMpl8A 1XCpEkiV9+11HUn/gq43fvOp1s72I++2FKRUPinBMZiYbFNpflm/Kr9w X-Gm-Gg: AZuq6aLTOSEpXyRKTPTWdBllf2xl7fqGfg7EHSF+rHRf+5lyu6NRs0Q9EwlfvDuzxTq bTNVUBSzfLDlTCDVBKI4oo04ElqrY870TNdHB+UE8TL+TSX/S0oS+UtpFSWh0qMhPiiLqLLgWk7 V6rTUkRfaqtvVxJL8Y33T5R0RUZ/sNhxvRnY8IaflzGLY2+U+j8yMqPYv4Nj/t1b1YdFOMHyWa0 XTQGHKdk1mTYWaUskDBx0bXotu2yj0gkqtonB4uxdRonhZssKkksBgI3ZI/ho4ZFJR0x+CqWWRE XMxE6Dx9QiVQ7n+UJvxmizzgZ9u/FMHyQCL2Tt5CSVVeeDFP/2SwsiCkI5RuPwn7hQigkJlNzmg ++YmXL68+K9UOFcyMt74zg3nfT6D34+07Zvntu/OhJh+JHpVhFD0bfjhG4X/KHs/VKfvrAHX8r+ gJO7mFBCH9sDmX9e9ZRpJnG8mF38rxd9EYU8AaYgUYE8bXMHh2ufsznj0fy3PRP6n5Czg= X-Received: by 2002:a05:6808:4f60:b0:45a:8d42:646f with SMTP id 5614622812f47-45ed9a95bdemr2130038b6e.62.1769444349706; Mon, 26 Jan 2026 08:19:09 -0800 (PST) Received: from [172.31.250.1] (47-162-126-134.bng01.plan.tx.frontiernet.net. [47.162.126.134]) by smtp.gmail.com with ESMTPSA id 5614622812f47-45eb40e32desm5928854b6e.5.2026.01.26.08.19.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 08:19:09 -0800 (PST) Message-ID: <03a91568-d1a0-4779-a465-2788f4765a42@gmail.com> Date: Mon, 26 Jan 2026 10:19:07 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 0/4] leds: extend disk trigger To: Niklas Cassel , Markus Probst Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jacek Anaszewski , Damien Le Moal , John Garry , Jason Yan , "James E.J. Bottomley" , "Martin K. Petersen" , Pavel Machek , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org References: <20260123-ledtrig_disk_-v1-0-07004756467b@posteo.de> Content-Language: en-US From: Ian Pilcher In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/26/26 3:00 AM, Niklas Cassel wrote: > But I'm not a fan of making the driver more complex. > If we want something more complex than what is already there, then it > is probably much better handled in user space, considering the amount > of possible configuration options. > > Basically the same argument as used in: > https://lore.kernel.org/linux-nvme/20220227234258.24619-1-ematsumiya@suse.de/T/#u Niklas - Can you provide some links on how this might be done in userspace? I've been maintaining my out-of-tree block device trigger for years, to make the LEDs on my NAS work. https://github.com/ipilcher/ledtrig-blkdev/blob/v6.9%2B/drivers/leds/trigger/ledtrig-blkdev.c I'd love to be able to replace it with something in-tree. -- ======================================================================== If your user interface is intuitive in retrospect ... it isn't intuitive ========================================================================