From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752368AbdF1OGQ (ORCPT ); Wed, 28 Jun 2017 10:06:16 -0400 Received: from mail-cys01nam02on0083.outbound.protection.outlook.com ([104.47.37.83]:52939 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751616AbdF1OF6 (ORCPT ); Wed, 28 Jun 2017 10:05:58 -0400 Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH v8 RESEND 27/38] iommu/amd: Allow the AMD IOMMU to work with memory encryption To: Joerg Roedel Cc: linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, xen-devel@lists.xen.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Brijesh Singh , Toshimitsu Kani , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Matt Fleming , Alexander Potapenko , "H. Peter Anvin" , Larry Woodman , Jonathan Corbet , "Michael S. Tsirkin" , Ingo Molnar , Andrey Ryabinin , Dave Young , Rik van Riel , Arnd Bergmann , Konrad Rzeszutek Wilk , Borislav Petkov , Andy Lutomirski , Boris Ostrovsky , Dmitry Vyukov , Juergen Gross , Thomas Gleixner , Paolo Bonzini References: <20170627150718.17428.81813.stgit@tlendack-t1.amdoffice.net> <20170627151230.17428.75281.stgit@tlendack-t1.amdoffice.net> <20170628093627.GD14532@8bytes.org> From: Tom Lendacky Message-ID: <03a9d0f5-1f0e-ca0c-78a4-c3a7242f6935@amd.com> Date: Wed, 28 Jun 2017 09:05:44 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170628093627.GD14532@8bytes.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: MWHPR12CA0039.namprd12.prod.outlook.com (10.172.49.25) To CY4PR12MB1142.namprd12.prod.outlook.com (10.168.163.150) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1f9ff0f3-0cc5-4e30-36bf-08d4be2ec8d3 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CY4PR12MB1142; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;3:2l13/1ic0a9x8iNoX8zijO8Ph9p1Nn36bXyNjnXtZGyXSCXVyd6CRal6HeZGf6qVAlvLHcZKb+yrB+i9SmPdpfb+H7LAs08EzZcCiaf6IyvzX5bvXTt1h3xWPc8jvKlE/vd/Fxg+eGcs8RMU1wuHzrf3BM5L1N2JGGVTSZj/N/uIsX/p7wmWPJrGGBFGsf8Tu3KIdBLF4NT/kbW240MoA/1TFx2eu63kUC3qwCWXbffT/8qs+Do3zqUDLS7TNEaEA5ktcvE89bLe9McjaJ3naACrc8NjVPgVzqJVJY+G5HunllRBPpZnnAIv7Lpq7PKicYlTI6m0UJG6SrHNhEh81DMVOW2inWNLK0CTASr0diOOBZ1RGY8cG7kpxcvwtM5c7BvjcQrYLUBrmnne2Df4MaIoiR8Pj8lO3Fvr89dBzPEcyMwkI+i5rnPT7OTiSZ700jrNdUlaQUu5sRn1qPv+6iL762twJWIZRZwkMPmiZfH2EKxZYNfM/GeFsfiBQSpklYXwtF4JTL8+Gz0aRcZlFAHMOACycjEZ2BhaMETB0REBC+UWtKzsvVXOSFRzd/Jlgf0On8qWrfgUeEHUPUgSaNf+w6eP3O6s9Qfvz7JAiZWNhg9U0m530xWYiAr1V/1ETo02P4uaBYbVrrMMLvO0/+sqXFEzo3LSHumvRBWW6RXhfd6AVl4w0POraUaFtGZsgbNMN1GCm0EVftkCmGlg3VXiaV4TVvkILAVIag+xJxSiiimdOuZsiF5yO9s1lXU2rUazJsP7FGGgELHs36evpQ== X-MS-TrafficTypeDiagnostic: CY4PR12MB1142: X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;25:AiWrYJ0cEVrOW1R9ztZSePFPtpo9ixIl/NU0X4rbJ2/xp/SgqlPmc8BdI1nP16i9O+t6p3WYrde97NBgb77892NYIFgeujDn/a8Cb1AYW/lELZQuKm67R7Tho49Qwm2qe0MSm+gww3bHRegzClasJgtEdP8hwOCN/DAEd1xFBzUa5o5Myhd56OP55rNnDjJ5mm6T3sfTqvf4XjxWFwAAEfOwkIphJvjKMeJiiV4vxkxAsZVn7ZiuafoPeGGmTXHba3qczI4mD97gQn/ZvqSuQQkYbGGkYHlxndGERuy4sIDMB1/0sfNlLewrW3RPqhbIbIQehsDkTDzueGab194O9fYLwcZT26vhru/yrdfmPp2E/b2uhJRPgfQy5sGSedN+Ry3/7b9apM9696epWuylIPajk9cgMLIsR8466wWsRg2WiOngatVO3ny5u4cCAD6fuORIcVKvRtpHKswtSrBNPjT7BwjZ/HU8EUgBskrr/1/bkPm63PfXtf1UE/rcr+Oq0Yj8EJ6yJyA7pO8dcY8AtRXkecicdJj3L63y7tKy6NmtKGxlmkY67jJ1CqEjg4OPi45LVKy59HODNcd9J1LrT4slMsrqso4cXjA4uQ0hMf3TB2kz8KQJzBg8Uq3yQEcmz6xFQ6uXsQ0EtPFOIcOrnN4iRzp/hugJSzZxflrk0JFs/afHkEiAQG9Eg8AyMPNZj2NGvKCeBqtH7sNmyBt6/HGD5V6GIUES6/kMg//Hcs9b/TPfvy+1CRTSK+JwCPgzyp/rKb7jAsQs2IYUySBURJJL+jlZF5GWRRUWIeml8LygznE9LKWS2BISNigAEqLIqOC/JZKCPM0eek0iVqLpoQvtRDwrYX9a8MMyrwDMQKX2LjwSsiat1q0dPgK8Tq7Vxuw/w6EP6Nwj+bRfWCJW6wrUs3jeihInnD0c2bgb3IY= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;31:L+SOTBsUJuxPqd0HtbNhBiFDT/sUodgVX/PN4Ms93NCi3AoNY7HZ+zDX5z51GPRq7Y1U1Yg3DkbtL2aNrU4opo2gzii670N3aFApJsWwXCSXsIpSPBVdE5E/VfUu3SV4GlDF7zTbpJDd7UvU7fSuYSRReApLAzBHmDlzBnGHghxhsrNfsCOEWqcAE5YoYIncJ0Es80WyGzUuSEynlO3T/mRpEMljEQzvA3Eq4ZPSvtkT82TuV+kbPWJ8Eeomy65RZwy8zhOVJHoWUrljSXnOJdDzFOp/PkjPmmK+V4XsiwmCHVXznjCmrxK4kohUH0gSGZPvWKqs/iT8xK74Fyjw9FCWGpaCHRQ43NTTLns+iC/CgSOYwZ/PDcT14gFrOSq1mtfPrVFzliUB9ySjJK3P9DN1928orAa23jUGDMoJMLBFitw0r0YJmXVzL69qkEGHsPdYAN/JEM9Zs9gHZsC38zJHG/TKp3/wiotbxdxcj1rBuwwevMTK0fbKAuOTnSwGm8NMtcyctzQ0KBPfGQN+mV6uQrk6VvokqCVuuo1Aic34O3Lb/Gao441IaYDHi4R4GVsr/MhQuIw4u/qKUOBfTeJcLo1zGrAK6KTeZWz8TglTs7iLBlFCZ+LG8TU55q+KhiFn05D2J/d8a3XAnlkzkkcrs3uBhgxOnNdhRsrJu48= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;20:wN11Ra3jqXBFPKWEPk2ZjA0GxiRnURGL5JMR9Xu+F/cQc3m2y2N7ea04Bej66s+Rvex/t76QfcvIK492mP5UMqcksIDVpuwcEYaxnP3GGjQNESusCpJhv3vfPxfsw2eIWEa56gd+O1VmD7xy/emhtjrAp0vpuSzEdBkE0+eH4z0wM8BFFVokRYOoIPQs0zrc8WBa0+iaMeq3j0OnkIrk4IUpmCi5GsSFgM1k3PsEq+sZV2K4IB05YSuifLe+NxrRr5Xv6rRQiq0cjAhFiB1u+g3NL1yXTrfotqylBXsBvJFp02LDPoAujVc3pbqwxOUTcA9CUcAQ1lEtVDOvrkcdRaqxflI8NHgS0N49n6qCcxSaRDkNScOWHcTuYkQUr/5pq36bElb/fibddNKg/kHvmZD1DTmDB+tTJCc+h9Mp0zY1uDbuKVp1CnEboSzfhuzhabxrmqdeUv8Gm8Wy+tnsVp5/J91J4PZk4OmwIasBlaXxo3a/FAXiyUjIqY1PlFfs X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(133145235818549)(236129657087228)(247924648384137); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123560025)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR12MB1142;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR12MB1142; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxMTQyOzQ6SllKeWpjNlpnQzBIT3hsTkJIazkwcGFqRFBv?= =?utf-8?B?YUJiazEwQTNMTm5ITnFaSjFmYVZXWjg4ZWJ0cmNLYkEyUlZnRG9SWVl0MzM3?= =?utf-8?B?UThkcEdWWlllUlZjTmJ1S1J3Yzd6cTZsT2p4MUxncDJ2aXBPVFgvc2x6cmYv?= =?utf-8?B?Sy9uL3pFTVMvSVJKNG1nbkpnNjN2UUpUVTJIQlpvSXE5aVdkUzRXZldwQWVI?= =?utf-8?B?YUJBay94M3BNdDN5WmtmUHdLTlNhR0xMT1MwZGdrR1VEdnhkeUxNQ3NWb2py?= =?utf-8?B?UTdIQkRkc25WVlhvL2FWMWFKanhIa0RiTXNtY200bnVyN3dXM2xGVHY3bWVL?= =?utf-8?B?cGhiSHBuT1ByelNWWFhZQUZLUzIxRjlkQ2pxQzN2N3lHc1lsU21mdUVuQ3lp?= =?utf-8?B?US96VU5EZ3l4RE4vZUVJUXZJYlBjbFRGbzJzb0JmVmJUNGNWbkVDOTM2VklK?= =?utf-8?B?Q1RkbVVVcHFVTU5sR01sY2d0Vm1Kczg3MDhJUmJVQnRKZGJsZmdpaThKSmEy?= =?utf-8?B?K29pWWNzUUIyTmR4ME9lTWIvWVNKOWp0aGhwcU1WczhSVHNEaVdxSjV1RmIw?= =?utf-8?B?T2RBQ3h4UWhRdzFQdUVnUXg5K1NEVGpSaTlkQ25iekR1dS9JSGFTdFRseVBI?= =?utf-8?B?SWZ0MXlTZDhjVTg0RnBYSjN0eWRVRTFTcFhaTzI3Mm1yWEIrNWF4NkVYVjJw?= =?utf-8?B?bWlISnZnYXBpVVY2T3dWeE42c3hXcTBJL1cxcExrcGpRZHIra2R3V2ZOQ1hP?= =?utf-8?B?Uzk5cXpVNCtPTTArNHlyaXVjSG5mSkt6ZFA2Q0VjbVUyZi9WV3hJQis0THlZ?= =?utf-8?B?a3Y5Zld6OVRIVlZld3hEUUFEeG1aQ2Q2TlFlQnlweTNPMDFPU3dZeElhakNw?= =?utf-8?B?dTVCUDA4cmFzelNnQVNKUmpaNFd2ODNSVElacGo1YjFJTHc2WUpzRVFrNzBz?= =?utf-8?B?cTI4RVRleGlHT1I5YWJJYkVGTWtCS0lvZk5GZ0JLeEdSZjZEajBoSmpnMTda?= =?utf-8?B?ZnVBODhicDBqMm02RjVIdGUvWUlXSTdyL1hHQjJiT0pxN0VOSHdEb3lGV1kx?= =?utf-8?B?VFJVL1pUUUYxVHUyaEhjbDJjcUQxSENsTjV3c0x2OWtzeHk5OVgxSmIzWWh0?= =?utf-8?B?UkN2MlcvMTd6US9UcGpuMHIvWlhEZTdKYTBVd0hUV05HVEg5MFlUdVlOZ09w?= =?utf-8?B?cEhNZWRwR0EvM1FqcnZoa1hmaEFGaXhzYWxxdExVSVlJSngyNG5tdHNCdXJw?= =?utf-8?B?cEJaRVpSU29CWTFIVUVRcktqM0JrL0Z4SGg3QW1FTURFNGRWaDU0MzRzeDZN?= =?utf-8?B?cDQ4Z0dkbkhqenNnY1VsM2YrYVQwWFlPKzlEYjQxSVpSOERIWnc4empTZGx3?= =?utf-8?B?MzJzVlRydzRINmNHUlY2ZW1hRTF5MTBlY1h0VjNLTWNZcUp4bjBoeXV4RWVj?= =?utf-8?B?Rysycitidm9CVThVY1FjRHNucVBKRmRlUU82cElsZlRKdlV1SURKei9PZDJw?= =?utf-8?B?RU1FMHdTZVVuQ3ZTSXhOMG1vUlFuclBpTTNXNUdjRG5odFZQSnlPdi9JRyt3?= =?utf-8?B?cVV3RFAwQ05qNDVvc1Vob1dsWnZaakFocXVRS3BLaEFwV0Q5enNka2JPSEc1?= =?utf-8?B?Y1EwUXhlVHdSdFFEMTRaM3luSjZqSEtVUU95UXJwMGc5QXEvUVpyUjF3LzZt?= =?utf-8?Q?JJr93+FCh9KKK0V0Cyup0GUtRGtlV1mXYY2EOE?= X-Forefront-PRVS: 03524FBD26 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(39860400002)(39410400002)(39400400002)(39850400002)(39840400002)(39450400003)(377454003)(24454002)(77096006)(53936002)(7406005)(36756003)(33646002)(478600001)(25786009)(50466002)(53546010)(83506001)(4326008)(42186005)(31686004)(76176999)(50986999)(23676002)(305945005)(54356999)(72206003)(31696002)(6916009)(6246003)(6666003)(38730400002)(110136004)(5660300001)(2906002)(65956001)(65806001)(47776003)(66066001)(229853002)(189998001)(4001350100001)(2950100002)(65826007)(7736002)(86362001)(6486002)(6116002)(230700001)(64126003)(3846002)(54906002)(8676002)(81166006)(7416002)(90366009)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1142;H:[10.236.64.250];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxMTQyOzIzOnFUalFTcUlDNDU3dEhsaUlzWnNIbUFlMXli?= =?utf-8?B?TFNERjdqaFVXejVnQ1R0cFlnTVp3UXlUUDJyRzdqUTlZYjZuSDIyZThQVWhQ?= =?utf-8?B?cVZYUE5nMEYyUVVhbk0vMXJDOElydlBGMmx0cVNmOUN6U2Njckh3ZkJrUDVK?= =?utf-8?B?aC9QeElxUkpxWGpXKzF5Sy9FSUVLbnErb2I1M3hGVXZsK09oS0taVTFTZEdz?= =?utf-8?B?VUgzVVBDbUxpcDV3QzZzU3VRY29aMUpqNTZ2bVR4cytXTGhiNkRjblZBZkpL?= =?utf-8?B?aEJLeU8zY3RpVW9ocW04WVkxZUNLdlNMcWQxKzlQY3B5RWhGUHpJV3VrS0Nt?= =?utf-8?B?bVVQTDd1Zm9vYWVkSlh3QWduUnA2MnZiYm91cDZRcmxkWUdlZUs5MVlSOU5t?= =?utf-8?B?WStyUmpraXhtOU5LT2tIOXA1enA4Q0F4MnA5UUxLSjlOamo4K3gvNmFHcTFF?= =?utf-8?B?eUhDS2h0S3JJazk1QVM2TEF0TG5mWkpRdnozaEpHclRoSFZvR013dmNRVVNi?= =?utf-8?B?RHd0azhLZlVJMzBSemt5b3IzUEJRVE52NWg5Ymx1UTZYRGdZT0VJNUFHdmZN?= =?utf-8?B?QjVFenlZUzZyRDBXZGNucWJIaUpvbm9wV0ZaY2RnQUs0d2F2ZnNoeDQwZzJu?= =?utf-8?B?Y3FETHVnTzlSb2JXVnVFMzFrQWhiMWRCQlBqUFRxMXNmN0hkeGgzR1N3Y3lk?= =?utf-8?B?eEg3NzVQajQ3KzlCejZDM0xGOW1hY0VZNE91MndtOThTcFFqblZKck5xVEp2?= =?utf-8?B?Q3ZuQ2ZVY1lDbGFXOWRLRTMvbzlNelpRaEYwZlZvUXk5RDZoSEhJS3BZRjZ3?= =?utf-8?B?RGR5U1FxQ0dHL3Q4THNxR1ZuVjR0Z3gzR3d0NTJtWG5wcy9JRXYyYUhxOW5H?= =?utf-8?B?bFhCb2Y3VVhMMExPb1V3MFVCVHhrczJ1NU1waEMwWHZ6dUZRcnpSSDhzbWpP?= =?utf-8?B?by9SU3A5Y2xNTWlubURqejQxa25oa3NVcmNIZUJIdTBzRmRJUXNUdFJaT0lz?= =?utf-8?B?YkdRTmdLNHdJdXJBeng5dU5aYjV6L1R4WkYwcUtrMFZuc2xENWdibDYvN005?= =?utf-8?B?ZmxiNjVDMSt6TkhTSGxYK3hZUkt0TEg2ZmgyNnYzSnFTenlvZkFvc2N2MllG?= =?utf-8?B?cmZQNlZMRklYN0J3c04rN1FPZXdXM2R0TmIzeXVvaHF2WUJDQ1dVUUVISHlx?= =?utf-8?B?MDR2OUpVRUU0bWx3SWpOTDRjVzlYaHFmOVZmejg3NUxBcUVJVFp3YjVqVE1x?= =?utf-8?B?WTUvMXIwTzVIQU9xbnl4VDczaG9YWkFqb0VpOHVrWGtYT0ZIK0NZOGFnODNi?= =?utf-8?B?djlwaUY5YlRhRGRLak9tUkZrY2R2UFhtVXFlS0Z5bkRJaVlhWDd0b3lWcGgw?= =?utf-8?B?L1dreWJCQjhhVjdiMlo3b1FwOVRjQ3JJSDVhR3h6WWM0RVlpOXcvZGY0RnJl?= =?utf-8?B?MGowSWp2NUlWdThKSmx4eVRNejRUejJ1Zm81YmJER3ZrOXpEYVgveFNsMkYy?= =?utf-8?B?aGpRdWtBQzdxdE9ZZ1d3OVVUdUdPYVFnN09LdHlmdmtPWVZiOXhoVE5UNUxG?= =?utf-8?B?OGt1SHgxYkdYVXRTM3RFd1RaYklQSXZ1dWY4QTNySXdIV1ZTZmVEcGhGb0RB?= =?utf-8?B?UnJvSFNqNGlac0EyRnlyRE9aVUV0aExJRFRMVlhvTmlYTHU4VGhKeXFKaUdE?= =?utf-8?B?LzNrenlaSlZ1VWZOMEtiNm40R2c1c0pnWkZ1ZXRvRWQzaHZVbUoxalpyemVs?= =?utf-8?B?RVluS05PMkVGSWh1OXhFbjNCeGo1VkFUa2RpVWVkaDU2NHF5SzI0V2dybjAx?= =?utf-8?B?RTQvSVFMV2VlNTFPcmhYeTlUWVFIN28xbHhuS1lzZTFBbHNFWE54S1Z2ckQ1?= =?utf-8?B?U2kreFprTUpMdWtraXhEK0JWNHBIRUx6MmxTa2NwWTlaUXUvMW1iV3dldTJY?= =?utf-8?B?VGlYYlFLY2lLS3U0RDRlNHlqUi94NEZRdVI0NmUvRlMreDlhTVhjaDJKSkVy?= =?utf-8?Q?W4GSzq?= X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxMTQyOzY6ZFhwQWt5cHh3SXlKV21wZDlENCtUUnJEeG15?= =?utf-8?B?QTJXUWszb0FpbFh5NFg3M3I4Qm5XUEc2Y2NvNUdMWDQ4UGY1d1dFZEt0VGox?= =?utf-8?B?Nkpqd1FDTmVXWEVscmg2WWdrQ1JldzZIYm9KWTIwbjdZaEFZMjJtSnlWMHly?= =?utf-8?B?WnRFcFR3NkFZR2tHd09XNXl1SDNXbHVtcGZQdmxSd3FNd21ncFNkUFFGOTI2?= =?utf-8?B?Rm9jKzhpVkRTTGNyUEo1TGJYM0d5R3pTb3R1WFUzdE9EcGtBR0w3SVR2VmZ5?= =?utf-8?B?OStsUXExWTR6QUszdGVOUHYzWlM2UGY1bldCVWxpYmg3aVpJTWNvVmR4bmo0?= =?utf-8?B?eG9zUEJJRFk1SDg5WkJXVVJQMXlNZnBORm9UTnhXOS9MZnJUeWl5WDFtRkdK?= =?utf-8?B?SkFveTl0dUZOd2ZhTE9XSWE5OGRxenhiZTVxYm9YRlBBV1RlaGlGTUdQUGJN?= =?utf-8?B?MGhlQm8vV1FDY1RYVktYRG0wb3Z2WGZ5OHdmRkhrREU0N2RHalBBSXNkc083?= =?utf-8?B?UXBGZWRDWGhkVkZ2SXZkUFVYTDArZzRIRmNvMmY1cnlldXI3a0hUQ2pKNUFH?= =?utf-8?B?KzlGU2lJRmxDcjhTNGJxSWUzYzVuOUQ3S1VPU0Y4NE55bnF1ZEpqMzlBNk1K?= =?utf-8?B?N3pueEd4cWpITUIwYjFxTll3Z1pCL2sxODgvNVJ5bnM0NnJ2SWlFU1ZCV3Fu?= =?utf-8?B?UTc5NVdPQWxIS2d2b083Nk9VbkJ4VmhuZ2tCTkMvYUZzRTRvRld5M0dCRk83?= =?utf-8?B?dWJGWUFxYW05bVlrN1hLdytEUnMxOVNYOFNoYzJKOTROQ3g2MC8wdCtOc2NW?= =?utf-8?B?NmdVcU5zRGxNQ3JJYUVGbStxZk9JQ0ZucGsyellIRWlxb1lyVEhRTWcrWDcv?= =?utf-8?B?ei9BclNFQWNEZmt0a2llYTRqMG5vbG82dDlaeEdpNTFEaGo2Y2E2T2kxWmx6?= =?utf-8?B?L1VFRS9DWTZBait3QkJ0SGRIOWEwNFIvNUZjSzRIVEpnblFTUERuRGxzbWxq?= =?utf-8?B?VFJjT0dKbEtMRWk3ek5ubWU2Z0s3RWRRbGRIMGxNWldvUG9UWGtCRnJCZmpr?= =?utf-8?B?dUlwUUcyUkdSSDkvd2lPUFpML2VQVXRWWjMrNnVIYlJzZWdtMUZPeVVpdUtu?= =?utf-8?B?bHhzalJxenR3aVg2S3pOUlJsenFqSFdHMHZqSUtXU2JhN2YrMUY3aC93cDZ5?= =?utf-8?B?SU5OejVaQTZ5bFl3TWxkMHJVc2NJanlVZmtTbngzc05ZeXQrL3U2YjZGZnJz?= =?utf-8?B?ck8vUmwvdWVGNFZ6MVNQMlNOZ0hwNWc2cHI1OFFZMTNWenhqUlpTYzQ1U1pE?= =?utf-8?B?UWNTOE1FVzRHcnBlUTlOc0tpdEVqZEJVcFBYZVhyQVhaVjJyVy9qNEN0VWlo?= =?utf-8?Q?6Ycuuec?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;5:qu0Py5TaPHH1w0afwqCt6TDoYBhlvlADfEk03SGovndjXZtkfnjKbG63C7cfvqFd528x7T3Ox1r/lORCsEWDt5Az7yMgDBzECoYsxaPEQAZX2MTQ7qJubPNpBseDthXwa8naMM8jdDl5cB3WQJWTBg7t2AUP9nsFVy1V9eqW1u7Xa4i9fAlIxWQh7ZvdcSj/UTDg4CaQVkF603Jxkztyx0zKwT/99kVv4c5aM3crINsExE8Q4CStLY51GOTKHN8DsmjAFrx8TFX2l5hujLbH49iH8DBE9fwH2s5Ss9vKeLATLYExk5eeMHs7sVqbJfbS1UZ1GylGcyQhODF7HwLTLsKy8aLuHW1bNYiS2Xw/2fECR3J8mFeqgt/tbUf4epp7GVzVl7Z/r0Fs3xy5dEkivT5a2MxGeLtA+GgkXLp+Wnd6N0ipr2woGge5x0CYL1UxVJqNXtuwjFcGXtrOOopFkuv9nHZb5zWno7+tbhcOLMkn3HYlcjmcq/jIEh+F4SDn;24:IS1sio62h3hV+y2RLQqHiRaK4Gl+BJHIF8SmOP8IcNRFN0bW6AX5L+2hRJkFrHL8sBiSjMBwkOqyfaTcpGhU1D+ETIYhnhBqWDmmgiMqMBA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;7:+1PXCK7RscpRLFYBRkyy5IYvpEhN++EmHqArrDl/xxNwAyvrRNEkS4eM7IO5+WWhB9/oJm1ihnZYvv7kwY/TS5Ouu7nJvb5fH+eq76baPcbTTdFZSvvgmjl+Hy5Ul02CV6RLgI241yumqcO2/+9cwoeNLLcl2QU5CePrVQeZ75zWNoAbo/IG9K8FDgZaQbeL+tI0dRVnmEcX1jbVOL1b0QdZvTC6Bb65O+yjCNBNf6cviUYBvVvbKBJpEBKESouUSU7KfMKyMsTtzDQNMdyL1jx7aSOCQSndxqBojh4osqcoAkT0LV12rp1VGWG9fYSe/2vTtQXV0ey2B7NaZnpEkeLwBsy/TtYU7XW0X/SxZ9CILAbrs+g7i7A8tRqzn6UnuaE76ZM+xEXw17Q+wqI+VlGe2WWro4kaEu15squKEZiVnIzhXWEF1NiZvNGH1vs6ABoVCyfhyCgXABgKhy9TsoK1L1w8qppgJ8rKhsqMcOriY2T/BI47h1puN00ksRBB/9bJVm2S7397wK9I7B8swQD6NooiBiCjsAniwKqYUvVm/K+yDK0nttHDaI4/OdXp3yHLgTbbpNn044fFIZEUPIkWbnyxqEBASDWHlXodqCrzRKXthr4SCePLT/Nyb9sERSmTIILjBIxSAUIl1ieWYX4aW17B+0tmP2h/unWIMKavD7awmk0RRumJ8VmQ6QawOWN004v7a3wa+qjdF6o4QXio7QMzMlwceph/ZPvn5nQyuBWg5yhghAFY1UNpIJafDgIcPAEDeCFAnVBDscFMgbM5MplYnW0gp9CF3lvedrk= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;20:DY/gTtzeTJyMmKtFolh5YFt/oIAirOAH4V1l75agnQiewqHuD786X3c0VL80xtag/tpIbMF8hquCHDX+yXRAPO4kLW9tSeSMo0Jv8kEeQiUADFDHaivjQq02OUMco87VqooctsVfWclDmALhs9xuAz8lKyX10TUypIcBwdPBWq2aegAVGp8YqdO3mtPmrXOFvGRtkroM0YzSpwaa8tRfo2dpYm7IlX5XjSvQJfEfATJUv8h1dsJD5bMCgfsP3svs X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2017 14:05:47.8765 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1142 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/28/2017 4:36 AM, Joerg Roedel wrote: > Hi Tom, Hi Joerg, > > On Tue, Jun 27, 2017 at 10:12:30AM -0500, Tom Lendacky wrote: >> --- >> drivers/iommu/amd_iommu.c | 30 ++++++++++++++++-------------- >> drivers/iommu/amd_iommu_init.c | 34 ++++++++++++++++++++++++++++------ >> drivers/iommu/amd_iommu_proto.h | 10 ++++++++++ >> drivers/iommu/amd_iommu_types.h | 2 +- >> 4 files changed, 55 insertions(+), 21 deletions(-) > > Looks like a straightforward change. Just one nit below. > >> +static bool amd_iommu_supports_sme(void) >> +{ >> + if (!sme_active() || (boot_cpu_data.x86 != 0x17)) >> + return true; >> + >> + /* For Fam17h, a specific level of support is required */ >> + if (boot_cpu_data.microcode >= 0x08001205) >> + return true; >> + >> + if ((boot_cpu_data.microcode >= 0x08001126) && >> + (boot_cpu_data.microcode <= 0x080011ff)) >> + return true; >> + >> + pr_notice("AMD-Vi: IOMMU not currently supported when SME is active\n"); >> + >> + return false; >> +} > > The name of the function is misleading. It checks whether the IOMMU can > be enabled when SME is active. But the name suggests that it checks > whether the iommu hardware supports SME. > > How about renaming it to amd_iommu_sme_check()? Can do. Thanks, Tom > > With that change the patch is: > > Acked-by: Joerg Roedel >