From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE36633D6F9 for ; Tue, 3 Mar 2026 11:56:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772539003; cv=none; b=l1Xk8/yzTZXFOOApOG0XgIvNCnVcFxPmMXtl1MD6to4iqjzm5ehKbRmRp6VHv95igIZ/E+Vkv1LSgo5WWk66xjNpOKFwnYw3W2tyf7vqGTwX+RzilIeUAe69NB4N4p3w9s1EWOIiaou89yKVr4I+9DtvfTr+92CqqmurkJgW3nw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772539003; c=relaxed/simple; bh=A/NEFi/PBYeAOmB2KG5gxaOCCxGsrdsftJAmATm2mHg=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=DqZDUtDseeUrE6ymxS1XykITbhe7XeD9bftTm28ff4zgbr5ftaafn8lcgqnLOr0g5U/+7q3c2wf2Nxuk87tPhJYzU0JZGLBDhs/erRheHkT5jW3vbjXMc/Z7Wdi64aKd1Fu6grlxx5fEpzPizFYl1poM8Gj+3Bg/TH5Gdu0z+/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cBBlG38o; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=NX+11DLJ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cBBlG38o"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="NX+11DLJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772539000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LLxBnAuISZ3YGJZFcr1hGO+eIaLFeSdfs24D7Pk3tSk=; b=cBBlG38o24gwvlx6FBrfP/2pPslXkBaLoKYCfYnkG6QnIQ+9Gly8aXLDH/+I6Dz4VzVjjC 3Y3QQBH73uGWHtbttkRVFvkapHCbagjpw3MKHoefSj9igl+sT1FLnW8L+UdadlXF1KXP2Z bCulrS+pQ7xHGUPtgQO3154YMLk7lNU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-M2a5UfTLNTOHbP_vP6CzKg-1; Tue, 03 Mar 2026 06:56:39 -0500 X-MC-Unique: M2a5UfTLNTOHbP_vP6CzKg-1 X-Mimecast-MFC-AGG-ID: M2a5UfTLNTOHbP_vP6CzKg_1772538998 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43996fb9cf9so5072199f8f.1 for ; Tue, 03 Mar 2026 03:56:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772538998; x=1773143798; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=LLxBnAuISZ3YGJZFcr1hGO+eIaLFeSdfs24D7Pk3tSk=; b=NX+11DLJrrxZJlcGoCC31j0K7UYI6qxhyb0/8P/ZPKYy9mwE8FDh5Xsfg9+MhfWwnl m9XLi/QIoQxuhoxKJ8k0x1HVhVEkGH0/kvRu0kc7fPEAiH1kdyyKCmbwasLD72BjuuZj nwj5jyeEtuG5ckCJGi3DtF1ozhgsKPVBsMi2Dlrfxogj5g++MY2NqI4KDlQMIMVn5bKE 1wGF8treA0g0m8Pf9KugVOmo0uJlyoa4OFQ+chxoY5JDiGjG7jUz7imEFrY+raTCXlxR vwdi+nPqX3o4PnLS0PVHADK5LzmTOUCCBD8RApDOb5KvqVaRn5bBlgmicpsZjuMsaiV6 u+Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772538998; x=1773143798; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LLxBnAuISZ3YGJZFcr1hGO+eIaLFeSdfs24D7Pk3tSk=; b=e2J+EYHDdcXXVLb/mf4guQcePWfYc2i5DdV8zZXfqFKHFjLIDcaduRMbkJaTxHX4x1 46oKnos07stk8qJ2AA84NV5Y9/QoSpmWAC+ACDtwzBxRGoADYy6BeJKU27UlLSrOkPjp un4/PEfigaJP5GXdAUqCIecDOnbvgvOTzLXemKc1zn7FwhKjWkdrjgFw/yzesVaCfC2r W0brcyPGyLauzHEmnPBX5CN8hDsk/iDbKdrBLMNUNIHi1ixU+yYmpvbQ/+Qh7aKoPy6Q ngR5mIneiaPWawdkxwsunzfuPqvrNXuh+PWEDxFp8LS3hLtJ9FfUeOQLjyPJSMWRlPnV Xwjw== X-Forwarded-Encrypted: i=1; AJvYcCVkxkjM/08u/zT5HFZlsfjYrFYRQfJhowaEx/gITDyOryNYtRQwoC2kqrjgaiCJjJudq49nPqmUB/diY3k=@vger.kernel.org X-Gm-Message-State: AOJu0Yxp10UNwYAtIkBlp1n15zp3XIT5fdfD1IT+JGSEOQ1xj1Ga1qTw 8DbpLurhKQ/4d9az1bk0PiwH8nFIf0Otl55hMy/kiylX95B6SOBba1lMMFoVPdZtaZziYHn1kBC k89oztMsq+YQ34DGCisw84XxyCFU+uTsuVR+J+cHdAkpHwDTPGjbuwWlq4RLyzZq2Ug== X-Gm-Gg: ATEYQzxIZcqaajdA3Q0QjPoVrU3QrxZBrmZfVp7/PC5d/plqWCBAa/T4/pUump3UoN4 NV+Ghd9Z8MBXPnryDWjt7fakYEsPDudOh62Do5lfIJGKh8l8ljvtMHNsrl0z1yw4btMARi7HmIC N76LV2IsYbxCRbxhcAF1k4sgWJMiKAU+hpoHxy6k3DihyVwfzEuTewzbWSbuzTngfrh+CVlcao8 W3T7X6Rx3sq3tpTqlPHKT+kFNx10RwjvTqAfBCaIdfnJ9Y36WuMs9dRomuImTHpOFLjJmqajRIE /o4OMChNVRwRhPUSjBUdswRbaM4KynbcU0/hWymAlHJFfvOhX9AgUBozMHzVJ0tyZn24XAtlgkm NpXMLv84wokhSn84IQb9ycjD0 X-Received: by 2002:a05:6000:24ca:b0:439:b564:7a6c with SMTP id ffacd0b85a97d-439b5647fa6mr13229270f8f.4.1772538998375; Tue, 03 Mar 2026 03:56:38 -0800 (PST) X-Received: by 2002:a05:6000:24ca:b0:439:b564:7a6c with SMTP id ffacd0b85a97d-439b5647fa6mr13229226f8f.4.1772538997874; Tue, 03 Mar 2026 03:56:37 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439ae3f31dbsm21348530f8f.1.2026.03.03.03.56.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 03:56:37 -0800 (PST) Message-ID: <03ac38dc-69c5-4641-98ea-5679465c0b7f@redhat.com> Date: Tue, 3 Mar 2026 12:56:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: mana: Force full-page RX buffers for 4K page size on specific systems. To: Dipayaan Roy , kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, leon@kernel.org, longli@microsoft.com, kotaranov@microsoft.com, horms@kernel.org, shradhagupta@linux.microsoft.com, ssengar@linux.microsoft.com, ernis@linux.microsoft.com, shirazsaleem@microsoft.com, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, dipayanroy@microsoft.com References: Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/27/26 11:15 AM, Dipayaan Roy wrote: > diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c > index 91c418097284..a53a8921050b 100644 > --- a/drivers/net/ethernet/microsoft/mana/mana_en.c > +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c > @@ -748,6 +748,26 @@ static void *mana_get_rxbuf_pre(struct mana_rxq *rxq, dma_addr_t *da) > return va; > } > > +static inline bool > +mana_use_single_rxbuf_per_page(struct mana_port_context *apc, u32 mtu) > +{ I almost forgot: please avoid the 'inline' keyword in .c files. This is function used only once, should be inlined by the compiler anyway. > + struct gdma_context *gc = apc->ac->gdma_dev->gdma_context; > + > + /* On some systems with 4K PAGE_SIZE, page_pool RX fragments can > + * trigger a throughput regression. Hence forces one RX buffer per page > + * to avoid the fragment allocation/refcounting overhead in the RX > + * refill path for those processors only. > + */ > + if (gc->force_full_page_rx_buffer) > + return true; Side note: since you could keep the above flag up2date according to the current mtu and xdp configuration and just test it in the data path. /P