From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBE213D3BB for ; Wed, 21 Feb 2024 09:46:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.255 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708508772; cv=none; b=slP1hv1HO85uwLzM5bFCog41MxUQ1Z+CpAOUTnH7x+QhJgyxGocp/cV+AMufLM0jou0XVmMD3GxU3DwNIDcg+ZMzdyezvGMoM+RX7vIR1e592bSpCARfEVTOyRqcFSz/QbKs4o2TDEp7afPUgjFULNPfgB0uidRw9zHpo6QWpUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708508772; c=relaxed/simple; bh=DSOCctHCmNn4Fne1Ro5IcslS2936SkICNdDghitRmMU=; h=CC:Subject:To:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=caMvDZhWM/+TuAe4gX6i8ttezkd3mPKJ3ypGrjQGEE4vzBYiEAcMekJCksF94B7VOwhg9asgQqCZyQBPBjw3Qonoj00POecLoCZahLWExschSMOUKtH1sTixibY5A1f7adULmXOhMh0tRj8XPVmzlB/0sywledNL2fQydVZB1l4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.255 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Tfrvw2xHNz1Q8tx; Wed, 21 Feb 2024 17:44:28 +0800 (CST) Received: from canpemm500009.china.huawei.com (unknown [7.192.105.203]) by mail.maildlp.com (Postfix) with ESMTPS id BAE73140429; Wed, 21 Feb 2024 17:46:07 +0800 (CST) Received: from [10.67.121.177] (10.67.121.177) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 21 Feb 2024 17:46:07 +0800 CC: , , , , , , , , Subject: Re: [PATCH 4/7] drivers/perf: hisi_pcie: Check the target filter properly To: Jonathan Cameron References: <20240204074527.47110-1-yangyicong@huawei.com> <20240204074527.47110-5-yangyicong@huawei.com> <20240208122902.0000768f@Huawei.com> From: Yicong Yang Message-ID: <03acfe6b-bcde-8a11-ea6d-add1998d5bd1@huawei.com> Date: Wed, 21 Feb 2024 17:46:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240208122902.0000768f@Huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500009.china.huawei.com (7.192.105.203) On 2024/2/8 20:29, Jonathan Cameron wrote: > On Sun, 4 Feb 2024 15:45:24 +0800 > Yicong Yang wrote: > >> From: Junhao He >> >> The PMU can monitor traffic of certain target Root Port or downstream >> target Endpoint. User can specify the target filter by the "port" or >> "bdf" option respectively. The PMU can only monitor the Root Port or >> Endpoint on the same PCIe core so the value of "port" or "bdf" should >> be valid and will be checked by the driver. >> >> Currently at least and only one of "port" and "bdf" option must be set. >> If "port" filter is not set or is set explicitly to zero (default), >> driver will regard the user specifies a "bdf" option since "port" option >> is a bitmask of the target Root Ports and zero is not a valid >> value. >> >> If user not explicitly set "port" or "bdf" filter, the driver uses "bdf" >> default value (zero) to set target filter, but driver will skip the >> check of bdf=0, although it's a valid value (meaning 0000:000:00.0). >> Then the user just gets zero. >> >> Therefore, we need to check if both "port" and "bdf" are invalid, then >> return failure and report warning. >> >> Testing: >> before the patch: >> 0 hisi_pcie0_core1/rx_mrd_flux/ >> 0 hisi_pcie0_core1/rx_mrd_flux,port=0/ >> 24,124 hisi_pcie0_core1/rx_mrd_flux,port=1/ >> 0 hisi_pcie0_core1/rx_mrd_flux,bdf=0/ >> hisi_pcie0_core1/rx_mrd_flux,bdf=1/ > > Nice to include an example that works for bdf > hisi_pcie0_core1/rx_mrd_flux,bdf=1,port=0 > or something like that? >> >> after the patch: >> hisi_pcie0_core1/rx_mrd_flux/ >> hisi_pcie0_core1/rx_mrd_flux,port=0/ >> 24,153 hisi_pcie0_core1/rx_mrd_flux,port=1/ >> hisi_pcie0_core1/rx_mrd_flux,bdf=0/ >> hisi_pcie0_core1/rx_mrd_flux,bdf=1/ >> >> Signed-off-by: Junhao He >> Signed-off-by: Yicong Yang > > Clearly the current situation is wrong, but perhaps we can > have a more intuitive scheme (could be added as a follow up patch) > and have the driver figure out which port the bdf lies below? > > Maybe that's a job for userspace tooling rather than the driver, but > the driver already has verification code and it wouldn't be hard > to not just check the rp is ours, but also set the filter to specify > that rp, or maybe just set the mask to include them all? > To do a check should be simple, we can decode the bdf and find the target endpoint and related root port for doing the check. Another example is what we've done in hisi_ptt that we maintian a list of supported root ports and endpoints, but that will be a bit more complex. > Jonathan > > >> --- >> drivers/perf/hisilicon/hisi_pcie_pmu.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/perf/hisilicon/hisi_pcie_pmu.c b/drivers/perf/hisilicon/hisi_pcie_pmu.c >> index 83be3390686c..b91f03c02c57 100644 >> --- a/drivers/perf/hisilicon/hisi_pcie_pmu.c >> +++ b/drivers/perf/hisilicon/hisi_pcie_pmu.c >> @@ -306,10 +306,10 @@ static bool hisi_pcie_pmu_valid_filter(struct perf_event *event, >> if (hisi_pcie_get_trig_len(event) > HISI_PCIE_TRIG_MAX_VAL) >> return false; >> >> - if (requester_id) { >> - if (!hisi_pcie_pmu_valid_requester_id(pcie_pmu, requester_id)) >> - return false; >> - } >> + /* Need to explicitly set filter of "port" or "bdf" */ >> + if (!hisi_pcie_get_port(event) && >> + !hisi_pcie_pmu_valid_requester_id(pcie_pmu, requester_id)) >> + return false; >> >> return true; >> } > > . >