From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80998C433EF for ; Thu, 10 Feb 2022 17:21:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245147AbiBJRVo (ORCPT ); Thu, 10 Feb 2022 12:21:44 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:35178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240987AbiBJRVm (ORCPT ); Thu, 10 Feb 2022 12:21:42 -0500 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB511E70; Thu, 10 Feb 2022 09:21:42 -0800 (PST) Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21ABrIwb010080; Thu, 10 Feb 2022 18:21:36 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=TzbNxtuk3qaB41Fh0ENW7eLI/HU2Jej09ESsJUDZTA8=; b=wGZv7X0ZzSxeucA9AnfnUt8u94mtZ1FbyRi0ymjXRvd2tkNX4Q33pTZ83CP9trIdn8BL Cc7JgyaJ0ZGcVKkQJdM5bUoEjECAVJA0RULUvI88MmIB46Tb77TDnQOS6Z3u4f1YqL6z 0f5jISRF5lB8NJrbTVEzXz6TEymSrAWDLxEgde+NkrX92qOjeqoYrQx4Up/U1+WjUwkE 7RX1J0J7XTnLqDwY6/D/mWkU1frD9IclcR6gVDZVkZDbCB2OCwDRfZynq5edKt+gRYAa xYmmccK7c1+tB3J70PE7kqhkn3v1iPtnc0X96IWCgpJK5aCpdmXFAxAq3jOZJw2tXYm2 Lg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3e4x26bdra-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Feb 2022 18:21:36 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A8AF9100038; Thu, 10 Feb 2022 18:21:35 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 082BF22ECE3; Thu, 10 Feb 2022 18:21:35 +0100 (CET) Received: from [10.201.20.208] (10.75.127.51) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Thu, 10 Feb 2022 18:21:34 +0100 Message-ID: <03bb678a-cbfa-bd04-1c69-8ee5109832e5@foss.st.com> Date: Thu, 10 Feb 2022 18:21:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] usb: dwc2: drd: fix soft connect when gadget is unconfigured Content-Language: en-US To: Fabrice Gasnier , , CC: , , , References: <1644423353-17859-1-git-send-email-fabrice.gasnier@foss.st.com> From: Amelie DELAUNAY In-Reply-To: <1644423353-17859-1-git-send-email-fabrice.gasnier@foss.st.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG2NODE1.st.com (10.75.127.4) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-10_08,2022-02-09_01,2021-12-02_01 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/9/22 17:15, Fabrice Gasnier wrote: > When the gadget driver hasn't been (yet) configured, and the cable is > connected to a HOST, the SFTDISCON gets cleared unconditionally, so the > HOST tries to enumerate it. > At the host side, this can result in a stuck USB port or worse. When > getting lucky, some dmesg can be observed at the host side: > new high-speed USB device number ... > device descriptor read/64, error -110 > > Fix it in drd, by checking the enabled flag before calling > dwc2_hsotg_core_connect(). It will be called later, once configured, > by the normal flow: > - udc_bind_to_driver > - usb_gadget_connect > - dwc2_hsotg_pullup > - dwc2_hsotg_core_connect > > Fixes: 17f934024e84 ("usb: dwc2: override PHY input signals with usb role switch support") > Signed-off-by: Fabrice Gasnier Thanks for your patch, Reviewed-by: Amelie Delaunay Regards, Amelie > --- > drivers/usb/dwc2/drd.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc2/drd.c b/drivers/usb/dwc2/drd.c > index 1b39c47..9b6d44d 100644 > --- a/drivers/usb/dwc2/drd.c > +++ b/drivers/usb/dwc2/drd.c > @@ -130,8 +130,10 @@ static int dwc2_drd_role_sw_set(struct usb_role_switch *sw, enum usb_role role) > already = dwc2_ovr_avalid(hsotg, true); > } else if (role == USB_ROLE_DEVICE) { > already = dwc2_ovr_bvalid(hsotg, true); > - /* This clear DCTL.SFTDISCON bit */ > - dwc2_hsotg_core_connect(hsotg); > + if (hsotg->enabled) { > + /* This clear DCTL.SFTDISCON bit */ > + dwc2_hsotg_core_connect(hsotg); > + } > } else { > if (dwc2_is_device_mode(hsotg)) { > if (!dwc2_ovr_bvalid(hsotg, false))