From: Joe Perches <joe@perches.com>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: apw@canonical.com, akpm@linux-foundation.org, elver@google.com,
linux-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH v1] checkpatch: Add context-analysis attributes
Date: Sat, 14 Nov 2026 06:57:39 -0800 [thread overview]
Message-ID: <03c1afd39a3f167b960a982d1a933619855a975c.camel@perches.com> (raw)
In-Reply-To: <61e4f8997861a1188935435e78682c575552d2a3.camel@perches.com>
On Sat, 2026-11-14 at 06:26 -0800, Joe Perches wrote:
> > How about matching one internal () pair?
> >
> > __guarded_by\s*\(
> > (?:
> > [^()]++ |
> > \([^()]*+\)
> > )*+
> > \)
>
> Sure.
> Please add and use another variable so it's not repeated everywhere.
Reading a bit about balanced parentheses in perl '(?R)'
non capturing recursion works since 5.10.0
Maybe instead use
/\((?:[^()]++|(?R))*\)/
and I should probably rework all of checkpatch's uses of
$balanced_parens to avoid all those weird capture group uses
as it was originally written for perl 5.8 (thanks akpm)
prev parent reply other threads:[~2026-11-14 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 15:12 Vincent Donnefort
2026-11-12 15:23 ` Marco Elver
2026-11-13 3:32 ` Joe Perches
2026-11-14 13:21 ` Vincent Donnefort
2026-11-14 14:26 ` Joe Perches
2026-11-14 14:57 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03c1afd39a3f167b960a982d1a933619855a975c.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=elver@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vdonnefort@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®