From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754248AbcIIPVp (ORCPT ); Fri, 9 Sep 2016 11:21:45 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:34485 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753461AbcIIPTU (ORCPT ); Fri, 9 Sep 2016 11:19:20 -0400 Subject: Re: lockdep warning in btrfs in 4.8-rc3 To: Dave Jones , Christian Borntraeger , LKML , linux-btrfs References: <20160826233624.jao5mztbxhjikm7e@floor.thefacebook.com> <6a3eed93-fb4d-817a-6a59-7e7f91c8ea6d@de.ibm.com> <624b2c3a-5030-3f7f-70d6-4507308d785b@de.ibm.com> <20160909005055.n6be4cvwvi7byk3j@codemonkey.org.uk> From: Chris Mason Message-ID: <03c4ab5c-11bf-9bf5-dd6f-94e913e6efb1@fb.com> Date: Fri, 9 Sep 2016 11:19:03 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160909005055.n6be4cvwvi7byk3j@codemonkey.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c091:180::1:90ef] X-ClientProxiedBy: BN6PR19CA0040.namprd19.prod.outlook.com (10.173.148.154) To CY4PR15MB1238.namprd15.prod.outlook.com (10.172.178.137) X-MS-Office365-Filtering-Correlation-Id: 8d881e0a-7cb9-48c0-6193-08d3d8c4a57b X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1238;2:1WddCQ5KV+WKQHkczjtoS1qV4TGSik0+R002TKpm14NRlJs9znCTnlKpM9LRmHVXdifU2dsaOY9myc0il6HaV9qFggicxW/xlwlNrtMAD2CcIMt83iyNxKQyqXYtCZ17qR5JuKWrdv90eCwBf7xnff0G9MviyWsqRi3pnE8Xvjz1BchDizvhnGJ0XzswtzFi;3:eBnvRM+MTHfhisaG/LW/CU8c6/uY576NdC5Mo5hjzhZrWqZo/rmNkgFmeefIEiMfRUfZIAkfIKNJi8kD8yE/WXd+1mKUS91woKfu4PWvHeYlN4E4gNN5GBaLwo+AkF7v X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1238; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1238;25:sm/QAorEn/qH7z/3cYDAb5OfQfoDHtK268xCwl8y1rJKnIQbK+/NEgWGgbAJnrzr2TXrgw6/hC/lHojtYXe6kcy+cfmyt83LhRxHU4k7KmdbsEbLd5DZDCdjlUz3BFkome5vXkvlUMwAprZapCiym4+2SAOG8ZH1ctPEO49YcjZ1ia7NW+gms+9/Ug2pjTXt+Z/v8oNVYJGn2VooXXDpUz5A1VWFFZNxgvGpbvZqtZ5xUUOh04jHggkVapBzpgzQnldf0EvfmF8l/q20GW9th7O9QNqWfMwncecJR3YY1X0jv6uEdm4QhztO2pdXBZz79vUYiOMlav9B7h+YqGgdNxcuPj2jm8resI5DnpCQ5ot2APxpOX/2bEcl9ajpRkMtwIrkKORQrZKo+Cj/eT5AhEZfuNHIkL8+A1vn2HI8pQN3aFZcgjLUjeTsqudckjXTfUEEY/30CHsO0r4mgzx/Ham0+FYg+FhiV1Qrk8TDlO2f8d2/KUdp59vDPHC7Ym3A/haG54gU69JvFpIdUG/0z9jfyfI+hLL5FcvCfc0Jnr71zhDn6ZdmuA5z77fRVlcWuKOVK94iN4oc/DN619RpSf2g0MoYekLt1kDgXSZtuJPl2Es8vkzywdlT4WBi8wLcoCZ2MgPAWDPdqKemQUIadx5t9/jea8mqUHJ1vOnq8AnokplVlmUpEYz50YEoVeZ33uVJ6Tv3SkjLBm6y2aOlPH+NTrLR1kXGrb2OVfPfYLa3CT6SWuS5ZUWauEuMLSw4JmVXZt2+fPQHm7F+25B0jj7idN+leMubapGPIchzmDY= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1238;31:5fNOYqLZIkJsIEI5wC/ovVlRaWl3IRhN5unme7LFAGagoPQvrFdP2ca0y8dUvssNiJil+NHjSTUofvAE0eIkaA43eBIKMoX6VAWZkR3iKKQwUpU+pDUz5c+Oaci1iBFAE3yhY+yZSt9LHIXa9bAan+CVNipIpngN/i32xUJI9kSj68/XMmZe4DF3J8XLh5AE/e+VLdTx3dpwhrBHU6ud0tW2ZyrioHCNQ9nyizt3y4Q=;20:D0LiKNz1fRsAquP2i/hDgeFQYSOSh1zvWSQPtfCHIWO/9SZBHLeXeksKlUwLcL5Mtatml6BSWaA0cI4zdqOInJylqaV6HxuSAzJzkvJKgQW3fUG1gUj5rqNh6E400LbJ+q2J44YslpPmlGxg1kbcvRJs3K3iLLum5u+Rq8WgCmo=;4:Mic1JAanhP4GRZ9G+Gl2XvKjQVN0yhMQfoqduBsgkkI9IIaqF/BWWAmYFf93VaamoKG6Q8lOvH2f4nfsDcz7p/nzWmx20oBiJw/cyFIe/9+VaiGowQVd0A/yMVl03UE77nUIoWSdLao9YpgRJo3mYnugph7uM9EUHSZWiDqpCsyMt79FqGExe7CK6GnR0Nb3acLF9Vy7hIOVIrEnbawhMpaTrcTu1xLjdOH8hSnfijQJqn6o5X6P6ItVyEEm3SxdmcEh/NP1A3Q9u4u46EtSqqmP9t6n43hlwDVlFs1tfYaSUO8MWzPUZaEyH4XlkhU66OU+XmCltEmMu2gwE1KwYQgUB1eEKSyDZ16I77JR5F4rmjO33iONp2McogrIz751TgHa+9J34VaszBX5eJOlH8fJsUEumiEWwJnCto09BZ2lDK0Y01q5p5aWFYBUCEsq X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY4PR15MB1238;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1238; X-Forefront-PRVS: 00603B7EEF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(199003)(377454003)(51234002)(189002)(24454002)(77096005)(2950100001)(305945005)(106356001)(54356999)(5660300001)(76176999)(101416001)(105586002)(50466002)(189998001)(50986999)(83506001)(107886002)(586003)(65826007)(7846002)(31686004)(15975445007)(23746002)(7736002)(65956001)(4001350100001)(86362001)(81156014)(65806001)(575784001)(230700001)(42186005)(36756003)(47776003)(8676002)(64126003)(1706002)(81166006)(68736007)(5001770100001)(6116002)(19580395003)(2906002)(97736004)(92566002)(19580405001)(93886004)(33646002)(31696002)(3826002)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1238;H:[IPv6:2620:10d:c0a1:1110:8000::2084];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1238;23:YMgBR3j8AUYxCsHsT4oVSdIPiO64i4e2j1lXV?= =?Windows-1252?Q?oTyfZXIBvKgHP7wT0ZOiP4QiC3hmnGu/EFqeIa1tVwaUnl1ycu/hVGAo?= =?Windows-1252?Q?LFxA2vRPQ5DWAVfwbMsFffFY+5X4l/YOIiQ3B3Qsc0OCcabkMNaoe/mI?= =?Windows-1252?Q?3SM5KiZEtT4NVFIydLThDQNiC5530cO4l8XNKkYViNN9blrNC90MOEHN?= =?Windows-1252?Q?8m5QdIqXNWwSes9vk3RVERMFzBZwwWofaRBKBa87YqQSaQ9vnxRO3rHj?= =?Windows-1252?Q?hvM5KS/ynKKUutR49gdXDL22eyJvMd3CgPD43b3NgmPd+DH/mZ5HVqsY?= =?Windows-1252?Q?ehw/NMh2NHo6Bzv5rF+rLfOKOhsiLpASHrm3KgUR+BjaBRRgVxiyI+kl?= =?Windows-1252?Q?RLbmXM4HFIWWFXrdgxmPUnzXTjJXMoZw4R6x7c3Tvxjy9LZ3VWL9Mhcn?= =?Windows-1252?Q?DsIPwuj/Fm9bqzL9/yM61EXO/XSlhdKqdGJdS6jzyUxArheECQrj3CTf?= =?Windows-1252?Q?mLJaERtdWWr+gN3oT2TXb+jaY0OYmpbAqvt/weuv/eF52yMfaDqabHd0?= =?Windows-1252?Q?b6vEcpLL7mhh+BLLcJythTb4ZNJuvkz3ksjuYMLO9vliN1mqpU/agjh1?= =?Windows-1252?Q?o3nBeVYzOy8i9VXWC8H1gVtgOK0R5O1UvRvRWczx89vJHN04N4D1lC/x?= =?Windows-1252?Q?oYfFI/4gORZB5CFBpn0jSEMXBBK0F4x7Ouo3iT4/pl3ihXlZ/tRFculr?= =?Windows-1252?Q?71llyhsIGMTqNoIKjbs6GA0Iyob1GiyWctWWD4OQLpeYZ9TWA9RmdkYw?= =?Windows-1252?Q?FeARmfzuoIKX3FLUOIYk1ZUp14ltfXO08FdP7deyoo1TyOzTrjB4OGGN?= =?Windows-1252?Q?cYGqKODAZdK0DhE/4ajjUYVSGrkLaE4dT7K6JFWl7lqgo6XoVzj6xEiW?= =?Windows-1252?Q?wlpUW660/hwLEU6lZHNwuNyBFz21DXEQdeLBVACsFHxh/1MP2ngNTGRR?= =?Windows-1252?Q?Q//+NCcocued0so2pqkSip0cSSLrKhG1fykl48rrJQCW9OFp0uYFxXgm?= =?Windows-1252?Q?O9wi9lu4LbjbZjRR+GFb9yKmXwNcOz4BvcFjKSf40+5zY+9nap6FcDj/?= =?Windows-1252?Q?CYl7+LSqsp1Etwa15dxKPoWmtRlVy0XRnG03qcyO9jn5pLGUgDoopn+g?= =?Windows-1252?Q?4toYo9ckkaCKUHvh/j3ZLpXsczABp0pTtYLg3WLJtOoROMXIyVhVq+dt?= =?Windows-1252?Q?lI2zrEIvYlUGVYkhzeF+KaL8VpHbfevMIynlj7kx4bxeQJ+8v67bIcEv?= =?Windows-1252?Q?5CtgywmJ5nP+fn6ojNkroK5DcygRP/tPd+yEj5fvTG5HEcGXU1xieMsa?= =?Windows-1252?Q?0ikazJDOJBux9METZ+5IU4y+Qec4SYchiTz74iR2MKoSmGuUarrBqpAV?= =?Windows-1252?Q?MzUEVtCiwYTPSB3tkfjx2JuEiajwsBb05cbfNUpsG06VNPYvztn3uRzW?= =?Windows-1252?Q?rXeYV0kbNcpiJ+iRAaqsO8eR3Fu?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1238;6:h6AF4CJFHHDJ9v+IKLAM0TFOQQUaxC3o5eRDjfldbHnZLSHyEwH3r03jXNliENubfcXzTt9hdDnzOD45DdWHxFWNT98AU4CvdNO19FMKL3spIVUxWnNXij5HcDv22EMUIM3HoecVgi8OwhLyglmRnsF9uPIOgJfqoVMWfKfgcSFNVN/KvlXTWZ6oJz58xrDUNO80EjJlQFrn7Cd6oNkZSXif/x+ncYt0X+5hxbhfqvu9+YOdArQdWjd7xrAmAYCP+Vv4A29jcUWP/7w4I7y7CMVkIbTu6kbfI/5X/JDSb4w=;5:4IOwqdwSIxOrww0EMClEDy2XZmw1E6XbFRvtI6oeWJ3OWo77vNrehIFB7r3euPrBOLw2KqBsAzMjccPmkGXlVSHblQnRNNIZLGHqvVEBabnvtY/OWcVxwqmgJCluLOYIPpilJd6bksED3H/9MEva1A==;24:+Ai0U1x5kcoGlG6F5998M25QV8EzNGVQY0h05jS3Dj3DPhDM/Z/JfOpuZAfICQQnpSbBM5e4X9w7AszKG7LD5wBrv095ekyo+n7Exfg5HB4=;7:Uaerb87CTYrzTgSA6mXeyJgxoRDl10zaHdCrK1FNYKlXbCduQcokK6kQKNC6xG7D6nPPxETiDns9GJlk7MJIPjJIGfXVOPTbk3PBSNWFfd3oDLr4E+Nake4dpzMysCt6j9DUf3NoUWtx9+CC/kGba4K5raAEls4q+UBl07n7OnXPacQHNjaKDRXVzyLHguxllgUVTAkXuBORRgUO7zyhvEJ7SURJfiSMpnLERAeQtMonLHc/Cx/7HmdNFlrGbG6T SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1238;20:YtimgGeafHeBGtC6FHlnUZZdoNy9yBFouubF9Rcj0v9q5lBuScUUhqlmlqYC9KgJvpC/eii4c0kwo7nRF7tza5TowJ7SYR4ZqHJnRcY3DbxYELMHdmTdQPf8LzbKw3qcxY6Tk8oglJIEi4WQL8GsTU6DShBmSdALQ+j9OXWvNek= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2016 15:19:08.2921 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1238 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-09_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/2016 08:50 PM, Dave Jones wrote: > On Thu, Sep 08, 2016 at 08:58:48AM -0400, Chris Mason wrote: > > On 09/08/2016 07:50 AM, Christian Borntraeger wrote: > > > On 09/08/2016 01:48 PM, Christian Borntraeger wrote: > > >> Chris, > > >> > > >> with 4.8-rc3 I get the following on an s390 box: > > > > > > Sorry for the noise, just saw the fix in your pull request. > > > > > > > The lockdep splat is still there, we'll need to annotate this one a little. > > Here's another one (unrelated?) that I've not seen before today: > > WARNING: CPU: 1 PID: 10664 at kernel/locking/lockdep.c:704 register_lock_class+0x33f/0x510 > CPU: 1 PID: 10664 Comm: kworker/u8:5 Not tainted 4.8.0-rc5-think+ #2 > Workqueue: writeback wb_workfn (flush-btrfs-1) > 0000000000000097 00000000b97fbad3 ffff88013b8c3770 ffffffffa63d3ab1 > 0000000000000000 0000000000000000 ffffffffa6bf1792 ffffffffa60df22f > ffff88013b8c37b0 ffffffffa60897a0 000002c0b97fbad3 ffffffffa6bf1792 > Call Trace: > [] dump_stack+0x6c/0x9b > [] ? register_lock_class+0x33f/0x510 > [] __warn+0x110/0x130 > [] warn_slowpath_null+0x2c/0x40 > [] register_lock_class+0x33f/0x510 > [] ? bio_add_page+0x7e/0x120 > [] __lock_acquire.isra.32+0x5b/0x8c0 > [] lock_acquire+0x58/0x70 > [] ? btrfs_try_tree_write_lock+0x4a/0xb0 [btrfs] > [] _raw_write_lock+0x38/0x70 > [] ? btrfs_try_tree_write_lock+0x4a/0xb0 [btrfs] > [] btrfs_try_tree_write_lock+0x4a/0xb0 [btrfs] > [] lock_extent_buffer_for_io+0x28/0x2e0 [btrfs] > [] btree_write_cache_pages+0x231/0x550 [btrfs] > [] ? btree_set_page_dirty+0x20/0x20 [btrfs] > [] btree_writepages+0x74/0x90 [btrfs] > [] do_writepages+0x3e/0x80 > [] __writeback_single_inode+0x42/0x220 > [] writeback_sb_inodes+0x351/0x730 > [] ? __wb_update_bandwidth+0x1c1/0x2b0 > [] wb_writeback+0x138/0x2a0 > [] wb_workfn+0x10e/0x340 > [] ? __lock_acquire.isra.32+0x1cf/0x8c0 > [] process_one_work+0x24f/0x5d0 > [] ? process_one_work+0x1e0/0x5d0 > [] worker_thread+0x53/0x5b0 > [] ? process_one_work+0x5d0/0x5d0 > [] kthread+0x120/0x140 > [] ? finish_task_switch+0x6a/0x200 > [] ret_from_fork+0x1f/0x40 > [] ? kthread_create_on_node+0x270/0x270 > ---[ end trace 7b39395c07435bf1 ]--- > > > 700 /* > 701 * Huh! same key, different name? Did someone trample > 702 * on some memory? We're most confused. > 703 */ > 704 WARN_ON_ONCE(class->name != lock->name); > > That seems kinda scary. There was a trinity run going on at the same time, > so this _might_ be a random scribble from something unrelated to btrfs, > but just in case.. > > IWBNI that code printed out both cases so I could see if this was > corruption or two unrelated keys. I'll make it do that in case it > happens again. I haven't seen this one before, if you could make it happen again, that would be great ;) -chris > > Dave > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >