mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Raju Rangoju <Raju.Rangoju@amd.com>, netdev@vger.kernel.org
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, richardcochran@gmail.com,
	linux-kernel@vger.kernel.org, Shyam-sundar.S-k@amd.com
Subject: Re: [PATCH net-next] amd-xgbe: Add PPS periodic output support
Date: Thu, 21 Aug 2025 11:58:30 +0200	[thread overview]
Message-ID: <03c92599-00e3-4481-a97d-1acd901d0ac0@redhat.com> (raw)
In-Reply-To: <20250818115801.2518912-1-Raju.Rangoju@amd.com>

On 8/18/25 1:58 PM, Raju Rangoju wrote:
> @@ -122,6 +148,8 @@ void xgbe_ptp_register(struct xgbe_prv_data *pdata)
>  	info->adjtime = xgbe_adjtime;
>  	info->gettimex64 = xgbe_gettimex;
>  	info->settime64 = xgbe_settime;
> +	info->n_per_out = pdata->hw_feat.pps_out_num;
> +	info->n_ext_ts = pdata->hw_feat.aux_snap_num;

Both pps_out_num and aux_snap_num are read from 3 bits out of a
register, and I don't see any check to prevent such values exceeding the
limit hardcoded below (4). Why don't you need some additional sanity check?

Thanks,

Paolo


      reply	other threads:[~2025-08-21  9:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-18 11:58 Raju Rangoju
2025-08-21  9:58 ` Paolo Abeni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03c92599-00e3-4481-a97d-1acd901d0ac0@redhat.com \
    --to=pabeni@redhat.com \
    --cc=Raju.Rangoju@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®