From: "Zhang, Rui" <rui.zhang@intel.com>
To: "rafael@kernel.org" <rafael@kernel.org>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] thermal/core: Reset cooling state during cooling device unregistration
Date: Wed, 29 Mar 2023 06:28:26 +0000 [thread overview]
Message-ID: <03c9f107b75c84ebb69abfe22d6795788a315068.camel@intel.com> (raw)
In-Reply-To: <CAJZ5v0h6PX8EmPtVKbPPG+e0FZn53CGG=RvpOH-vuO0fNF6-=g@mail.gmail.com>
On Tue, 2023-03-28 at 19:54 +0200, Rafael J. Wysocki wrote:
> > > What do the other cooling device drivers do in general when they
> > > get
> > > removed?
> >
> > No cooling device driver has extra handling after cdev
> > unregistration.
>
> However, the question regarding what to do when the driver of a
> cooling device in use is being removed is a valid one.
>
> One possible approach that comes to mind could be to defer the driver
> removal until the overheat condition goes away, but anyway it would
> be
> better to do that in the core IMV.
In this case, we should guarantee that the thermal zone driver is still
functional. i.e. it still can get temperature change notifications and
update the thermal zone. I doubt if current thermal zone drivers can
guarantee this.
Given that this is a rare case, and the current behavior is not perfect
but still acceptable, maybe we can leave this low priority for now.
thanks,
rui
next prev parent reply other threads:[~2023-03-29 6:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 7:08 [PATCH v2 1/5] thermal/core: Update cooling device during thermal zone unregistration Zhang Rui
2023-03-24 7:08 ` [PATCH 2/5] thermal/core: Reset cooling state during cooling device unregistration Zhang Rui
2023-03-24 13:19 ` Rafael J. Wysocki
2023-03-27 14:50 ` Zhang, Rui
2023-03-27 15:13 ` Rafael J. Wysocki
2023-03-28 2:46 ` Zhang, Rui
2023-03-28 17:54 ` Rafael J. Wysocki
2023-03-29 6:28 ` Zhang, Rui [this message]
2023-03-24 7:08 ` [PATCH 3/5] thermal/core: Remove thermal_bind_params structure Zhang Rui
2023-03-29 18:39 ` Rafael J. Wysocki
2023-03-30 1:11 ` Zhang, Rui
2023-03-24 7:08 ` [PATCH 4/5] thermal/core: Enforce paired .bind/.unbind callbacks Zhang Rui
2023-03-24 13:24 ` Rafael J. Wysocki
2023-03-24 13:25 ` Rafael J. Wysocki
2023-03-27 15:03 ` Zhang, Rui
2023-03-24 7:08 ` [PATCH 5/5] thermal/core: Avoid unbind for thermal zones without .unbind() Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03c9f107b75c84ebb69abfe22d6795788a315068.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®