From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA96C43334 for ; Wed, 29 Jun 2022 16:50:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231201AbiF2QuV (ORCPT ); Wed, 29 Jun 2022 12:50:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230484AbiF2QuU (ORCPT ); Wed, 29 Jun 2022 12:50:20 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AF03F6E; Wed, 29 Jun 2022 09:50:20 -0700 (PDT) Received: from fraeml708-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LY6pP23BRz6H6m6; Thu, 30 Jun 2022 00:47:57 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml708-chm.china.huawei.com (10.206.15.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 29 Jun 2022 18:50:18 +0200 Received: from [10.195.244.164] (10.195.244.164) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 29 Jun 2022 17:50:16 +0100 Message-ID: <03cab2a6-0217-d688-8c86-5fd58e847dde@huawei.com> Date: Wed, 29 Jun 2022 17:50:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v6 0/4] Rewrite jevents program in python To: Ian Rogers CC: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , "Namhyung Kim" , Kan Liang , Andi Kleen , Zhengjun Xing , "Felix Fietkau" , Qi Liu , Like Xu , , , Nick Forrington , Kajol Jain , James Clark , Andrew Kilroy , "Paul A . Clarke" , Will Deacon , Mathieu Poirier , , , , , Caleb Biggers , Perry Taylor , Kshipra Bopardikar , Stephane Eranian References: <20220627025744.106527-1-irogers@google.com> <6f9649d7-8129-57cf-8ab5-03abacd9cb6e@huawei.com> From: John Garry In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.195.244.164] X-ClientProxiedBy: lhreml710-chm.china.huawei.com (10.201.108.61) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/06/2022 17:47, Ian Rogers wrote: > On Mon, Jun 27, 2022 at 10:27 AM John Garry wrote: >> >> On 27/06/2022 03:57, Ian Rogers wrote: >>> A challenge with this code is in avoiding regressions. For this reason >>> the jevents.py produces identical output to jevents.c, validated with a >>> test script and build target. >>> >>> v6. Adds Tested-by from Zhengjun Xing >>> and Thomas Richter. Fixes issues spotted >>> by Jiri Olsa, jsmn.c wasn't deleted and the >>> empty pmu-events.c didn't pass the pmu-events test. It also adds a >>> missing mkdir which is necessary before creating pmu-events.c and >>> tweaks the quiet display code in the empty case to display a gen. >>> v5. Adds a 2>/dev/null as suggested by David Laight >> >> >> Hmmm... shouldn't this be v7? Anyway what I got with message-id >> 20220627025744.106527-1-irogers@google.com now seems to build and the >> output looks ok. >> >> Thanks, >> John > > Thanks John, I think I've confused myself by working on greater than 1 > machine wrt version numbers. I can re-send as v7, would it be okay to > put on a Tested-by: John Garry ? > Sure, Tested-by: John Garry > .