From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a3-smtp.messagingengine.com (fhigh-a3-smtp.messagingengine.com [103.168.172.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26BD815DBA3; Fri, 27 Sep 2024 07:05:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.154 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727420729; cv=none; b=R9jXi6Hjv0F7Oa4OZvn3WyDVzrZuVE2Ik5auzsmi8KzM+PpXvTGhTNdriy/AVRNvKkhUR5+b7InyL/tJ1kMGo9scfFywH9eS4A8GLuWVNW6B96lz5aC1tu9VSIxEDmzfVeLffDPOyfB75KWTDrpBz9MWnfgiWatLn1nfsq/aPz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727420729; c=relaxed/simple; bh=R0uVe1RKJ8guhY5oxJJmoR0nriXvqHNs/NY3cC1pu7o=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=VmEaDkZhJpgDyOPsOlrTiFBuuL0HLiU7q+dqw6SkcsbrhlgSPr4wEg0NGjLme2mvVzYwg2uAqUIjnjy/vnOugSwjbaUAbdlmBnHp+gzspRenanwMdFhjDkcQZjqnMMygUSrS9zz4usTFY33EwcYw1j47jiKaYf/il7DlvDWqp70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ljones.dev; spf=none smtp.mailfrom=ljones.dev; dkim=pass (2048-bit key) header.d=ljones.dev header.i=@ljones.dev header.b=xaxc3zKt; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=hUrsXTUU; arc=none smtp.client-ip=103.168.172.154 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ljones.dev Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ljones.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ljones.dev header.i=@ljones.dev header.b="xaxc3zKt"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="hUrsXTUU" Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfhigh.phl.internal (Postfix) with ESMTP id 4A7B511402E3; Fri, 27 Sep 2024 03:05:26 -0400 (EDT) Received: from phl-imap-01 ([10.202.2.91]) by phl-compute-08.internal (MEProxy); Fri, 27 Sep 2024 03:05:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1727420726; x=1727507126; bh=R0uVe1RKJ8guhY5oxJJmoR0nriXvqHNs/NY3cC1pu7o=; b= xaxc3zKtS9IsEeXQnDR0IDDuxcj+pCnkWvbv+NHe9wwbDzEzjArg/gS6svhWCZ8S d/HMcjPUxkTkXCkonJ4GvQIZA5iGFbyCrbcDcgtJxNd5wEelIa4PSGLsreVwcNw9 B21MpZ4NQZVTN56pC9MsnhKRpXNHZybO3zo4aJwej0lon+o9JAs+EK8J8TOVLnOT rOe4FPf3koXw846a8w1mJgi1NhbREFKZwcWnW9ONonxvySFUt2rcLjqkwbnwz2ei JjNNVIc3GkV1QPcnzFPZtqIz7GQsNCNFhuZ3euHwzYbUx1OJEM2lgPvayhdSNuTD smxvtKiNvKAp/rQX0Q5KVw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1727420726; x= 1727507126; bh=R0uVe1RKJ8guhY5oxJJmoR0nriXvqHNs/NY3cC1pu7o=; b=h UrsXTUUPik0APXJsmQ5C7/7JDh5ddk7SWArdSCIU11ViX6kQq91DvwT/cNYbLXof IJil0w1XVbR/Kanu/33L0U4z6gP1fk1wDaqjTjzCCZSpDmwD+yzi6Jr1kv6bIRQN wXeY7mE6xjcF2kdk2aWGCtJxcP5OISEWwfwzpz8rXHauwAevPOMeimCJl/QZMaX6 cLCYctZ3InAc57yw1dSgiiwfLoGg74mcubR2O8peSPMZE3Fjh3LCCgbOL9iajvGJ dkTAypt4qF5rNz78byTm2XYWFH+BtZl9c6PQ32GNhVgLeqT5g6y4A4BdSAVyOls8 HS6gThDvOQ6RHptAg/HFA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddtkedguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthhqredtredt jeenucfhrhhomhepfdfnuhhkvgculfhonhgvshdfuceolhhukhgvsehljhhonhgvshdrug gvvheqnecuggftrfgrthhtvghrnhepkeeljeejtdejuddvheeljeffhfeggfevjeegtddv tdetjedtieejvdffhefgvdejnecuffhomhgrihhnpegtmhhurdgvughunecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhhukhgvsehljhhonhgv shdruggvvhdpnhgspghrtghpthhtohepuddupdhmohguvgepshhmthhpohhuthdprhgtph htthhopegtohhrvghnthhinhdrtghhrghrhiesghhmrghilhdrtghomhdprhgtphhtthho pegsvghnthhishhssehkvghrnhgvlhdrohhrghdprhgtphhtthhopehjihhkohhssehkvg hrnhgvlhdrohhrghdprhgtphhtthhopehsuhhpvghrmhdusehkvghrnhgvlhdrohhrghdp rhgtphhtthhopehilhhpohdrjhgrrhhvihhnvghnsehlihhnuhigrdhinhhtvghlrdgtoh hmpdhrtghpthhtohephhguvghgohgvuggvsehrvgguhhgrthdrtghomhdprhgtphhtthho pehkvghrnhgvlhdqjhgrnhhithhorhhssehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtg hpthhtoheplhhinhhugidqihhnphhuthesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgt phhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 08BA2336007C; Fri, 27 Sep 2024 03:05:26 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Fri, 27 Sep 2024 19:05:05 +1200 From: "Luke Jones" To: "Markus Elfring" , platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org, "Benjamin Tissoires" , "Corentin Chary" , "Hans de Goede" , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , "Jiri Kosina" , "Mario Limonciello" Cc: LKML , kernel-janitors@vger.kernel.org Message-Id: <03cfc83f-6f19-436f-9896-78fd6b8cd8f7@app.fastmail.com> In-Reply-To: <22c231f2-c28e-4083-8e62-590a8c2d8844@web.de> References: <20240926092952.1284435-4-luke@ljones.dev> <08320b8e-a71b-4055-9fdf-1df76530ec1a@web.de> <22c231f2-c28e-4083-8e62-590a8c2d8844@web.de> Subject: Re: [v4 3/9] platform/x86: asus-armoury: move existing tunings to asus-armoury module Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable html a third time... I think I need to do something about that. Very ver= y sorry. On Fri, 27 Sep 2024, at 6:09 PM, Markus Elfring wrote: > >> =E2=80=A6 > >>> +++ b/drivers/platform/x86/asus-armoury.h > >>> @@ -0,0 +1,146 @@ > >> =E2=80=A6 > >>> +#ifndef _ASUS_BIOSCFG_H_ > >>> +#define _ASUS_BIOSCFG_H_ > >> =E2=80=A6 > >> > >> I suggest to omit leading underscores from such identifiers. > >> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+decla= re+or+define+a+reserved+identifier > =E2=80=A6 > > the link is C standard, not kernel C right? >=20 > Advice is offered in such a direction. >=20 >=20 > > Pretty much everything I look at in the kernel seems to use the lead= ing underscores. >=20 > How much would you like to care for standard compliance concerns > together with your software developments? I only ask about because it seems to deviate from everything else I've v= iewed. For example the older `asus-wmi.h` has: #ifndef _ASUS_WMI_H_ #define _ASUS_WMI_H_ and every other header in the drivers/platform/x86 dir is similar. If wh= at I'm supposed to is omit the leading `_` then sure I'll do it, it's no= t of any consequence to me. But the difference gave me pause is all :) Kind regards, Luke. > Regards, > Markus >=20