From: Krzysztof Kozlowski <krzk@kernel.org>
To: shao.mingyin@zte.com.cn, shawn.lin@rock-chips.com
Cc: yang.yang29@zte.com.cn, xu.xin16@zte.com.cn,
ye.xingchen@zte.com.cn, lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
bhelgaas@google.com, heiko@sntech.de, linux-pci@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, zhang.enpei@zte.com.cn
Subject: Re: [PATCH] drivers: pci: controller: pcie-rockchip: Use dev_err_probe()
Date: Fri, 4 Apr 2025 08:09:40 +0200 [thread overview]
Message-ID: <03d12cd2-c719-4703-a0eb-2a32ef41af92@kernel.org> (raw)
In-Reply-To: <20250403154326411S4luMrK8A5RXovincATzF@zte.com.cn>
On 03/04/2025 09:43, shao.mingyin@zte.com.cn wrote:
> From: Zhang Enpei <zhang.enpei@zte.com.cn>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Zhang Enpei <zhang.enpei@zte.com.cn>
> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
> ---
Considering zte is sending untested patches from poor automation (or AI
generated), this might be correct or might not be because it does not
look like probe path.
Anyway, don't send patch by patch and line by line. Why you did not
decide to fix all of the places in these drivers?
NAK
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-04 6:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 7:43 shao.mingyin
2025-04-04 6:09 ` Krzysztof Kozlowski [this message]
2025-04-04 12:52 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03d12cd2-c719-4703-a0eb-2a32ef41af92@kernel.org \
--to=krzk@kernel.org \
--cc=bhelgaas@google.com \
--cc=heiko@sntech.de \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=shao.mingyin@zte.com.cn \
--cc=shawn.lin@rock-chips.com \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
--cc=ye.xingchen@zte.com.cn \
--cc=zhang.enpei@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®