From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: Chintan Vankar <c-vankar@ti.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Richard Cochran <richardcochran@gmail.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
Pekka Varis <p-varis@ti.com>
Subject: Re: [PATCH net-next 2/2] net: ethernet: ti: am65-cpsw: Enable RX HW timestamp only for PTP packets
Date: Sat, 24 Feb 2024 14:29:05 +0530 [thread overview]
Message-ID: <03d53049-e649-4714-8ad4-49619a5e9475@ti.com> (raw)
In-Reply-To: <4c82705d-b05c-4ee8-88ed-42f944a023ac@kernel.org>
On Mon, Feb 19, 2024 at 12:59:55PM +0200, Roger Quadros wrote:
> Hi,
>
> On 15/02/2024 13:09, Chintan Vankar wrote:
> > The CPSW peripherals on J7AHP, J7VCL, J7AEP, J7ES, AM64 SoCs have
> > an errata i2401 "CPSW: Host Timestamps Cause CPSW Port to Lock up".
>
...
> >
> > @@ -856,6 +852,9 @@ static int am65_cpsw_nuss_rx_packets(struct am65_cpsw_common *common,
> > ndev_priv = netdev_priv(ndev);
> > am65_cpsw_nuss_set_offload_fwd_mark(skb, ndev_priv->offload_fwd_mark);
> > skb_put(skb, pkt_len);
> > + skb_reset_mac_header(skb);
>
> Why do you need to add skb_reset_mac_header here?
>
> > + if (port->rx_ts_enabled)
> > + am65_cpts_rx_timestamp(common->cpts, skb);
>
> The timestamp should be added before you do skb_put().
Roger,
Could you please clarify why the timestamp should be added before
skb_put()?
Regards,
Siddharth.
next prev parent reply other threads:[~2024-02-24 8:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 11:09 [PATCH net-next 1/2] net: ethernet: ti: am65-cpts: Enable PTP RX HW timestamp using CPTS FIFO Chintan Vankar
2024-02-15 11:09 ` [PATCH net-next 2/2] net: ethernet: ti: am65-cpsw: Enable RX HW timestamp only for PTP packets Chintan Vankar
2024-02-16 22:21 ` Jacob Keller
2024-03-01 10:48 ` Chintan Vankar
2024-03-01 21:32 ` Keller, Jacob E
2024-02-19 10:59 ` Roger Quadros
2024-02-24 8:59 ` Siddharth Vadapalli [this message]
2024-02-26 12:18 ` Roger Quadros
2024-02-27 6:15 ` Chintan Vankar
2024-02-16 22:20 ` [PATCH net-next 1/2] net: ethernet: ti: am65-cpts: Enable PTP RX HW timestamp using CPTS FIFO Jacob Keller
2024-02-19 10:25 ` Roger Quadros
2024-02-19 11:24 ` Roger Quadros
2024-02-26 9:08 ` Chintan Vankar
2024-02-26 12:49 ` Roger Quadros
2024-03-01 11:06 ` Chintan Vankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03d53049-e649-4714-8ad4-49619a5e9475@ti.com \
--to=s-vadapalli@ti.com \
--cc=c-vankar@ti.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p-varis@ti.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®