From: Paul Eggert <eggert@cs.ucla.edu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
stable <stable@vger.kernel.org>,
patches@lists.linux.dev,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
shuah@kernel.org, patches@kernelci.org,
lkft-triage@lists.linaro.org, Pavel Machek <pavel@denx.de>,
Jon Hunter <jonathanh@nvidia.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
srw@sladewatkins.net, rwarsow@gmx.de,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jim Meyering <meyering@fb.com>
Subject: Re: diffutils file mode (was Re: [PATCH 5.15 00/37] 5.15.96-rc2 review)
Date: Fri, 24 Feb 2023 12:20:23 -0800 [thread overview]
Message-ID: <03dac14b-ed62-3e2b-878f-b145383ea9f8@cs.ucla.edu> (raw)
In-Reply-To: <CAHk-=wiZ9vaM23eW2k4R-ovtcWLyL8PWvnCG=RyeY4XXgZ6BCg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
On 2023-02-24 11:16, Linus Torvalds wrote:
> GNU diffutils have never actually grown the
> ability to generate those extensions
Thanks for pointing this out. I added this to our list of things to do,
by installing the attached patch to the GNU diffutils TODO file. If this
patch's wording isn't right, please let me know, as I haven't read this
whole email thread, just the three emails sent directly to me.
[-- Attachment #2: 0001-maint-add-diff-git-TODO.patch --]
[-- Type: text/x-patch, Size: 894 bytes --]
From 3fa7218567bdcf958f1342c13c848c9e2f2d38c5 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 24 Feb 2023 12:13:12 -0800
Subject: [PATCH] maint: add 'diff --git' TODO
* TODO: Suggest better compatibility with 'git diff -p'.
From a suggestion by Linus Torvalds
<https://lkml.org/lkml/2023/2/24/797>.
---
TODO | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/TODO b/TODO
index 5132de8..25fc22b 100644
--- a/TODO
+++ b/TODO
@@ -1,3 +1,9 @@
+Add --git option to generate output compatible with 'git diff -p'.
+This would behave like 'diff -p', except that it would also generate
+the extended headers 'old mode', 'new mode', 'deleted file mode', and
+'new file mode', and it would quote file names with unusual characters.
+GNU patch already parses this format.
+
Add --include option (opposite of --exclude).
Look into sdiff improvement here:
--
2.37.2
next prev parent reply other threads:[~2023-02-24 20:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 19:16 Linus Torvalds
2023-02-24 19:32 ` Andrew Morton
2023-02-24 20:00 ` Linus Torvalds
2023-02-24 20:20 ` Paul Eggert [this message]
2023-02-24 20:37 ` Linus Torvalds
2023-02-24 20:51 ` Slade Watkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03dac14b-ed62-3e2b-878f-b145383ea9f8@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=akpm@linux-foundation.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkft-triage@lists.linaro.org \
--cc=meyering@fb.com \
--cc=nathan@kernel.org \
--cc=patches@kernelci.org \
--cc=patches@lists.linux.dev \
--cc=pavel@denx.de \
--cc=rwarsow@gmx.de \
--cc=shuah@kernel.org \
--cc=srw@sladewatkins.net \
--cc=stable@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®