From: "Arnd Bergmann" <arnd@arndb.de>
To: "Huacai Chen" <chenhuacai@loongson.cn>,
"Huacai Chen" <chenhuacai@kernel.org>
Cc: loongarch@lists.linux.dev,
Linux-Arch <linux-arch@vger.kernel.org>,
"Xuefeng Li" <lixuefeng@loongson.cn>, guoren <guoren@kernel.org>,
"WANG Xuerui" <kernel@xen0n.name>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] LoongArch: Mark __xchg() and __cmpxchg() as __always_inline
Date: Mon, 10 Oct 2022 14:04:52 +0200 [thread overview]
Message-ID: <03e79306-1b6a-48a9-b851-d9be057bf83e@app.fastmail.com> (raw)
In-Reply-To: <20221010115620.779812-1-chenhuacai@loongson.cn>
On Mon, Oct 10, 2022, at 1:56 PM, Huacai Chen wrote:
> Commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING
> forcibly") allows compiler to uninline functions marked as 'inline'.
> In case of __xchg()/__cmpxchg() this would cause to reference
> BUILD_BUG(), which is an error case for catching bugs and will not
> happen for correct code, if __xchg()/__cmpxchg() is inlined.
>
> This bug can be produced with CONFIG_DEBUG_SECTION_MISMATCH enabled,
> and the solution is similar to below commits:
> 46f1619500d0225 ("MIPS: include: Mark __xchg as __always_inline"),
> 88356d09904bc60 ("MIPS: include: Mark __cmpxchg as __always_inline").
>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Looks good to me,
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2022-10-10 12:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 11:56 Huacai Chen
2022-10-10 12:04 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03e79306-1b6a-48a9-b851-d9be057bf83e@app.fastmail.com \
--to=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=guoren@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=loongarch@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®