mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: simon@mungewell.org
To: "Mark Brown" <broonie@opensource.wolfsonmicro.com>
Cc: simon@mungewell.org, "Jiri Kosina" <jkosina@suse.cz>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Michael Bauer" <michael@m-bauer.org>,
	"Michal Maly" <madcatxster@gmail.com>
Subject: Re: [PATCH 1/2] HID: hid-lg4ff add support for G27 LEDs
Date: Mon, 12 Mar 2012 15:05:39 -0400	[thread overview]
Message-ID: <03eaca06ba2629f55144daa5a386c74b.squirrel@mungewell.org> (raw)
In-Reply-To: <20120312183235.GA28451@opensource.wolfsonmicro.com>


>> The LEDs on the G27 are very much more specific, mounted on the yoke of
>> the gaming wheel.
>
>> Would this require the use/complexity of the LED subsystem?
>
> Well, it'd mean that applications that know how to drive LEDs will be
> able to use the LEDs on this wheel with less per device knowledge which
> seems like a useful thing and if someone wants to remap a LED to "new
> mail" or whatever that'll be easier (nethack has the mailer daemon
> deliver a scroll of mail!).

I'm not familiar with the LED subsystem, but my concerns would be that
this would add a whole load of code to implement.

Most of concern is the fact that the Logitech wheels are transitioned from
a 'simple' wheel when they are plugged in to an 'advanced' wheel, they
release/re-register with a different USB ID.

The port (for a lack of a better word) for controlling the LEDs is mixed
in with the FF and wheel configuration commands. All this is handled
within the hid-lg4ff driver (if FF is not enabled you just get the
'simple' wheel behaviour).

If you can point me at some (simple) implementations of the LED subsystem,
possibly with some guidance, we can look to see if the added complexity is
actually worth it.

I'd be pretty sure that other gaming controllers don't abstract their LEDs
via this subsystem,
Simon.

PS. I don't really care about email when screaming around Laguna Seca ;-)



  reply	other threads:[~2012-03-12 19:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12 15:17 Simon Wood
2012-03-12 15:17 ` [PATCH 2/2] HID: hid-lg4ff clean up attribution Simon Wood
2012-03-12 15:46 ` [PATCH 1/2] HID: hid-lg4ff add support for G27 LEDs Jiri Kosina
2012-03-12 18:04   ` simon
2012-03-12 18:07     ` Mark Brown
2012-03-12 18:19       ` simon
2012-03-12 18:32         ` Mark Brown
2012-03-12 19:05           ` simon [this message]
2012-03-12 19:12             ` Mark Brown
2012-03-13  8:23             ` Jiri Kosina
2012-03-12 16:09 ` Jiri Kosina
2012-03-13 21:08 simon
2012-03-13 21:11 ` simon
2012-03-13 21:24 ` Jiri Kosina
2012-03-13 21:44   ` simon
2012-03-14  1:51   ` simon
2012-04-13 12:59 [PATCH] HID: hid-lg4ff: Add " Jiri Kosina
2012-04-18  7:03 ` [PATCH 1/2] " Simon Wood
2012-04-18 11:24   ` Jiri Kosina
2012-04-18 14:58     ` simon
2012-04-20 10:05       ` Jiri Kosina
2012-04-21 12:41         ` Simon Wood
2012-04-23 18:55           ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03eaca06ba2629f55144daa5a386c74b.squirrel@mungewell.org \
    --to=simon@mungewell.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madcatxster@gmail.com \
    --cc=michael@m-bauer.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®